August 2024 - wine-gitlab

Re: [PATCH v4 0/2] MR6283: msvcr120: Implement feholdexcept. - approved
by Alexandre Julliard (＠julliard) 19 Aug '24

19 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6283

1 0

[PATCH 0/11] MR6314: dssenh: Fix signature generation and verification and refactored corresponding tests
by Sven Püschel (＠akarisu.de) 19 Aug '24

19 Aug '24

With the goal of fixing the [Sven Bømwøllen series: Several games crash after loading screen](https://bugs.winehq.org/show_bug.cgi?id=55936) issue, I did some refactoring on the corresponding tests to separate them. Afterwards I've added a signature verification test for this bug and fixed the wrong byte order in the dssenh signatures. With the refactoring of the tests, they also caught a missing BCryptFinishHash in the CPSignHash function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6314

3 13

[PATCH 0/2] MR6308: ntdll: Add UNC path handling to LoadLibrary
by Piotr Caban (＠piotr) 19 Aug '24

19 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6308

3 5

[PATCH v4 0/6] MR6315: Draft: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 19 Aug '24

19 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v4: user32: Use the new plugplay definitions to registration device notifications, add support for DBT_DEVTYP_HANDLE events. sechost: Implement (un)registration of PnP events using the newly added types. ntoskrnl: Use the new plugplay definitions to send PnP events. plugplay: Use the newly added DEVICE_BROADCAST type to send and receive PnP events. include/wine: Add new header dbt.h from internal definitions used to implement PnP events. include/wine/plugplay: Separate device broadcast event types into their own structs. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

4 12

[PATCH v7 0/4] MR6260: mshtml: Misc improvements and fixes.
by Gabriel Ivăncescu (＠insn) 19 Aug '24

19 Aug '24

-- v7: mshtml/tests: Accept rare return value from ReportResult on native. mshtml: Implement EmulateIE* modes for X-UA-Compatible. mshtml: Don't return default ports from location.host in IE10+ modes. mshtml: Avoid calling remove_target_tasks needlessly. https://gitlab.winehq.org/wine/wine/-/merge_requests/6260

3 7

[PATCH v3 0/6] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 19 Aug '24

19 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- v3: user32: Use the new plugplay definitions to registration device notifications, add support for DBT_DEVTYP_HANDLE events. https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

3 7

[PATCH 0/1] MR6312: win32u: Initialize parent_rect variables in window.c.
by Aida Jonikienė (＠DodoGTA) 19 Aug '24

19 Aug '24

This fixes -Wmaybe-uninitialized warnings with GCC 14. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6312

3 2

[PATCH 0/6] MR6315: plugplay: Rework how PnP notifications are sent over RPC to support DBT_DEVTYP_HANDLE events.
by Vibhav Pant (＠vibhavp) 19 Aug '24

19 Aug '24

PnP device notifications/events are currently sent and received from the `plugplay` service as the raw-bytes for the `DBT_DEVTYP_DEVICEINTERFACE` struct that needs to be sent from the PnP code in `ntoskrnl.exe`. While simple, it does not support sending `DBT_DEVTYP_HANDLE` events, as they also include a `HANDLE` to the device the event comes from, which cannot simply be sent as raw bytes. This MR reworks how notifications are sent and received from the `plugplay` service, by: 1. Introducing new structs `DEVICE_BROADCAST_HANDLE` and `DEVICE_BROADCAST_DEVICEINTERFACE` in `plugplay.idl`. The structs are similar to their counterparts in `dbt.h` without the `devicetype` and `size` fields added for the header. 2. Re-write `plugplay_{send,get}_event` to use the newly added union `DEVICE_BROADCAST`, which uses the `devicetype` value as the discriminant. A deep copy of this union is then appended to the event queue of every registered listener. 3. Re-write `I_ScRegisterDeviceNotification` and `device_notify_proc` in `sechost/service.c` to use the newly added types instead. Additionally, add support for registering for `DBT_DEVTYPE_HANDLE` notifications, for which the `OBJECT_NAME_INFORMATION` value for the device `HANDLE` is used to filter notifications in order to correctly dispatch them to their registered callbacks. 4. Re-write the callbacks in `user32/input.c` to accept the `DEVICE_BROADCAST` union instead, and construct the appropriate `DEV_BROADCAST_*` struct from it, which gets sent to `SendMessageTimeoutW` as usual. Support for `DBT_DEVTYP_HANDLE` is needed for the Bluetooth driver stack I have been working on recently, which uses `DBT_DEVTYP_HANDLE` events to notify userspace about newly found Bluetooth devices during discovery and incoming authentication requests, as documented by MS [here](https://learn.microsoft.com/en-us/windows/win32/bluetooth/bluetooth-a…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6315

3 8

[PATCH v2 0/1] MR6305: odbccp32: SQLWritePrivateProfileStringW correctly hanndle ODBC_BOTH_DSN
by Alistair Leslie-Hughes (＠alesliehughes) 19 Aug '24

19 Aug '24

-- v2: odbccp32: SQLWritePrivateProfileStringW correctly hanndle ODBC_BOTH_DSN https://gitlab.winehq.org/wine/wine/-/merge_requests/6305

4 3

[PATCH 0/2] MR6313: kernel32: EnumCalendarInfo() should ignore CAL_RETURN_NUMBER flag.
by Dmitry Timoshkov (＠dmitry) 19 Aug '24

19 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6313

2 2

2025

2024

2023

2022

wine-gitlab August 2024