On Mon Aug 19 09:19:13 2024 +0000, Zhiyi Zhang wrote:
> There should be a test failing on Wine in this patch. Then you add a
> todo_wine to make the test pass in this commit. Then in the next patch
> after you've fixed the bug, the todo_wine should get removed.
Done.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79103
I'm not sure this is 100% safe (maybe limiting those blits to sysmem textures
would be better like stated in the original change?)
--
v3: HACK: wined3d: Don't assert in CS thread check.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6300
Commit 1 prevents the media session from starting execution of an asynchronous operation while another asynchronous operation is still running. Without this, it was possible for invalid state transitions to happen, which could leave the session in an intermediary state (not stopped, started, paused, closed or shut down) indefinitely.
Commits 2, 3 and 4 are some more fixes around pausing and unpausing in mfplat.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/6255
Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c:
> + DWORD r;
> + UINT uFlagsAbove = MAKELPARAM(LVNI_ABOVE, 0);
> + UINT uFlagsBelow = MAKELPARAM(LVNI_BELOW, 0);
> +
> + hwnd = create_listview_control(LVS_REPORT);
> + insert_item(hwnd, 0);
> + insert_item(hwnd, 1);
> +
> + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsAbove);
> + expect(-1, r);
> + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 0, uFlagsBelow);
> + expect(1, r);
> + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsAbove);
> + expect(0, r);
> + r = SendMessageA(hwnd, LVM_GETNEXTITEM, 1, uFlagsBelow);
> + expect(-1, r);
There should be a test failing on Wine in this patch. Then you add a todo_wine to make the test pass in this commit. Then in the next patch after you've fixed the bug, the todo_wine should get removed.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/5909#note_79085
When the listview expands or collapses an item it notifies the parent using the TVN_ITEMEXPANDING message. The parent can return true on this message and it prevents the treeview from expanding or collapsing the item. WINE does not let you deny TVN_ITEMEXPANDING by returning true.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53727
--
v13: comctl32/treeview: Allow treeview parent to deny treeview expansion.
comctl32/tests: Add test to check if treeview expansion can be denied.
https://gitlab.winehq.org/wine/wine/-/merge_requests/6218