August 2024 - wine-gitlab

[PATCH v2 0/12] MR6207: include: Introduce new COM implementation helper macros.
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once, with IInspectable support when needed. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- v2: windows.gaming.input: Use the new COM macros everywhere possible. include: Introduce new macros for COM heritage implementation. widl: Generate some INTERFACE_IMPL/FWD helper macros. include: Introduce new macros for IInspectable WinRT implementation. include: Introduce new macros for COM IUnknown implementation. include: Introduce new macros for COM QueryInterface implementation. widl: Generate some QUERY_INTERFACE helper macros. include: Introduce new macros for COM AddRef/Release implementation. include: Introduce new helper macros for COM implementation. windows.gaming.input: Use the new INTERFACE_VTBL macros. widl: Generate some INTERFACE_VTBL helper macros. windows.gaming.input: Use a separate interface for IAgileObject. https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

2 13

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective.
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

Thanks, I'm closing this as it seems to be fixed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150#note_77975

1 0

Re: [PATCH v13 0/1] MR6150: win32u: fix a regression bug that virtual desktop not effective. - closed
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6150

1 0

Re: [PATCH v3 0/4] MR6074: Draft: Add support for HID multi toplevel-collections
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

The alternate MR got merged, although it also broke the dinput tests at the same time. This is an issue that was present in this MR too, related to reading reports from multi-TLC devices, although that wasn't tested here, and should be fixed with https://gitlab.winehq.org/wine/wine/-/merge_requests/6214 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6074#note_77973

1 0

Re: [PATCH v3 0/4] MR6074: Draft: Add support for HID multi toplevel-collections - closed
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

This merge request was closed by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6074

1 0

[PATCH 0/7] MR6220: mfplat: Implement MFCreateMediaBufferFromMediaType for video formats and test video processor with 2D buffers.
by Rémi Bernon (＠rbernon) 07 Aug '24

07 Aug '24

Superseding https://gitlab.winehq.org/wine/wine/-/merge_requests/6188 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6220

4 10

[PATCH 0/1] MR6203: advapi32: Avoid that invalid pointers cause crashes.
by Haoyang Chen (＠chenhaoyang) 07 Aug '24

07 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6203

4 5

[PATCH v4 0/1] MR6175: ntdll: Raise exception on failed CS wait.
by Paul Gofman (＠gofman) 06 Aug '24

06 Aug '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57011 -- v4: ntdll: Raise exception on failed CS wait. https://gitlab.winehq.org/wine/wine/-/merge_requests/6175

3 3

[PATCH v2 0/3] MR6210: kernel32: Implement Implement QueryIdleProcessorCycleTime[Ex]().
by Paul Gofman (＠gofman) 06 Aug '24

06 Aug '24

-- v2: ntdll: Implement NtQuerySystemInformationEx( SystemProcessorIdleCycleTimeInformation ) on Linux. kernel32: Implement QueryIdleProcessorCycleTime[Ex](). ntdll: Stub NtQuerySystemInformation[Ex]( SystemProcessorIdleCycleTimeInformation ). https://gitlab.winehq.org/wine/wine/-/merge_requests/6210

4 6

Re: [PATCH v3 0/7] MR6212: mshtml: Use proper JS functions for constructors. - approved
by Alexandre Julliard (＠julliard) 06 Aug '24

06 Aug '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6212

1 0

2025

2024

2023

2022

wine-gitlab August 2024