February 2025 - wine-gitlab

[PATCH v14 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 27 Feb '25

27 Feb '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v14: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 4

[PATCH 0/3] MR7368: winex11: Use XFixes to hide cursor before warping it.
by Rémi Bernon (＠rbernon) 27 Feb '25

27 Feb '25

XWayland only allows warping the cursor if it is not visible. Fixes a regression from the periodic cursor sync removal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7368

4 8

[PATCH 0/1] MR7411: wined3d: Avoid double-free of swapchain surface on error.
by Rémi Bernon (＠rbernon) 27 Feb '25

27 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7411

4 4

[PATCH v2 0/9] MR7378: wined3d: NV12 textures, part 2/2.
by Elizabeth Figura (＠zfigura) 27 Feb '25

27 Feb '25

-- v2: d3d11/tests: Extend NV12 tests. wined3d: Implement planar NV12 in the Vulkan renderer. wined3d: Enable KHR_sampler_ycbcr_conversion. wined3d: Implement planar Vulkan blits. wined3d: Implement planar Vulkan downloads. wined3d: Implement planar Vulkan uploads. wined3d: Separate a wined3d_texture_vk_download_plane() helper. wined3d: Separate a wined3d_texture_vk_upload_plane() helper. wined3d: Use a separate format value for d3d10+ NV12. https://gitlab.winehq.org/wine/wine/-/merge_requests/7378

3 11

[PATCH v8 0/2] MR7392: server: Don't ceil poll timeouts to the next millisecond if higher resolution timeouts are supported.
by William Horvath (＠whrvt) 27 Feb '25

27 Feb '25

This mitigates a side effect of the global current_time and monotonic_time being updated on every server call's timeout, where the end time of any unrelated server call is moved into the future (depending on the frequency of server calls). By using a more granular timeout, the overall frequency of server calls doesn't have as great of an effect on each individual timeout, as we don't have to wait for an entire millisecond (which was due to the ceiling operation in get_next_timeout). This [issue](https://bugs.winehq.org/show_bug.cgi?id=57849) gives a few examples of this causing significant degradation in the behavior of some games, which use alertable (server) waits for their FPS limiter. -- v8: server: Use epoll_pwait2 for the main loop on Linux. server: Use a high precision timespec directly for poll timeouts on supported platforms. https://gitlab.winehq.org/wine/wine/-/merge_requests/7392

3 6

[PATCH 0/1] MR7434: winex11.drv: Allow MWM_FUNC_MAXIMIZE when WS_MAXIMIZE is present.
by Zhiyi Zhang (＠zhiyi) 27 Feb '25

27 Feb '25

Mutter refuses to maximize a window when MWM_FUNC_MAXIMIZE is not present. However, ShowWindow(SW_MAXIMIZE) on Windows can maximize the window, even without WS_MAXIMIZEBOX. This is similar to 688fe706. Fix Tidy Cauldron (2708320), a Unity game, unable to maximize in some cases. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7434

3 3

[PATCH v3 0/1] MR6780: include: Avoid the for-loop be optimized out
by Ruslan Garipov (＠ruslangaripov) 27 Feb '25

27 Feb '25

This stops GCC from optimizing out a `for` loop inside the `dump_cv_sst_src_module()` function, when tools/winedump is compiled with optimization settings -O1 or higher. Because the `baseSrcLn` field of the `struct OMFSourceFile` was declared as an array of one element **and it is an interior member** of the structure: ```c typedef struct OMFSourceFile { unsigned short cSeg; unsigned short reserved; unsigned int baseSrcLn[1]; unsigned short cFName; char Name; } OMFSourceFile; ``` The compiler/optimizer assumes that the `baseSrcLn` array may have only zero or one element. And generates the corresponding code. The following shows code that GCC 14.2.1 generates before and after this patch. Before patch: ``` 524f: e8 0c ef ff ff call 4160 <printf@plt> # this printf(3)'s "File table: ..." # r15 stores sourceFile->cSeg; assigned above. 5254: 66 41 83 3c 24 00 cmpw $0x0,(%r12) # r12 is sourceFile 525a: 74 22 je 527e <dump_codeview+0x70e> 525c: 4b 8d 44 bc 04 lea 0x4(%r12,%r15,4),%rax #rax is seg_info_dw 5261: 45 8b 44 24 04 mov 0x4(%r12),%r8d # sourceFile->baseSrcLn[0] 5266: be 01 00 00 00 mov $0x1,%esi 526b: 48 8d 3d fe 02 04 00 lea 0x402fe(%rip),%rdi # 45570 5272: 8b 48 04 mov 0x4(%rax),%ecx 5275: 8b 10 mov (%rax),%edx 5277: 31 c0 xor %eax,%eax 5279: e8 e2 ee ff ff call 4160 <printf@plt> 527e: 41 0f b6 06 movzbl (%r14),%eax # eax = sourceModule + ofs ``` The code checks if the `sourceFile->cSeg` is zero or not, and if not it `printf(3)`s information about the first element in the `baseSrcLn` and first offset pair. There is no `for` loop there, only its first iteration. After patch: ``` 525c: e8 ff ee ff ff call 4160 <printf@plt> # this printf(3)'s "File table: ..." # r12 is seg_info_dw and r15 stores integer 1; both assigned above. # r15 is `i' -- the loop counter. 5261: 66 41 83 3e 00 cmpw $0x0,(%r14) # r14 is sourceFile 5266: 74 37 je 529f <dump_codeview+0x72f> 5268: 0f 1f 84 00 00 00 00 nopl 0x0(%rax,%rax,1) 526f: 00 5270: 43 8b 54 fc f8 mov -0x8(%r12,%r15,8),%edx 5275: 43 8b 4c fc fc mov -0x4(%r12,%r15,8),%ecx 527a: 44 89 fe mov %r15d,%esi 527d: 31 c0 xor %eax,%eax 527f: 47 8b 04 be mov (%r14,%r15,4),%r8d # sourceFile->baseSrcLn[i] 5283: 48 8d 3d e6 02 04 00 lea 0x402e6(%rip),%rdi # 45570 528a: 49 83 c7 01 add $0x1,%r15 528e: e8 cd ee ff ff call 4160 <printf@plt> 5293: 41 0f b7 06 movzwl (%r14),%eax 5297: 41 8d 57 ff lea -0x1(%r15),%edx 529b: 39 c2 cmp %eax,%edx 529d: 7c d1 jl 5270 <dump_codeview+0x700> 529f: 48 8b 44 24 18 mov 0x18(%rsp),%rax # rax = sourceModule + ofs ``` The `for` loop now is where it should be. [EDITED] 2025-02-12: Fix merge request title. -- v3: include: Avoid the for-loop be optimized out. https://gitlab.winehq.org/wine/wine/-/merge_requests/6780

2 3

[PATCH 0/5] MR7432: mp3dmod: Add future support for Float encoding and fix various discrepancies with Windows
by Brendan McGrath (＠redmcg) 27 Feb '25

27 Feb '25

This MR adds the ability to support float encoding (which will be used by the IMFTransform interface). It also adds tests and addresses a number of small discrepancies discovered between the Wine and native implementation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7432

2 5

[PATCH v2 0/1] MR7428: wined3d: Use temporary buffer when stretching a surface to itself with cpu blit
by YuriK7 (＠riyu12383) 27 Feb '25

27 Feb '25

Fixes https://bugs.winehq.org/show_bug.cgi?id=57283. I believe some sort of smart two pass stretching is possible instead, but not worth it. [dlls/wined3d/surface.c#L1570](https://gitlab.winehq.org/riyu12383/wine/-/bl… not exactly sure if it's related and should be removed then ? -- v2: wined3d: Use temporary buffer when stretching a surface to itself with cpu blit https://gitlab.winehq.org/wine/wine/-/merge_requests/7428

2 2

[PATCH 0/1] MR7431: po: Update Dutch translation.
by Floris Renaud (＠jkfloris) 26 Feb '25

26 Feb '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7431

2 1

2025

2024

2023

2022

wine-gitlab February 2025