March 2025 - wine-gitlab

[PATCH v4 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 07 May '25

07 May '25

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- v4: ntdll: Load known dlls from system directory. loader/wine.inf: Add known dlls key. ntdll: Factor out prepend_system_dir() function. kernel32/tests: Add tests for known dlls load specifics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

4 8

[PATCH 0/1] MR7586: cmd: Handle cntl-c events correctly
by Jeff Latimer (＠greyghoster) 01 May '25

01 May '25

https://bugs.winehq.org/show_bug.cgi?id=27605 describes how cntl-c is not handled well in cmd.exe, this patch allows the cntl-c to be returned in the buffer so that it can processed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7586

3 9

[PATCH 0/1] MR4635: ntdll: Avoid abort process when internal string printing function used for debugging.
by 江仪陈 (＠meshine) 30 Apr '25

30 Apr '25

Description: The printing function (non-Windows application call) used by Wine developers is unnecessary to abort process when the string is super long. For example, the developer prints a long commandline of wwmapp.exe by MESSAGE. As a result, the process cannot be started, and the conference function cannot be used. Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com> Change-Id: If06f0309f9745777f89b07dff8d302cb34b2a90e -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4635

3 2

[PATCH 0/1] MR7664: ntdll: Add copies of two XDG env vars to the environment, and use those in...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

ntdll: Add copies of two XDG env vars to the environment, and use those in winemenubuilder and shell32. To solve https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 we have to remove these two XDG variables from the environment. This is a proposal that adds copies with a different name and after this they can be removed. If this is not the right way to go I guess I will hear something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7664

2 3

[PATCH v2 0/1] MR7652: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. -- v2: ntdll: Treat XDG_DATA_DIRS as special env variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7652

3 6

[PATCH 0/2] MR5285: AMD Radeon Vega 7 Renoir pci-ids
by Carlos Rodriguez (＠mrdeathjr28) 24 Apr '25

24 Apr '25

With this patch wine can recognize amd radeon vega 7 renoir (actually appears like radeon RX 5600) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5285

4 5

[PATCH v2 0/1] MR7669: Draft: ntdll/server: Make robust to spurious short writes
by Bernhard Übelacker (＠bernhardu) 24 Apr '25

24 Apr '25

Version 1 of the patch by Keno Fischer. -- v2: ntdll/server: Make robust to spurious short writes https://gitlab.winehq.org/wine/wine/-/merge_requests/7669

3 5

[PATCH v13 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu (＠insn) 21 Apr '25

21 Apr '25

-- v13: server: Handle hardlinks and casefolding when renaming the same file. server: Handle renames to destinations containing trailing slashes. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

4 11

[PATCH v3 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 19 Apr '25

19 Apr '25

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v3: msi: Properly select first feature. https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

2 4

[PATCH v8 0/3] MR7064: ntdll: Check for invalid GS base in the 64-bit segv_handler.
by William Horvath (＠whrvth) 19 Apr '25

19 Apr '25

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated, such as in 32-bit code on "new-style" WoW64. "Exertus: Darkness Approaches" is a 32-bit game that triggers this crash (on WoW64), which can be downloaded from the Bugzilla page's attachments. For another example, [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) can reproduce it, courtesy of Fabian Maurer from the Bugzilla comments. This will crash whether it's compiled as 32-bit or 64-bit, while it works fine on Windows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 Also, excuse me if submitting this is against some sort of code-freeze etiquette, it wasn't my intention try to have it merged immediately. -- v8: ntdll/tests: Re-enable a previously crashing test. ntdll: Check for invalid gs_base in the 64-bit segv_handler. ntdll/tests: Add an exception test for accessing a modified %gs on x86_64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

6 16

2025

2024

2023

2022

wine-gitlab March 2025