April 2025 - wine-gitlab

[PATCH 0/1] MR7916: kernel32: Fixed MulDiv's inconsistencies with Windows.
by Shavit Yosef (＠shavitush) 27 Apr '25

27 Apr '25

`MulDiv` doesn't match the correct Windows behavior for the function, which actually differs in some edge cases for 32-bit and 64-bit. Test case: ```c MulDiv(1, 0x80000000, 0x80000000); // WINE - both 32-bit and 64-bit: 0 // Windows (32-bit/kernel32.dll): 2 // Windows (64-bit/kernelbase.dll): -1 ``` On Windows 32-bit, this would return 2. On 64-bit, it'd return -1. However, on WINE, this call would return 0 for both 32-bit and 64-bit. This discrepancy was previously abused by threat actors to detect if the application runs under WINE. --- On Windows, `MulDiv` has a different implementation for 32-bit (from `kernel32.dll`) and 64-bit (leveraged to `kernelbase.dll` from `kernel32.dll`). After adjusting the 64-bit code to be an exact replica of the original code from `kernelbase.dll`, it'd still return the incorrect value due to Microsoft's code having undefined behavior with negation. It could be avoided with `-O0` but I opted into rewriting it with the undefined behavior to be, well.. defined. To clarify, the original code from Microsoft has a bug (logically, at least). But WINE is supposed to have matching behavior so we can run Windows programs as intended. The 32-bit version of `MulDiv` in Windows has a more complicated bug; I've documented it in the code. --- This is my first contribution to WINE - I cannot find any `CONTRIBUTING.md` or similar file with guidelines so I did my best to follow the convention of other merge requests. I've added unit testing for `MulDiv` to ensure there won't be a regression in the future. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7916

4 8

[PATCH v17 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v17: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 3

[PATCH v2 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comdlg32/colordlg: Fix color picker cursor painting. https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH v16 0/3] MR7542: ws2_32: Implement WSALookupService for Bluetooth device discovery.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

This MR adds an initial implementation of the winsock `WSALookupsService*` methods for performing Bluetooth device discovery (`LUP_CONTAINERS`). -- v16: ws2_32: Implement WSALookupServiceNext for Bluetooth device discovery. ws2_32: Implement WSALookupServiceBegin for Bluetooth device discovery. ws2_32/tests: Add tests for the Bluetooth namespace (NS_BTH) in WSALookupServiceBegin/Next. https://gitlab.winehq.org/wine/wine/-/merge_requests/7542

2 4

[PATCH 0/1] MR7921: comdlg32/colordlg: Fix color picker cursor painting.
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56107 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7921

2 1

[PATCH 0/1] MR7913: uiautomationcore: Fix BSTR buffer overrun (ASan).
by Nikolay Sivov (＠nsivov) 27 Apr '25

27 Apr '25

Length argument to SysAllocStringLen() should not exceed the length of the string argument. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7913

3 2

[PATCH v5 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v5: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. bluetoothapis: Use a wizard GUI to respond to pairing requests if an authentication callback is not registered. bluetoothapis: Implement BluetoothAuthenticateDeviceEx. winebth.sys: Implement IOCTL_WINEBTH_RADIO_START_AUTH. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 4

[PATCH v4 0/4] MR7885: winebth.sys part 11: Support initiating pairing requests with remote devices.
by Vibhav Pant (＠vibhavp) 27 Apr '25

27 Apr '25

Add `IOCTL_WINEBTH_RADIO_START_AUTH`, which gets used to implement `BluetoothAuthenticateDeviceEx`. -- v4: bluetoothapis/tests: Add tests for BluetoothAuthenticateDeviceEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/7885

2 5

[PATCH 0/1] MR7664: ntdll: Add copies of two XDG env vars to the environment, and use those in...
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

ntdll: Add copies of two XDG env vars to the environment, and use those in winemenubuilder and shell32. To solve https://bugs.winehq.org/show_bug.cgi?id=49987 and https://bugs.winehq.org/show_bug.cgi?id=58023 we have to remove these two XDG variables from the environment. This is a proposal that adds copies with a different name and after this they can be removed. If this is not the right way to go I guess I will hear something? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7664

2 3

[PATCH v2 0/1] MR7652: ntdll: Treat XDG_DATA_DIRS as special env variable.
by Louis Lenders (＠xe) 27 Apr '25

27 Apr '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49987 GTK apps seem to use this to find path to schemas, like Meld: https://download.gnome.org/binaries/win32/meld/3.22/Meld-3.22.2-mingw.msi which doesn't start at all without this patch. More info in https://bugs.winehq.org/show_bug.cgi?id=49987. -- v2: ntdll: Treat XDG_DATA_DIRS as special env variable. https://gitlab.winehq.org/wine/wine/-/merge_requests/7652

3 6

2025

2024

2023

2022

wine-gitlab April 2025