April 2025 - wine-gitlab

[PATCH v2 0/3] MR7793: sane.ds: Some clean ups.
by Dmitry Timoshkov (＠dmitry) 13 Apr '25

13 Apr '25

Using enum { buf_len, buf_count } also looks strange, leave it for now. -- v2: sane.ds: Use sizeof() instead of hard-coded values, avoid zero initializing local variables when not necessary. sane.ds: Clarify how SANE mode names map to ICAP_PIXELTYPE values. sane.ds: Change return type of sane_categorize_value() to void. https://gitlab.winehq.org/wine/wine/-/merge_requests/7793

3 4

[PATCH 0/1] MR7801: combase: Add a stub for SetRestrictedErrorInfo().
by Nikolay Sivov (＠nsivov) 12 Apr '25

12 Apr '25

Foobar 2000 crashes without it. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7801

2 1

[PATCH 0/1] MR7800: dwrite: Implement GetFontSet() for collections.
by Nikolay Sivov (＠nsivov) 12 Apr '25

12 Apr '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7800

2 1

[PATCH 0/1] MR7799: winemaker: Account for FreeBSD
by Gerald Pfeifer (＠gerald) 12 Apr '25

12 Apr '25

For some functionality Perl's LibXML is required; add a note for FreeBSD to the Linux variants covered. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7799

3 2

[PATCH 0/1] MR7798: spoolss: Avoid buffer-overflow when setting numentries. (ASan)
by Bernhard Übelacker (＠bernhardu) 12 Apr '25

12 Apr '25

BuildOtherNamesFromMachineName writes sizeof(LPVOID) bytes but the test reserved just sizeof(DWORD), which makes a difference at amd64 and gets detected by ASan. <details> <summary>ASan output</summary> ``` ================================================================= ==spoolss_test.exe==700==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffffe1ffba0 at pc 0x6ffffdc53e38 bp 0x7ffffe1ffa40 sp 0x7ffffe1ffa88 WRITE of size 8 at 0x7ffffe1ffba0 thread T0 #0 0x6ffffdc53e37 in BuildOtherNamesFromMachineName .../wine/dlls/spoolss/spoolss_main.c:99:11 #1 0x00014000170e in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:131:11 #2 0x000140001030 in func_spoolss .../wine/dlls/spoolss/tests/spoolss.c:218:5 #3 0x000140003ede in run_test .../wine/include/wine/test.h:765:5 #4 0x000140003a8e in main .../wine/include/wine/test.h #5 0x000140004963 in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:58:11 #6 0x6fffffc3565e in BaseThreadInitThunk .../wine/dlls/kernel32/thread.c:61:24 #7 0x6fffffdbbcc2 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x17004bcc2) Address 0x7ffffe1ffba0 is located in stack of thread T0 at offset 64 in frame #0 0x00014000164f in test_BuildOtherNamesFromMachineName .../wine/dlls/spoolss/tests/spoolss.c:122 This frame has 2 object(s): [32, 40) 'buffers' (line 123) [64, 68) 'numentries' (line 124) <== Memory access at offset 64 partially overflows this variable HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork (longjmp, SEH and C++ exceptions *are* supported) SUMMARY: AddressSanitizer: stack-buffer-overflow .../wine/dlls/spoolss/spoolss_main.c:99:11 in BuildOtherNamesFromMachineName Shadow bytes around the buggy address: 0x7ffffe1ff900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ff980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffa80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffb00: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1 =>0x7ffffe1ffb80: 00 f2 f2 f2[04]f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffc00: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x7ffffe1ffc80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 f8 f8 f8 f8 0x7ffffe1ffd00: f8 f8 f8 f8 f3 f3 f3 f3 00 00 00 00 00 00 00 00 0x7ffffe1ffd80: 00 00 00 00 00 00 00 00 f1 f1 f1 f1 00 00 00 00 0x7ffffe1ffe00: 00 00 00 00 00 00 00 00 00 00 00 00 f2 f2 f2 f2 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==spoolss_test.exe==700==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7798

2 1

Re: [PATCH v3 0/3] MR7787: winebth.sys: Broadcast PnP events when remote devices are found or lost/removed. - approved
by Alexandre Julliard (＠julliard) 11 Apr '25

11 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7787

1 0

Re: [PATCH v2 0/3] MR7792: ntdll: Fix some memory leaks (Valgrind). - approved
by Alexandre Julliard (＠julliard) 11 Apr '25

11 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7792

1 0

Re: [PATCH v2 0/1] MR7791: win32u: Fix a string leak (Valgrind). - approved
by Alexandre Julliard (＠julliard) 11 Apr '25

11 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7791

1 0

Re: [PATCH v2 0/1] MR7794: odbc32: Call the driver's SQLGetInfoW after a->w conversion. - approved
by Alexandre Julliard (＠julliard) 11 Apr '25

11 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7794

1 0

Re: [PATCH v2 0/1] MR7790: ntdll: Do not mark first stack guard page as committed. - approved
by Alexandre Julliard (＠julliard) 11 Apr '25

11 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7790

1 0

2025

2024

2023

2022

wine-gitlab April 2025