April 2025 - wine-gitlab

[PATCH v2 0/1] MR7676: winegstreamer: Make sure WMSyncReader never reads in the background.
by Yuxuan Shui (＠yshui) 09 Apr '25

09 Apr '25

WMSyncReader starts a background read thread that reads from the IStream passed to IWMSyncReader::OpenStream. This means it could use the IStream in the background even when no IWMSyncReader methods are being called. For well-behaved applications, this is probably OK. However, AQUARIUM (Steam 2515070) frees the IStream it passes to WMSyncReader _before_ it calls IWMSyncReader::Close, which stops the read thread. This causes the read thread to access freed memory. This is improper, but not unreasonable, as IWMSyncReader is supposed to be a synchronous interface, so one might assume when they weren't calling into IWMSyncReader methods, the IStream won't be used. This commit adds a `wg_parser_dont_read` function, which can be used to stop wg_parser from issuing read requests. This is used by IWMSyncReader to make sure read requests are only issued when IWMSyncReader methods are being called. -- v2: winegstreamer: Make sure WMSyncReader never reads in the background. https://gitlab.winehq.org/wine/wine/-/merge_requests/7676

3 4

Re: [PATCH v14 0/6] MR7650: Add support for AF_UNIX sockets (followup)
by Elizabeth Figura (＠zfigura) 09 Apr '25

09 Apr '25

On Wed Apr 9 09:09:54 2025 +0000, Ralf Habacker wrote: > The following change was added at > https://gitlab.winehq.org/wine/wine/-/merge_requests/7650/diffs?commit_id=4… > to fix this issue: > ``` > /* st was set from the file name if the file could not be opened */ > if (fd->unix_fd != -1) > fstat( fd->unix_fd, &st ); > ``` > Anything else to fix ? I suspect that's not going to be good enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7650#note_100511

1 0

Re: [PATCH v3 0/2] MR7403: user32: Call UpdateWindow() after showing a dialog.
by Elizabeth Figura (＠zfigura) 09 Apr '25

09 Apr '25

Ah no worries then, thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7403#note_100509

1 0

Re: [PATCH v15 0/1] MR7752: activeds: Implement ADsBuildVarArrayInt. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7752

1 0

Re: [PATCH v5 0/2] MR7157: winex11: Avoid setting RDW_ERASE on expose events. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7157

1 0

Re: [PATCH v3 0/2] MR7403: user32: Call UpdateWindow() after showing a dialog. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7403

1 0

Re: [PATCH v3 0/2] MR7763: winex11: Avoid sending WM_MOUSEACTIVATE on WM_TAKE_FOCUS. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7763

1 0

Re: [PATCH v5 0/4] MR7777: conhost: Improve first font selection on systems with limited fonts. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7777

1 0

Re: [PATCH v4 0/1] MR7767: win32u: Add support WM_IME_KEYDOWN message translate - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7767

1 0

Re: [PATCH v4 0/1] MR7766: win32u: Preserve result string from multiple WINE_IME_POST_UPDATE call during ImeProcessKey. - approved
by Alexandre Julliard (＠julliard) 09 Apr '25

09 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7766

1 0

2025

2024

2023

2022

wine-gitlab April 2025