April 2025 - wine-gitlab

Re: [PATCH v2 0/1] MR7750: msvcirt/tests: Fix buffer overrun with a terminating null (ASan). - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7750

1 0

Re: [PATCH v2 0/3] MR7749: oleaut32: Handle more pixel formats in OleLoadPicture. - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7749

1 0

Re: [PATCH v2 0/1] MR7743: winevulkan: Update to VK spec version 1.4.312. - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7743

1 0

Re: [PATCH v4 0/2] MR7318: gdiplus: Use correct format guid for .ico files. - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7318

1 0

Re: [PATCH v2 0/1] MR7740: sane.ds: Fix DC leak. - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7740

1 0

Re: [PATCH v3 0/1] MR7753: configure.ac: avoid problems with -Werror=return-type in check - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7753

1 0

Re: [PATCH v3 0/6] MR7741: windowscodecs/tests: Add some tests for initial metadata readers content. - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7741

1 0

Re: [PATCH v2 0/1] MR7754: ntdll: Fix build on platforms without getauxval - approved
by Alexandre Julliard (＠julliard) 07 Apr '25

07 Apr '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7754

1 0

[PATCH v20 0/9] MR3799: kernelbase: Add implementation of PerfSetULongCounterValue and PerfSetULongLongCounterValue
by Lorenzo Ferrillo (＠llde) 07 Apr '25

07 Apr '25

These functions are used by Visual Studio 2019, when opening or converting some projects. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- v20: kernelbase:return pointer for counter instead of index. remove auxilliary function to set the value https://gitlab.winehq.org/wine/wine/-/merge_requests/3799

2 10

[PATCH v3 0/1] MR7701: winemac.drv: Only send key down events to the window's inputContext.
by Tim Clem (＠tclem) 07 Apr '25

07 Apr '25

Sending key events through `-[NSTextInputContext handleEvent:]`, as we do in `macdrv_send_text_input_event`, results in doubled characters for certain macOS input sources. The Romaji source does this reliably, as do certain third-party sources. (The built-in dictation does it as well, but we already blacklist that - !5660 - because it remains "active" even when it's not.) I can't find this spelled out directly, but if you read between the lines, it seems clear that you're only supposed to send key *down* events to `-[NSTextInputContext handleEvent:]` and not key ups. Supporting evidence: 1. [The old documentation on the text system](https://developer.apple.com/library/archive/documentation/TextFonts… only mentions `handleEvent:` being called in the context of `-keyDown:`. 2. [The guide to implementing a custom text view/NSTextInputClient](https://developer.apple.com/library/archive/documen… only mentions overriding `-keyDown:` and sending those events to `-handleEvent:`. 3. [iTerm only sends key down events to `-handleEvent:`](https://github.com/gnachman/iTerm2/blob/6134ea0a9d9d0fee5e7d7704fc98efec1fc77c24/sources/iTermKeyboardHandler.m#L355). You have to unpack the logic a bit from there, but `-handleKeyDownEvent:...` is the only method that calls `-handleEventWithCocoa:inputContext:`, which is what (usually) calls `-handleEvent:` on the `inputContext`. 4. [The InputMethodKit method on the IMKServerInput protocol to handle NSEvents directly](https://developer.apple.com/documentation/objectivec/nsobject/138… only mentions getting key down events. So presumably input source authors sometimes do not check the type of the NSEvent they're receiving and process all key events equally, be they downs or ups, which results in the doubled input. This patch fixes the issues with Romaji and the problematic third-party method we've encountered. -- v3: winemac.drv: Only send key down events to the window's inputContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/7701

4 5

2025

2024

2023

2022

wine-gitlab April 2025