May 2025 - wine-gitlab

[PATCH v5 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v5: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

2 3

[PATCH v4 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v4: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). taskschd/tests: Adds a test for IRegisteredTaskCollection get_Item and get_Count. https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 4

[PATCH 0/1] MR8163: dmime: Fix use-after-free after performance_CloseDown.
by Yuxuan Shui (＠yshui) 28 May '25

28 May '25

IDirectMusicPerformance8 holds references to music ports in channel_blocks. These ports must outlive their parent IDirectMusic, because in synth_port_Release, they remove themselves from their parent. performance_CloseDown releases the IDirectMusic, but doesn't release its ports. So when these ports are later released in performance_Release, they uses the already freed IDirectMusic. Found by ASan. stacktrace ([post-processed](https://gitlab.winehq.org/yshui/wine-symbolizer)): ``` 016c:0170:err:asan:asan_report ASan: read of 4 bytes at 00007E1C0BFF8518, caller 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report stacktrace: 016c:0170:err:asan:asan_report 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report 00006FFFFDE144BC (dmusic_remove_port, ../dlls/dmusic/dmusic.c:312,10) 016c:0170:err:asan:asan_report 00006FFFFDE21A99 (synth_port_Release, ../dlls/dmusic/port.c:129,9) 016c:0170:err:asan:asan_report 00006FFFFE20B88A (channel_block_free, ../dlls/dmime/performance.c:271,28 <- rb_postorder, ../include/wine/rbtree.h:170,46 <- rb_destroy, ../include/wine/rbtree.h:188,19 <- performance_Release, ../dlls/dmime/performance.c:450,5) 016c:0170:err:asan:asan_report 00007FFFFE002FFA (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:972,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report info: 016c:0170:err:asan:asan_report heap-use-after-free, addr 00007E1C0BFF8518 016c:0170:err:asan:asan_report allocated user region: [00007E1C0BFF84F0, 00007E1C0BFF8530) 64 016c:0170:err:asan:asan_report allocated by 19e3 016c:0170:err:asan:asan_report 00006FFFFDE14885 (music_create, ../dlls/dmusic/dmusic.c:587,20) 016c:0170:err:asan:asan_report 00006FFFFDE18853 (ClassFactory_CreateInstance, ../dlls/dmusic/dmusic_main.c:94,9) 016c:0170:err:asan:asan_report 00006FFFFC925ECF (IClassFactory_CreateInstance, include/unknwn.h:245,12 <- CoCreateInstanceEx, ../dlls/combase/combase.c:1890,10) 016c:0170:err:asan:asan_report 00006FFFFC924F61 (CoCreateInstance, ../dlls/combase/combase.c:1679,10) 016c:0170:err:asan:asan_report 00006FFFFE20BE48 (performance_init_dmusic, ../dlls/dmime/performance.c:480,9 <- performance_Init, ../dlls/dmime/performance.c:535,14) 016c:0170:err:asan:asan_report 00006FFFFE211CB9 (performance_InitAudio, ../dlls/dmime/performance.c:1537,9) 016c:0170:err:asan:asan_report 00007FFFFE001949 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:906,10 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report freed by 3390 016c:0170:err:asan:asan_report 00006FFFFDE15DC4 (IDirectMusic8Impl_Release, ../dlls/dmusic/dmusic.c:203,5) 016c:0170:err:asan:asan_report 00006FFFFE21158C (performance_CloseDown, ../dlls/dmime/performance.c:1469,9) 016c:0170:err:asan:asan_report 00007FFFFE002FB7 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:971,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:trace:module:LdrShutdownProcess () ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8163

3 4

[PATCH 0/1] MR8168: ntdll: Fix out-of-bound read in RtlIpv6AddressToStringExA.
by Yuxuan Shui (＠yshui) 28 May '25

28 May '25

Bound check was performed after the array access, resulting in out-of-bound read of IN6_ADDR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8168

2 1

[PATCH v3 0/3] MR8166: Draft: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v3: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 4

[PATCH v2 0/3] MR8166: Draft: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- v2: taskschd/regtask: Implements IRegisteredTaskCollection get_Count(). taskschd/regtask: Implements IRegisteredTaskCollection get_Item(). taskschd/tests: Adds a test for IRegisteredTaskCollection get_Item and get_Count. https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

2 4

Re: [PATCH v10 0/5] MR7540: kernel32/tests: Add tests for maximum path length limitation.
by Zhiyi Zhang (＠zhiyi) 28 May '25

28 May '25

On Wed May 28 03:08:52 2025 +0000, Yongjie Yao wrote: > ok. The Windows 10 tests are still failing. Could you investigate that? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7540#note_104812

1 0

[PATCH 0/3] MR8166: taskschd: Implements IRegisteredTaskCollection get_Count and get_Item
by Jacob Czekalla (＠JacobCzekalla) 28 May '25

28 May '25

Implements IRegisteredTaskCollection get_Count and get_Item along with a test for both. When making the tests individually they were very similar so I merged them into one test function as per feedback. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8166

3 10

Re: [PATCH 0/1] MR8158: dmime: Parse and ignore MIDI key signature meta events.
by Michael Stefaniuc (＠mstefani) 28 May '25

28 May '25

Test failures are not DMusic related and Mab build is "script failure". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8158#note_104682

1 0

Re: [PATCH v2 0/5] MR8150: mshtml: Implement ownerElement prop for attribute nodes + misc. - approved
by Jacek Caban (＠jacek) 28 May '25

28 May '25

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8150

1 0

2025

2024

2023

2022

wine-gitlab May 2025