- wine-gitlab - winehq.org

[PATCH v7 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 02 Dec '25

02 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v7: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolhelp32Snapshot if possible. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 8

[PATCH v6 0/7] MR9371: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot.
by Yuxuan Shui (＠yshui) 02 Dec '25

02 Dec '25

Intention is to use `CreateToolhelp32Snapshot` in `dbghelp.dll: EnumerateLoadedModulesW64`. Right now we can't because `CreateToolhelp32Snapshot` can't capture 32bit modules in wow64 processes, which is needed to support `SYMOPT_INCLUDE_32BIT_MODULES`. The advantage of using `CreateToolhelp32Snapshot` in mainly performance. Right now `EnumerateLoadedModulesW64` is `O(n^2)`, because of each module it calls `GetModuleInformation` which is itself `O(n)` w.r.t. number of modules. Whereas with `CreateToolhelp32Snapshot` there is no need for `GetModuleInformation`, thus reduce the complexity to just `O(n)`. * * * P.S. I am also uncomfortable with the amount of similar code between `CreateToolhelp32Snapshot` and `EnumProcessModulesEx`. Can something be done here? -- v6: kernel32: Implement TH32CS_SNAPMODULE32 support for CreateToolhelp32Snapshot. kernel32: Use GetCurrentProcess() handle in CreateToolhelp32Snapshot if possible. kernel32/tests: Test CreateToolhelp32Snapshot with TH32CS_SNAPMODULE32. kernel32: Fix CreateToolhelp32Snapshot on old WoW64. include: Add TH32CS_SNAPMODULE32. kernel32/tests: Handle ERROR_BAD_LENGTH from CreateToolhelp32Snapshot. kernel32/tests: Fix CreateToolhelp32Snapshot failure check. https://gitlab.winehq.org/wine/wine/-/merge_requests/9371

2 7

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Davide Beatrici (＠davidebeatrici) 02 Dec '25

02 Dec '25

On Tue Dec 2 05:58:21 2025 +0000, Yeshun Ye wrote: > It's been a long time. I think it was "云视讯ViLin", but I'm not 100% sure. > Also, it's possible that the application has been updated since then, > which might be why the issue can no longer be reproduced. The app is > from "China Mobile", and you can download it from here: https://download.125339.com.cn/ Alright, thank you. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_124368

1 0

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Yeshun Ye (＠yeyeshun) 02 Dec '25

02 Dec '25

On Tue Dec 2 05:57:33 2025 +0000, Davide Beatrici wrote: > @yeyeshun Could you perhaps tell us the name of the affected application > so that we can test it and eventually complete your work? It's been a long time. I think it was "云视讯ViLin", but I'm not 100% sure. Also, it's possible that the application has been updated since then, which might be why the issue can no longer be reproduced. The app is from "China Mobile", and you can download it from here: https://download.125339.com.cn/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_124367

1 0

[PATCH v7 0/2] MR9632: sxs: avoid uninitialised len_name length
by Hans Chen (＠hans.chen) 02 Dec '25

02 Dec '25

The `redirect_data->clrdata_len` [is unset in /dlls/ntdll/actctx.c#L4411-4412](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ntdll/actctx.c?ref_type=heads#L4411-4412) when using registration-free COM in C# NET code. Program.cs ```C# //... Guid guid = Guid.Parse("COM clsid"); Type type = Type.GetTypeFromCLSID(guid, true); var instance = Activator.CreateInstance(type)); //... ``` App.manifest ```xml <assembly> <file name="ExampleCOM.dll"> <comClass description="ExampleCOM" progid="ExampleCOM" clsid="{COM clsid}" threadingModel="Free"/> </file> </assembly> ``` The above C# code gets this error on its second line. ```Shell System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. ``` This is because `len_name` is uninitialized when calling `memcpy(ret_strings, ptr_name, len_name);` in `SxsLookupClrGuid`, which is fixed in this MR. -- v7: change xml format https://gitlab.winehq.org/wine/wine/-/merge_requests/9632

2 2

Re: [PATCH v6 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Davide Beatrici (＠davidebeatrici) 02 Dec '25

02 Dec '25

@yeyeshun Could you perhaps tell us the name of the affected application so that we can test it and eventually complete your work? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2565#note_124365

1 0

Re: [PATCH 0/2] MR9647: dlls/wmp: Implement the OLEIVERB_SHOW needed by the software Alldup；dlls/hhctrl.ocx：no need to set WS_VISSIBLE to Select Topic window - closed
by pan hui (＠panhui) 02 Dec '25

02 Dec '25

This merge request was closed by pan hui. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9647

1 0

Re: [PATCH v3 0/2] MR9631: dlls/wmp: Implement the OLEIVERB_SHOW needed by the software Alldup；dlls/hhctrl.ocx：no need to set WS_VISSIBLE to Select Topic window - closed
by pan hui (＠panhui) 02 Dec '25

02 Dec '25

This merge request was closed by pan hui. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9631

1 0

[PATCH v6 0/1] MR9632: sxs: avoid uninitialised len_name length
by Hans Chen (＠hans.chen) 02 Dec '25

02 Dec '25

The `redirect_data->clrdata_len` [is unset in /dlls/ntdll/actctx.c#L4411-4412](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ntdll/actctx.c?ref_type=heads#L4411-4412) when using registration-free COM in C# NET code. Program.cs ```C# //... Guid guid = Guid.Parse("COM clsid"); Type type = Type.GetTypeFromCLSID(guid, true); var instance = Activator.CreateInstance(type)); //... ``` App.manifest ```xml <assembly> <file name="ExampleCOM.dll"> <comClass description="ExampleCOM" progid="ExampleCOM" clsid="{COM clsid}" threadingModel="Free"/> </file> </assembly> ``` The above C# code gets this error on its second line. ```Shell System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. ``` This is because `len_name` is uninitialized when calling `memcpy(ret_strings, ptr_name, len_name);` in `SxsLookupClrGuid`, which is fixed in this MR. -- v6: sxs: check len_name is set https://gitlab.winehq.org/wine/wine/-/merge_requests/9632

2 1

[PATCH v5 0/4] MR9632: sxs: avoid uninitialised len_name length
by Hans Chen (＠hans.chen) 02 Dec '25

02 Dec '25

The `redirect_data->clrdata_len` [is unset in /dlls/ntdll/actctx.c#L4411-4412](https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/ntdll/actctx.c?ref_type=heads#L4411-4412) when using registration-free COM in C# NET code. Program.cs ```C# //... Guid guid = Guid.Parse("COM clsid"); Type type = Type.GetTypeFromCLSID(guid, true); var instance = Activator.CreateInstance(type)); //... ``` App.manifest ```xml <assembly> <file name="ExampleCOM.dll"> <comClass description="ExampleCOM" progid="ExampleCOM" clsid="{COM clsid}" threadingModel="Free"/> </file> </assembly> ``` The above C# code gets this error on its second line. ```Shell System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. ``` This is because `len_name` is uninitialized when calling `memcpy(ret_strings, ptr_name, len_name);` in `SxsLookupClrGuid`, which is fixed in this MR. -- v5: change for triggering the pipeline to run https://gitlab.winehq.org/wine/wine/-/merge_requests/9632

2 4

2025

2024

2023

2022

wine-gitlab