- wine-gitlab - winehq.org

[PATCH v4 0/1] MR9126: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC.
by Brendan Shanks (＠bshanks) 27 Oct '25

27 Oct '25

Starting with macOS 10.15, `mmap()` for a file with `PROT_EXEC` fails with `EPERM`. But for some reason, doing separate `mmap()` and then `mprotect()` calls works. This fixes `NtUserRegisterClassExWOW: Failed to get shared session object for window class` errors seen when running a 32-bit EXE lacking the NX compat bit. The shared memory object being used for window classes was being mapped executable, this was failing because of the above, and then `map_file_into_view()` was falling back to `pread()` which doesn't make sense for a shared memory region. (It seems like a bug to use `pread()` in this scenario rather than return an error, although I'm not sure how that could be detected). `map_file_into_view()` uses the `mac_mmap()` wrapper which does the separate `mmap()` and `mprotect()` calls when needed. `map_pe_header()` was also using `PROT_EXEC`, but my understanding is that was only done to detect a noexec filesystem. I did some testing and found that macOS does not restrict executable mapping of files on noexec filesystems like Linux and FreeBSD do, which should remove the need to map `PROT_EXEC` on macOS. CrossOver has used a similar hack for `map_file_into_view()` and `map_pe_header()` for years. -- v4: ntdll: Avoid mmap() failures and Gatekeeper warnings when mapping files with PROT_EXEC. https://gitlab.winehq.org/wine/wine/-/merge_requests/9126

2 1

Re: [PATCH v2 0/3] MR9267: kernelbase, ntdll: Implement synchronization barriers. - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9267

1 0

Re: [PATCH v2 0/3] MR9284: Enfore SymLoadModuleEx(..., SLMFLAG_NO_SYMBOLS) for all debug formats. - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9284

1 0

Re: [PATCH v2 0/1] MR9289: wldap32/tests: Add one more check for an unreachable server. - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9289

1 0

Re: [PATCH v2 0/1] MR9283: wine.desktop: Add Polish translation - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9283

1 0

Re: [PATCH v2 0/1] MR9280: ucrtbase: Fix wait_child_process crash. - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9280

1 0

Re: [PATCH v3 0/4] MR9285: msvcrt: Improvements for WinRT exceptions - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9285

1 0

Re: [PATCH v4 0/5] MR9259: dmusic,dmime: Volume control part 2 - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9259

1 0

Re: [PATCH v2 0/9] MR9281: Fix test failures introduced by wait_child_process change - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9281

1 0

Re: [PATCH v3 0/3] MR9051: qasf: Implement seeking for asf reader. - approved
by Alexandre Julliard (＠julliard) 27 Oct '25

27 Oct '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9051

1 0

2025

2024

2023

2022

wine-gitlab