- wine-gitlab - winehq.org

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 14 Nov '23

14 Nov '23

> Although they look fine, 20ab5954 (and ec219ce1 even more) cut some notes early in FF VIII intro. Looks like note-off queuing for DMUS_PMSGT_NOTE needs to be handled differently. I'll drop these for now. > Haven't really looked into the details but 0ff26da7 feels a bit complicated, I'm wondering if there's a better way to do this. It depends on whether we need to support arbitrary connections. > Regarding 2e226c26, is this what native does? Yes, there is no fallback for melodic instruments for some reason, only for drums. Though now I see that I handle missing regions incorrectly (these should also fall back to Standard). I'll update the request. I was also thinking about adding some tests, though I'm not sure how to compare the output. The generated waveforms are quite different (e.g. native produces a linear attack slope with some discrete steps, while FluidSynth produces a smooth exponential one). ![Screenshot_20231114_155825](/uploads/e46a2662792a0452350b8384b7eea0a6/Screenshot_20231114_155825.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52200

1 0

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Anton Baskanov (＠baskanov) 14 Nov '23

14 Nov '23

On Mon Nov 13 13:16:56 2023 +0000, Rémi Bernon wrote: > Instead of a dynamic list, could we have just a simple structure like: > ```c > struct gen_increments > { > float env_hold; > float env_decay; > float vol_hold; > float vol_decay; > }; > ``` > Which we would pass around down to `add_mod_from_connection` which would > set the needed adjustments (it's actually only needed there, > `set_gen_from_connection` won't have to add increments), and then after > the loops we would call `fluid_voice_gen_incr` for each of these? > Or do we need the generic version for more fixups that are not in this MR? If we don't need to support arbitrary connections, then yes, your proposed solution looks like the way to go. I don't currently plan to add more fixups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52199

1 0

[PATCH 0/1] MR4368: gdi32/tests: Free what GdiConvertToDevmodeW returns with HeapFree.
by Alex Henrie (＠alexhenrie) 14 Nov '23

14 Nov '23

This partially reverts commit 0b7eed0310a2d1272a97d8a45ec37fa03a9c26c8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4368

3 2

[PATCH v2 0/6] MR461: vkd3d: Implement ID3D12Device2::CreatePipelineState().
by Conor McCarthy (＠cmccarthy) 14 Nov '23

14 Nov '23

-- v2: vkd3d: Support depth bounds test. tests: Test CreatePipelineState(). vkd3d: Implement ID3D12Device2::CreatePipelineState(). vkd3d: Use struct d3d12_pipeline_state_desc for compute pipelines. vkd3d: Introduce struct d3d12_pipeline_state_desc for graphics pipelines. include: Add a D3D12_RT_FORMAT_ARRAY typedef. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/461

2 7

[PATCH 0/1] MR4384: ntdll: Don't use sysconf(_SC_PHYS_PAGES) on macOS.
by Brendan Shanks (＠bshanks) 14 Nov '23

14 Nov '23

`sysconf(_SC_PHYS_PAGES)` returns an error for i386 Mac binaries on any machine with more than 4 GB of RAM. From [the source code](https://github.com/apple-oss-distributions/Libc/blob/c5a3293354e22262… it's clear why--it calls `sysctlbyname()` to put the `hw.memsize` sysctl into a long, which is only 32-bits on i386. This returns an error on any Mac with more than 4GB: the value is too large for a 32-bit long. The `sysctl` man page documents that an int64 should be used for `hw.memsize`, do that and divide by the page size ourselves. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4384

2 1

[PATCH 0/1] MR4300: net: Accept yes/no switches
by Fabian Maurer (＠DarkShadow44) 14 Nov '23

14 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4300

2 2

Re: [PATCH v7 0/2] MR3259: Add environment variable to isolate WINEPREFIX at creation
by Fabian Maurer (＠DarkShadow44) 13 Nov '23

13 Nov '23

On Mon Nov 13 21:02:03 2023 +0000, Alexandre Julliard wrote: > > Well, I target the parts where the folders are created, where else > could I handle it? I currently don't see a better way to do this. Mind > pointing me into the direction of a better design? > I don't mean the code, I mean the UI design. > As you point out, this can be configured from winecfg. So why do we need > a separate mechanism, with an ad-hoc environment variable? Why is it > only usable at prefix creation? Is there a way to unify the features, or > make them easier to use? How is it different from `winetricks sandbox`? > etc. etc. Not sure this is the right place to discuss this, but the problem with winecfg is that the config is stored inside the WINEPREFIX. Every new WINEPREFIX would need to be configured again, since you (currently) can't have a global config. Similar issue with `winetricks sandbox`, you need to remember to do it in every new WINEPREFIX. I'm testing a lot of applications, and they often tend to put files into Documents and similar folders, and I want to prevent that. But since I regularly delete my WINEPREFIX, that config currently can't be permanent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52188

1 0

[PATCH v10 0/5] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v10: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

2 6

[PATCH v2 0/2] MR4294: Add stubs for SetThreadDpiHostingBehavior and GetWindowDpiHostingBehavior
by Fabian Maurer (＠DarkShadow44) 13 Nov '23

13 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55847 -- v2: user32: Add stub for GetWindowDpiHostingBehavior user32: Add stub for SetThreadDpiHostingBehavior https://gitlab.winehq.org/wine/wine/-/merge_requests/4294

4 5

[PATCH 0/5] MR4381: DMusic: Remove superfluous checks / casts
by Michael Stefaniuc (＠mstefani) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4381

3 6

2025

2024

2023

2022

wine-gitlab