- wine-gitlab - winehq.org

[PATCH v5 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) 24 Mar '23

24 Mar '23

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v5: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 5

[PATCH v2 0/2] MR2489: include: Add Windows.System.DispatcherQueue definition.
by Biswapriyo Nath (＠Biswa96) 24 Mar '23

24 Mar '23

-- v2: include: Add Windows.System.DispatcherQueue definition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

2 5

[PATCH 0/1] MR2491: include: Add windows.graphics.effects.idl file.
by Mohamad Al-Jaf (＠maljaf) 24 Mar '23

24 Mar '23

Needed for mingw Firefox build. Fairly small file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2491

3 2

[PATCH v4 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) 24 Mar '23

24 Mar '23

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v4: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 6

[PATCH 0/2] MR2489: include: Add Windows.System.DispatcherQueue declaration.
by Biswapriyo Nath (＠Biswa96) 24 Mar '23

24 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2489

4 8

[PATCH 0/5] MR2488: crypt32: Optimize root certificates loading from host.
by Paul Gofman (＠gofman) 24 Mar '23

24 Mar '23

CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY_, ..., "Root") is taking 80-250ms here when executed first time in a process. That triggers a race condition in some CEF / NWJS games (Purgo box is an example), where NWJS seems to depend on main thread initialization going faster than 3d initialization in the other thread (otherwise it crashes). The main hitter is the mentioned CertOpenStore(). Probably more important is that the delay is always there upon first time reading root certs per process start which happens, e. g., any time an app wants to establish a seure connection to public server. The major hitter is rootstore.c:check_and_store_certs() which validates certificate chains as a part of host certificate import which is always done fully. The idea is that we can persist registry cache (which load is relatively quick) only adding a new certificates, also making sure that none of the previously root certs was deleted. In the latter case the patches fallback to full reimport to guarantee that the chain validation is not affected. The patchset brings CertOpenStore(CERT_STORE_PROV_SYSTEM_REGISTRY_, ..., "Root") time from 80-250ms to 5-10ms here after the registry cache was filled once and no cert was deleted on host. The full reinitialization time (on clean prefix or when a cert was deleted) stays nearly the same. Patch 2 introduces a relatively small independent optimization (which avoids searching for certificate in store when it was needed). It has much lesser impact on the overall process (a few ms here) but is also much simplier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2488

3 6

Re: [PATCH v5 0/1] MR2413: comctl32: Fix the problem that listview cannot display all files.
by Zhao Yi (＠Zhaoyi) 24 Mar '23

24 Mar '23

On Fri Mar 24 02:49:18 2023 +0000, Nikolay Sivov wrote: > For commit message it's better to have some description message, and not > duplicating what code actually does. I have just updated my commit message and you can review it again. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2413#note_27721

1 0

[PATCH v4 0/5] MR2469: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 24 Mar '23

24 Mar '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- v4: wined3d: Move the WINED3D_RS_ENABLEADAPTIVETESSELLATION stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_W stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Z stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_Y stub to wined3d_device_apply_stateblock. wined3d: Move the WINED3D_RS_ADAPTIVETESS_X stub to wined3d_device_apply_stateblock. https://gitlab.winehq.org/wine/wine/-/merge_requests/2469

3 6

[PATCH v5 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Zebediah Figura (＠zfigura) 24 Mar '23

24 Mar '23

Without this patch the process will silently die. I managed to trigger this while trying to trace Child of Light with Renderdoc, the latter of which crashed in its own "TargetControlServerThread". This, confusingly, manifested in the game restarting itself without the Ubisoft overlay; apparently the game or one of its launchers was capable of recognizing when the process had died and restarting it, but would not try to inject the overlay a second time. I have not investigated the cause of the crash; it is not unlikely that it resulted from the overlay injection (despite the fact that that should only directly affect PE code.) -- v5: ntdll: Print an error if we receive a signal not on the signal stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/2126

3 4

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 23 Mar '23

23 Mar '23

> Only if you accept that it overflows above the install button, I'm not sure that's better. You're right, it does overflow with some of the translations. This seems like the safest way to add it: ![Screenshot_20230323_190837](/uploads/65da20f990348341c9331a98709a37db/Screenshot_20230323_190837.png) I checked the longest `Install theme` translation, which is Lithuanian, and it doesn't overflow: ![Screenshot_20230323_190610](/uploads/c0af96e1db89d0b9082a77fb778bfad4/Screenshot_20230323_190610.png) Alternatively, the `Color` combo box could be moved to the first row like so: ![Screenshot_20230323_193447](/uploads/8e75a18414ba4f1f29b81bc9a2a4e7f7/Screenshot_20230323_193447.png) Which of these would be most preferable? I'm leaning towards the second one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27712

1 0

2025

2024

2023

2022

wine-gitlab