- wine-gitlab - winehq.org

[PATCH v4 0/10] MR3418: Draft: Add tryok() for tests that may need multiple attempts to succeed
by Francois Gouget (＠fgouget) 16 Aug '23

16 Aug '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is to loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, the tryok() failures area ignored but cause one more attempt to be made. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which marks the current attempt as failed as if calling tryok(0), and returns true if another attempt can be made. * attempt_failed() which returns true if an ok() call failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the few cases I looked at. But I think this mechanism has value even if the two end up coexisting indefinitely. This MR uses the tryok() in some actual tests for illustration and testing purposes. The final MR will probably split most of those off to separate MRs. -- v4: mmdevapi/tests: Replace flaky with tryok() in the capture tests. mmdevapi/tests: Replace flaky with tryok() in the render tests. quartz/tests: Replace flaky() with tryok() to work around scheduling delays. DEBUG ieframe/tests: tryok() framework testing ground. ieframe/tests: Work around a network session race condition. advapi32/tests: Replace the custom loop with tryok() mechanism. ntdll/tests: Use tryok() to fix a free disk space race with other processes. https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

4 16

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Jan Sikorski (＠jsikorski) 16 Aug '23

16 Aug '23

I'm fairly lenient about it, but since you'll be rebasing, please consider Henri's suggestions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_42441

1 0

[PATCH 0/6] MR3572: mf: Make session_get_node_object() more robust.
by Zhiyi Zhang (＠zhiyi) 16 Aug '23

16 Aug '23

It's possible that a state object pointer not in the topology node collection gets passed to session_get_node_object(). Instead of returning the last node when the object is not found, we should return a NULL so that the state of the last node is not changed by mistake. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572

4 20

Re: [PATCH v2 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

This will need a rebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3431#note_42435

1 0

Re: [PATCH v3 0/1] MR3484: sane.ds: Fix pixel type setting.
by Alexandre Julliard (＠julliard) 16 Aug '23

16 Aug '23

Please fix the authorship information in the commit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3484#note_42426

1 0

[PATCH v2 0/1] MR3576: include: Add __WINE_ALLOC_SIZE to the definition of FNALLOC.
by Alex Henrie (＠alexhenrie) 16 Aug '23

16 Aug '23

I missed this one in commit 8f60004995dfc0830067d5d0450a30ef64c54b14. -- v2: include: Add __WINE_ALLOC_SIZE to the definition of FNALLOC. https://gitlab.winehq.org/wine/wine/-/merge_requests/3576

2 1

Re: [PATCH v3 0/2] MR3547: Common Controls: Fix balloon tooltips
by Carl Bialorucki (＠cbialorucki) 16 Aug '23

16 Aug '23

On Wed Aug 16 00:08:12 2023 +0000, Nikolay Sivov wrote: > This combines unrelated changes. Region part should have its own test, > if it's correct to begin with. I already removed the region changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3547#note_42412

1 0

[PATCH 0/1] MR3575: winepulse: Fix crash when requesting exclusive mode with an unsupported format.
by Davide Beatrici (＠davidebeatrici) 15 Aug '23

15 Aug '23

Fixes #55362. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3575

3 3

Re: [PATCH v3 0/2] MR3547: Common Controls: Fix balloon tooltips
by Nikolay Sivov (＠nsivov) 15 Aug '23

15 Aug '23

This combines unrelated changes. Region part should have its own test, if it's correct to begin with. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3547#note_42404

1 0

[PATCH v4 0/11] MR3542: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 4.
by Gabriel Ivăncescu (＠insn) 15 Aug '23

15 Aug '23

The first few patches will introduce temporary leaks or cyclic refs, but that's because we'll handle them properly with the dispex CC, and the last patch should fix this. Other objects' traversal will follow in another MR. EDIT: This now does more prep work and converts nodes to use the dispex CC, using temporary helpers, without any other object or temporary leaks yet. -- v4: mshtml: Release the event target during node unlink. mshtml: Implement node cycle collection using the dispex. mshtml: Move ccref from the node to the dispex. mshtml: Rename EventTarget_QI to EventTarget_QI_no_cc. mshtml: Rename dispex_query_interface to dispex_query_interface_no_cc. mshtml: Use designated initializers in node vtables. mshtml: Use designated initializers in dispex and event target vtables. mshtml: Make all event target vtbls const. mshtml: Split IUnknown methods for outer windows into separate vtable. mshtml: Move console to the inner window. mshtml: Use ASCII strings for dispex object names. https://gitlab.winehq.org/wine/wine/-/merge_requests/3542

3 14

2025

2024

2023

2022

wine-gitlab