- wine-gitlab - winehq.org

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > > status = wow64_unmap_buffer( ptr, get_named_buffer_param( teb, params32->buffer, GL_BUFFER_MAP_LENGTH ), > get_named_buffer_param( teb, params32->buffer, GL_BUFFER_ACCESS_FLAGS ) ); > gl_unmap_named_buffer64( args ); ```suggestion:-7+0 struct glUnmapNamedBuffer_params params = { .teb = get_teb64(params32->teb), .buffer = params32->buffer, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_named_buffer_pointer( params.teb, params.buffer ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_MAP_LENGTH ), get_named_buffer_param( params.teb, params.buffer, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_named_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26527

1 0

Re: [PATCH v2 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

Rémi Bernon (@rbernon) commented about dlls/opengl32/unix_wgl.c: > } *params32 = args; > NTSTATUS status; > TEB *teb = get_teb64( params32->teb ); > + struct glUnmapBuffer_params params = { teb, params32->target, params32->ret }; > > if (!(ptr = get_buffer_pointer( teb, params32->target ))) return STATUS_SUCCESS; > > status = wow64_unmap_buffer( ptr, get_buffer_param( teb, params32->target, GL_BUFFER_MAP_LENGTH ), > get_buffer_param( teb, params32->target, GL_BUFFER_ACCESS_FLAGS ) ); > - gl_unmap_buffer64( args ); > + gl_unmap_buffer64( &params ); ```suggestion:-8+0 struct glUnmapBuffer_params params = { .teb = get_teb64(params32->teb), .target = params32->target, .ret = TRUE, }; NTSTATUS status; if (!(ptr = get_buffer_pointer( params.teb, params.target ))) return STATUS_SUCCESS; status = wow64_unmap_buffer( ptr, get_buffer_param( params.teb, params.target, GL_BUFFER_MAP_LENGTH ), get_buffer_param( params.teb, params.target, GL_BUFFER_ACCESS_FLAGS ) ); gl_unmap_buffer64( &params ); params32->ret = params.ret; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359#note_26526

1 0

[PATCH 0/1] MR2359: opengl32: fix bug abort missing convert of glUmapBuffer_params from 32bit to 64bit
by Fan WenJie (＠fanwenjie) 09 Mar '23

09 Mar '23

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2359

2 1

Re: [PATCH v3 0/1] MR2346: winsqlite3: Add stub DLL.
by Jinoh Kang (＠iamahuman) 09 Mar '23

09 Mar '23

We should probably bundle `winsqlite3.dll` in the same manner we do for `wine-mono`, `wine-gecko`, etc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2346#note_26523

1 0

[PATCH 0/1] MR2357: windows.perception.stub/tests: Skip some tests when ISpatialSurfaceObserverStatics2 is not supported.
by Francois Gouget (＠fgouget) 09 Mar '23

09 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54649 --- This fixes the crash on Windows 10 1607. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2357

2 1

[PATCH v3 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- v3: win32u: Call NtUserActivateKeyboardLayout on focus change. winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

2 6

[PATCH v2 0/5] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 09 Mar '23

09 Mar '23

-- v2: win32u: Call NtUserActivateKeyboardLayout on focus change. winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

3 7

[PATCH v15 0/10] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 09 Mar '23

09 Mar '23

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v15: kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). kernelbase: Move create_key() below open_key(). kernelbase: Factor opening a subkey out of open_key(). kernelbase: Always try to open the Wow6432Node in open_key(). kernelbase: Restructure the open_key() loop. kernelbase: Pass the key name to create_key(). kernelbase: Pass the root key to create_key(). kernelbase: Pass the key name to open_key(). kernelbase: Pass the root key to open_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 11

[PATCH 0/2] MR2356: regedit fixes
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

1. Allow export_key() to return TRUE. 2. Append '.reg' file extension if necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2356

2 2

Re: [PATCH v2 0/4] MR1899: kernel32/tests: Call newer functions not on Windows XP or 2003 via function addresses (process) - closed
by Hugh McMaster (＠hmc) 09 Mar '23

09 Mar '23

This merge request was closed by Hugh McMaster. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1899

1 0

2025

2024

2023

2022

wine-gitlab