- wine-gitlab - winehq.org

[PATCH v4 0/11] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) 15 Sep '23

15 Sep '23

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v4: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Skip acquiring a context for an offscreen resource in texture2d_read_from_framebuffer(). wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

5 14

[PATCH 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) 15 Sep '23

15 Sep '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

3 9

[PATCH 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 15 Sep '23

15 Sep '23

Based on patch by Michael Müller. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854

2 1

[PATCH 0/2] MR3843: d3dx9: Handle special adjacency index value in d3dx9_mesh_OptimizeInplace().
by Paul Gofman (＠gofman) 15 Sep '23

15 Sep '23

Avoid crash in d3dx9_mesh_OptimizeInplace(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3843

3 4

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Looks good. I've pointed out a few small corrections. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45501

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + key_data = (BYTE *)key_data + key_size; > + rw_data = (BYTE *)rw_data + rw_size; > + dynamic_data = (BYTE *)dynamic_data + dynamic_size; > + static_data = (BYTE *)static_data + static_size; > + } > + num++; > + } > + fclose(fp); > + } > +#else > FIXME( "not implemented\n" ); > - *count = 0; > - return STATUS_SUCCESS; > + return STATUS_NOT_IMPLEMENTED; > +#endif > + There are some extraneous spaces on this line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45500

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + struct in6_addr prefix; > + UINT prefix_len; > + struct in6_addr next_hop; > + UINT metric; > + UINT protocol; > + BYTE loopback; > +}; > + > +static void ipv6_forward_fill_entry( struct ipv6_route_data *entry, struct nsi_ipv6_forward_key *key, > + struct nsi_ip_forward_rw *rw, struct nsi_ipv6_forward_dynamic *dyn, > + struct nsi_ip_forward_static *stat ) > +{ > + if (key) > + { > + key->unk = 0; > + memcpy( key->prefix.u.Byte, entry->prefix.s6_addr, 16 ); Please use something like `sizeof(entry->prefix)` instead of `16`. Also for `next_hop` below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45497

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + { > + memset( dyn, 0, sizeof(*dyn) ); > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) Again something like `sizeof(ret)` instead of `16`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45498

1 0

Re: [PATCH v4 0/1] MR3784: nsiproxy.sys: Implement ipv6_forward_enumerate_all.
by Huw Davies (＠huw) 15 Sep '23

15 Sep '23

Huw Davies (@huw) commented about dlls/nsiproxy.sys/ip.c: > + } > + > + if (stat) > + { > + stat->origin = NlroManual; > + stat->if_index = entry->if_index; > + } > +} > + > +struct in6_addr str_to_in6_addr(char *nptr, char **endptr) > +{ > + struct in6_addr ret; > + > + for (int i = 0; i < 16; i++) > + { > + if (!isalnum( *nptr ) || !isalnum( *nptr+1 )) `isxdigit()`? Also, please add a space either side of the `+`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3784#note_45499

1 0

[PATCH 0/1] MR3841: wineps: Fix EMRPOLYDRAW16 printing.
by Piotr Caban (＠piotr) 15 Sep '23

15 Sep '23

It fixes EMRPOLYDRAW16 printing when -O2 option is used (in GCC 12.3.1). The compiler assumes that apts table has 0 or 1 elements and optimizes the loop out. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3841

3 5

2025

2024

2023

2022

wine-gitlab