On Wed Aug 9 04:43:08 2023 +0000, Mohamad Al-Jaf wrote:
> I thought I did add `WindowsDeleteString`. I wasn't sure if adding
> `WindowsDuplicateString` to `device_statics2_CreateWatcher` should be in
> the same commit or not. I added it in a new commit.
> Thanks for the review.
If you want to put it in a separate commit, it should probably come first, with the field addition and the `WindowsDeleteString` call. Otherwise when `device_statics2_CreateWatcher` was used, `Release` will call `WindowsDeleteString` on destruction with an invalid filter (though perhaps zero-initialized HSTRING is valid, but imho it'd be better that way).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3519#note_41752
There is a working in progress winegstreamer muxer backend: !3303
This patch set is the windows api side(frontend) of the muxer stuff.
It will make the patch set too large to submit the backend and frontend together, so I decide to submit the frontend first.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3528
On Tue Aug 8 20:11:16 2023 +0000, Esme Povirk wrote:
> Wouldn't this be implied by the transitive property?
I based this off the checks in `test_tiff_properties`, which did all three checks.
I could certainly remove one to avoid redundancy.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3524#note_41713