- wine-gitlab - winehq.org

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle - approved
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030

1 0

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:48:44 2023 +0000, Fabian Maurer wrote: > There is exception handling: > ``` > #include "wine/exception.h" > __TRY > { > } > __EXCEPT_PAGE_FAULT > { > } > __ENDTRY > ``` > Though maybe there is a reason that is not used in tests, maybe one of > the devs can chime in. It needs compiler support. I don't think you will be able to write a test for this easily, manually checking that it actually crashes on Windows is enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35373

1 0

Re: [PATCH v6 0/2] MR2957: win32u: Move QueryDisplayConfig from user32. - approved
by Rémi Bernon (＠rbernon) 11 Jun '23

11 Jun '23

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

1 0

[PATCH 0/1] MR3016: dbghelp: Fix memory leak on error path in pe_load_native_module (scan-build).
by Alex Henrie (＠alexhenrie) 11 Jun '23

11 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3016

3 4

[PATCH v4 0/2] MR2957: win32u: Move QueryDisplayConfig from user32.
by Tatsuyuki Ishi (＠ishitatsuyuki) 11 Jun '23

11 Jun '23

This allows access to the in-process cached monitor list and reduces the number of registry calls issued for QueryDisplayConfig (in case of no change) from `4 x monitors` to `1`. -- v4: win32u: Cleanup naming and log messages for QueryDisplayConfig. win32u: Move QueryDisplayConfig from user32. https://gitlab.winehq.org/wine/wine/-/merge_requests/2957

2 3

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Fabian Maurer (＠DarkShadow44) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:34:19 2023 +0000, Etaash Mathamsetty wrote: > If I added the test, it would just crash the test program. In other > tests they simply just add a win_skip in these cases, but then there's > no point in having a test in my opinion, since it's just going to get skipped. > Not sure what to do about RtlReAllocateHeap unfortunately. There is exception handling: ``` #include "wine/exception.h" __TRY { } __EXCEPT_PAGE_FAULT { } __ENDTRY ``` Though maybe there is a reason that is not used in tests, maybe one of the devs can chime in. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35348

1 0

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Etaash Mathamsetty (＠etaash.mathamsetty) 11 Jun '23

11 Jun '23

On Sun Jun 11 02:32:59 2023 +0000, Fabian Maurer wrote: > FWIW, there seems to be a difference between 32bit and 64bit Growtopia. > 32bit Growtopia launches normally, while 64bit crashes without the fix. > Btw, what about RtlReAllocateHeap? Should that behavior be consistent? I > don't know what the Wine consensus is. > Also, since it's pretty counter intuitive, would you mind adding tests? > Just a suggestions from a random contributor, though. :smile: If I added the test, it would just crash the test program. In other tests they simply just add a win_skip in these cases, but then there's no point in having a test in my opinion, since it's just going to get skipped. Not sure what to do about RtlReAllocateHeap -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35347

1 0

[PATCH v2 0/10] MR2993: comdlg32: IFileDialog navigation bar control. Part 1.
by Vladislav Timonin (＠vt) 10 Jun '23

10 Jun '23

Redo of !1857, as suggested, the plan is to split original MR in half, breadcrumbs in first (this) MR, and address edit in another. The changes are mostly cleanup (formatting, renaming, unused variables, missing free). Part two branch can be found [here](https://gitlab.winehq.org/vt/wine/-/commits/fd-navbar-part2). Visually, it hasn't changed: ![](/uploads/37038708b7500cda4f0cffde8981e58c/changes.png) Requires !2068, otherwise if application doesn't request comctl v6 (e.g. qapitrace), navigation bar will look like this: ![no-comctl-v6](/uploads/03e6a8b6dcf827114157e79640e49fea/no-comctl-v6.png) Closes: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=54812 - https://bugs.winehq.org/show_bug.cgi?id=50338 (partially? fully with address edit?) -- v2: comdlg32: Prevent arrow navigation of IFileDialog navigation bar buttons. comdlg32: Don't paint focus rect in IFileDialog navigation bar buttons. comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add inner border to breadcrumbs in IFileDialog navigation bar. comdlg32: Always show at least 2 crumbs in IFileDialog navigation bar. comdlg32: Reuse address breadcrumbs in IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2993

3 18

Re: [PATCH v3 0/1] MR3030: ntdll: Allow RtlAllocateHeap to crash with invalid handle
by Fabian Maurer (＠DarkShadow44) 10 Jun '23

10 Jun '23

FWIW, there seems to be a difference between 32bit and 64bit Growtopia. 32bit Growtopia launches normally, while 64bit crashes without the fix. Btw, what about RtlReAllocateHeap? Should that behavior be consistent? I don't know what the Wine consensus is. Also, since it's pretty counter intuitive, would you mind adding tests? Just a suggestions from a random contributor, though. :smile: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3030#note_35326

1 0

[PATCH v4 0/1] MR3006: gdiplus: Improve performance of drawing, by reducing not needed calculations
by Bartosz Kosiorek (＠gang65) 10 Jun '23

10 Jun '23

-- v4: https://gitlab.winehq.org/wine/wine/-/merge_requests/3006

2 2

2025

2024

2023

2022

wine-gitlab