a hotfix for the recent release of Persona 5 Royal.
--
v12: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W().
kernel32: Add semi-stub for GetFileAttributesTransactedA/W().
kernel32: Add semi-stub for FindFirstFileTransactedA/W().
kernel32: Add semi-stub for DeleteFileTransactedA/W().
kernel32: Add semi-stub for CreateDirectoryTransactedA/W().
kernel32: Add semi-stub for CreateFileTransactedA/W().
https://gitlab.winehq.org/wine/wine/-/merge_requests/1145
On Fri Feb 10 05:54:45 2023 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The tests also ran into some preexisting test failures. If you know how
> to fix them that would be helpful. See the TestBot job for the details:
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=129281
> Your paranoid android.
> === w7u_2qxl (32 bit report) ===
> user32:
> msg.c:11208: Test failed: Got 1, error 1159.
> === w7u_el (32 bit report) ===
> user32:
> msg.c:11208: Test failed: Got 1, error 1159.
> === w1064v1507 (32 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064v1809 (32 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064_tsign (32 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64 (32 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064v1507 (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064v1809 (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064_2qxl (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064_adm (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w1064_tsign (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64 (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64_en_AE_u8 (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64_ar (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64_ja (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> === w10pro64_zh_CN (64 bit report) ===
> user32:
> msg.c:11209: Test failed: Device broadcast was not received.
> ```
For reference this message indicates that the merge request introduces a new failure. Such merge requests should not be merged!
See bug 54477:
https://bugs.winehq.org//show_bug.cgi?id=54477
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2154#note_23866