- wine-gitlab - winehq.org

Re: [PATCH v4 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

On Thu Jan 5 07:09:52 2023 +0000, Nikolay Sivov wrote: > @ripxorip please squash these commits locally and then force push to > have a single commit. Sure thing -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908#note_20355

1 0

[PATCH v3 0/3] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- v3: Sends the correct pointer to memset https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

3 4

[PATCH 0/1] MR1910: include: Add missing enum XHR_PROP_ values
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jan '23

05 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1910

3 2

[PATCH 0/1] MR1911: xactengine3_7/tests: Skip tests when XACTEngine Initialization fails
by Alistair Leslie-Hughes (＠alesliehughes) 05 Jan '23

05 Jan '23

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=54151 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1911

2 1

[PATCH v2 0/2] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- v2: Memset the struct to avoid exlicit initialization https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

3 4

[PATCH 0/1] MR1908: msi: pSignatureSettings uninitialized
by Philip Karlsson Gisslow (＠ripxorip) 05 Jan '23

05 Jan '23

This field was not unitilized so it got a random value from the stack causing a later crash when it was dereferenced in Wintrust (SoftPubloadSignature). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1908

4 4

[PATCH 0/1] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 04 Jan '23

04 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

2 1

[PATCH v3 0/1] MR1878: comctl32/listview: Exclude header area in WM_NCPAINT.
by Vladislav Timonin (＠vt) 04 Jan '23

04 Jan '23

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) EDIT1: Actually compared screenshots of 7-Zip file manager and looks like the headers are now painted consistently after highlighting them. ![7zFM-before-hilite](/uploads/64fe3fb80002c847c2e9270337bab4e8/7zFM-before-hilite.png) ![7zFM-after-hilite](/uploads/4db4778c2ad6d27eddbd4a1202b41881/7zFM-after-hilite.png) -- v3: comctl32/listview: Exclude header area in WM_NCPAINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

4 4

[PATCH 0/1] MR1902: d2d1/tests: Fix memory leaks.
by Zhiyi Zhang (＠zhiyi) 04 Jan '23

04 Jan '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53995 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1902

3 2

[PATCH 0/1] MR1907: user32: Set 32-bit base address
by Patrick Szczepański (＠PSzczepanski1996) 04 Jan '23

04 Jan '23

For some reason NosTale is checking memory regions preventing it's own logic from calling system memory. It checks if the code is called under "0x70000000" range, but for some reason "user32.dll" is placed below this region (by Wine) causing mouse bug, graphical glitches and other memory-access related errors. This pull-request fixes the bug, because I wanted to be sure I tested it on two Linux machines, Steam Deck and one macOS device. Everything just works fine. Not sure if we should set only this dll base address or (according to reference image) set it for other dll libraries too. Also under Windows (I tested it too) it's randomized by ALSR - maybe we should do it the same way (and place library between range "0x70000000" - 0x80000000" for example). Reference: https://user-images.githubusercontent.com/21007545/210278824-29f42d90-aca4-… Resolves these issues: https://bugs.winehq.org/show_bug.cgi?id=49988 https://bugs.winehq.org/show_bug.cgi?id=42999 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1907

2 1

2025

2024

2023

2022

wine-gitlab