- wine-gitlab - winehq.org

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Sat Dec 17 10:41:32 2022 +0000, Etaash Mathamsetty wrote: > I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da > (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add > tests) into one commit I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19792

1 0

[PATCH 0/1] MR1833: libs/wine: Only define exe_link when needed
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

Revision 24b26f8bd6a49c855eec417a6585d44c9458e3ec changed FreeBSD (and DragonFly) not to use /proc any longer. Hence we also do not need the exe_link variable on those two platforms, either. Avoid declaring it there. (This avoids a compiler warning about an unused variable with GCC 12.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1833

2 1

[PATCH 0/1] MR1831: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

find_device_from_devnode was unnecessarily guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. Simply make find_device_from_devnode generally available. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1831

3 2

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 17 Dec '22

17 Dec '22

On Thu Dec 15 20:00:54 2022 +0000, Etaash Mathamsetty wrote: > you should mark them as todo in the code for the tests then I can do so, but before semi stub implementation even more tests are failing. See description. Should i squash mark all tests as todo and remove the markers with semi stub commit? Thanks for your help. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19782

1 0

Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()
by Etaash Mathamsetty (＠etaash.mathamsetty) 17 Dec '22

17 Dec '22

I also think you should squash c4e27bd0483c0a1fb872111b6c03b9ad240d85da (mark tests as todo) and d02be967f9cca0805b5eeaef6a74b3ec51a67619 (add tests) into one commit -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_19781

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Alex Henrie (＠alexhenrie) 17 Dec '22

17 Dec '22

On Sat Dec 17 00:00:58 2022 +0000, Gerald Pfeifer wrote: > Any chance you can cherry pick > https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… > ? > Git/Gitlab and me are not friends yet, and I already spent hours > (literally!) on this. :-( You've just got to learn how to use Git. One way to fix your branch: `git pull -ri https://gitlab.winehq.org/wine/wine.git master` Change all but the first commit to "squash", edit the commit message until it looks right, and then force-push. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19775

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 17 Dec '22

17 Dec '22

On Fri Dec 16 23:23:09 2022 +0000, Rémi Bernon wrote: > I don't have a strong opinion, although I tend to prefer having > variables declared in one place, especially for small functions like > this. In any case it's an unrelated and unnecessary change here. Any chance you can cherry pick https://gitlab.winehq.org/wine/wine/-/commit/6ddda5b130481c89dae3750597452f… ? Git/Gitlab and me are not friends yet, and I already spent hours (literally!) on this. :-( -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810#note_19774

1 0

Re: [PATCH v6 0/41] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H - closed
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

This merge request was closed by Gerald Pfeifer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

1 0

[PATCH v3 0/1] MR1810: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H
by Gerald Pfeifer (＠gerald) 16 Dec '22

16 Dec '22

find_device_from_devnode was guarded by HAVE_SYS_INOTIFY_H, alas its use in process_monitor_event was not, so linking failed. On the way reduce the scope of a variable (which makes sense per se and avoids introducing a compiler warning with this change). -- v3: winebus.sys: Fix the build without HAVE_SYS_INOTIFY_H https://gitlab.winehq.org/wine/wine/-/merge_requests/1810

3 4

Re: [PATCH 0/2] MR31: shell32: Only call HCR_GetFolderAttributes with simple pidls - closed
by Fabian Maurer (＠DarkShadow44) 16 Dec '22

16 Dec '22

This merge request was closed by Fabian Maurer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/31

1 0

2025

2024

2023

2022

wine-gitlab