- wine-gitlab - winehq.org

[PATCH v4 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 23 Mar '23

23 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v4: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open code FILE_UNIX_{READ,WRITE}_ACCESS ntdll/tests: Added tests for attributes access on read-only files. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

2 3

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Alexandre Julliard (＠julliard) 23 Mar '23

23 Mar '23

> How's this? > > Thanks for the review! :smiley: Actually thinking some more about this, a simple check mark may be better than a drop-down. It's not like there would be other possible options. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27620

1 0

[PATCH 0/3] MR2483: kernelbase: Refactor create_key() in the same way as open_key().
by Sven Baars (＠sbaars) 23 Mar '23

23 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 3

[PATCH v2 0/5] MR2452: imm32: Implement ImmEnumInputContext.
by Rémi Bernon (＠rbernon) 23 Mar '23

23 Mar '23

-- v2: imm32: Rename InputContextData to struct imc. imm32: Use NtUserQueryInputContext to check cross-thread access. imm32: Remove unused IMM_IsCrossThreadAccess hwnd parameter. imm32: Remove unnecessary threadDefault InputContextData member. imm32: Implement ImmEnumInputContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/2452

2 6

Re: [PATCH v2 0/4] MR2364: wine{alsa,coreaudio,oss,pulse}: Use GetModuleFileName() instead of hardcoded module filename for registry key.
by Huw Davies (＠huw) 23 Mar '23

23 Mar '23

On Thu Mar 23 03:02:29 2023 +0000, Davide Beatrici wrote: > How should we proceed then? Well, let's leave the default endpoints in pulse for now, but don't add them to any other drivers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2364#note_27609

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 23 Mar '23

23 Mar '23

On Wed Mar 22 08:48:00 2023 +0000, Alexandre Julliard wrote: > These strings should be translatable. How's this? Thanks for the review! :smiley: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27604

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 23 Mar '23

23 Mar '23

On Wed Mar 22 08:48:00 2023 +0000, Alexandre Julliard wrote: > It's a dword key, treating it as a string is ugly. I agree. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27603

1 0

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 23 Mar '23

23 Mar '23

On Wed Mar 22 08:47:59 2023 +0000, Alexandre Julliard wrote: > This shouldn't be necessary, unless there's an app that explicitly > checks the value. None that I know of, removed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27602

1 0

[PATCH v9 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) 23 Mar '23

23 Mar '23

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v9: winecfg: Add an option to set WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 1

[PATCH v3 0/4] MR2465: windows.ui: Add Stubbed interface IUISettings
by Alistair Leslie-Hughes (＠alesliehughes) 23 Mar '23

23 Mar '23

This corrects what interface should be returned, there isn't a hierarchy with these IUISettings at all. It should return IUISettings and then QI for any others that it requires. -- v3: windows.ui: Use DEFINE_IINSPECTABLE for IUISettings3 windows.ui: Add IUISettings2 stub interface windows.ui: Add Stubbed interface IUISettings include: Add Missing IUISettings interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2465

3 8

2025

2024

2023

2022

wine-gitlab