- wine-gitlab - winehq.org

[PATCH 0/4] MR2127: ntdll: Load known dlls from system directory
by Paul Gofman (＠gofman) 07 Feb '23

07 Feb '23

The practical issue I am trying to solve is the following scenario (encountered with a game using some Uplay plugin) which has regressed with apisets implementation in Wine. The game imports ucrtbase.dll. Then, a plugin calls GetModuleHandle("api-ms-win-crt-runtime-l1-1-0.dll") and expects GetProcAddress("\_crt_atexit") to succeed on the returned handle. The problem is that the game has ucrtbase.dll in its .exe directory. That one currently gets loaded. Then, find_dll_file() resolves api-ms-win-crt-runtime-l1-1-0.dll to the ucrtbase with a full path in system32 and tries to find that one (this part matches Windows behaviour as far as tests show). Since we have ucrtbase loaded with another path this results in NULL module handle. Windows maintains the list of "Known DLLs" (probably aimed for speeding up processes startup by using pre-mapped dll images for commonly used system dlls). On Windows, known dlls have specifics in load path resolution when dll name doesn't contain path (relative or full): - they are loaded from system directory even if there is another dll with the same name in priority search path; - they are found even if library search paths do not contain system directory; Those "Known DLLs" are basically listed in HKLM\\System\\CurrentControlSet\\Control\\Session Manager\KnownDLLs registry key. But the actual list of "known dlls" is bigger (probably includes all dependencies of those listed under registry key). The full actual list of "known dlls" is in '\\KnownDlls\' directory object which contains image sections under dll names. Most notably, ucrtbase.dll (which is of the concern in the regression) is not listed in registry but is present in \\KnownDlls. Technically nothing prevents us from implementing these mechanics and creating directory object with mapped load dlls, also resolving the explicitly listed dlls' dependencies. But it is not apparent to me if that is going to improve load times noticably in Wine, and also that is worth the inherent complications until anything actually depends on that \\KnownDlls sections. So instead of implementing all of that throughout the loader I added a few missing dlls to registry. The current list in this pat chset corresponds to the contents of \\KnownDlls directory on an up to date Windows 10. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2127

3 5

Re: [PATCH v2 0/1] MR2113: odbccp32: Append DLL path when loading driver. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2113

1 0

[PATCH v3 0/11] MR2123: Wow64 support for wpcap.
by Hans Leidekker (＠hans) 07 Feb '23

07 Feb '23

-- v3: wpcap/tests: Initial tests. wpcap: Try to enable 32-bit mmap() support in libpcap. wpcap: Add wow64 thunks. wpcap: Enable UTF-8 encoding in libpcap. wpcap: Reimplement pcap_loop() on top of pcap_next_ex(). wpcap: Implement pcap_init(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2123

3 12

Re: [PATCH v2 0/7] MR2117: More improvements in PDB dumping. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2117

1 0

Re: [PATCH v7 0/1] MR1937: kernelbase: Fix grouping repeat for number formatting. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1937

1 0

Re: [PATCH v2 0/8] MR2076: win32u: Introduce and use KBDTABLES structure for nulldrv keyboard layout. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2076

1 0

Re: [PATCH v2 0/1] MR2121: winhlp32: Fix memory leak on realloc failure in HLPFILE_RtfAddBitmap (cppcheck). - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2121

1 0

Re: [PATCH v3 0/4] MR2119: kernelbase: Add QueryInterruptTime and QueryInterruptTimePrecise/QueryUnbiasedInterruptTimePrecise semi-stubs. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2119

1 0

Re: [PATCH v2 0/1] MR2111: nsiproxy: Avoid calling RtlInitUnicodeString on a static constant. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2111

1 0

Re: [PATCH v3 0/1] MR2112: combase: Avoid calling RtlInitUnicodeString on a static constant. - approved
by Alexandre Julliard (＠julliard) 07 Feb '23

07 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2112

1 0

2025

2024

2023

2022

wine-gitlab