- wine-gitlab - winehq.org

[PATCH 0/3] MR1590: Layered window hit testing
by Zhiyi Zhang (＠zhiyi) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1590

3 4

[PATCH 0/6] MR1577: win32u: Move a few DC functions from user32.
by Jacek Caban (＠jacek) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1577

3 7

[PATCH 0/1] MR1586: winex11: Fix memory leak on realloc failure in import_xdnd_selection (cppcheck).
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1586

3 2

[PATCH 0/1] MR1584: appwiz: Fix memory leak on realloc failure in install_from_registered_dir (cppcheck).
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1584

3 2

[PATCH v8 0/1] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl (＠besentv) 29 Nov '22

29 Nov '22

-- v8: mfmediaengine: Pass volume changes to media session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

3 2

[PATCH 0/1] MR1583: atl: Fix memory leak on error path in do_process_root_key (scan-build).
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1583

3 2

[PATCH 0/1] MR1566: comctl32: Use standard C functions for memory allocation in edit.c.
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1566

4 3

[PATCH 0/1] MR1581: include: Annotate StrDup[AW] with __WINE_MALLOC and __WINE_DEALLOC.
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

This gets us a nice warning if a string allocated by one of these functions is freed incorrectly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1581

3 2

[PATCH v2 0/2] MR1574: include: Add shobjidl_core.idl.
by Alex Henrie (＠alexhenrie) 29 Nov '22

29 Nov '22

Needed to compile Tera Term. -- v2: include: Add shobjidl_core.idl. shell32: Rename ShellItem to struct shell_item. https://gitlab.winehq.org/wine/wine/-/merge_requests/1574

3 4

Re: [PATCH v5 0/1] MR1503: wineusb.sys: Move event handling to a single thread.
by Ivo Ivanov (＠logos128) 29 Nov '22

29 Nov '22

> Wouldn't we normally be in libusb_handle_events() at this point? I guess there's just differences between different call stacks? Yes, it is polling in the libusb_event thread at this point. The actual segfault happens in the wineusb client thread, where it is waiting in pthread_cond_wait(). I tried to debug this several times, but the call stack was obviously wrong, so I couldn't figure out what was raising the signal. All other threads exit normally, with the libusb_event thread last. Here is a small analysis I did with gdb: [winedevice_sigsegv.log](/uploads/6cd9ecc4c4d6fd798c402079b067d77f/winedevice_sigsegv.log) The first part of the log is the actual core dump. The second part includes a gdb session with the problematic winedevice.exe, where all threads are initially described by their call stacks, and then execution continues to the end. > I don't think we should be terminating threads at all. It appears that comes from 7f749d58d, but we should probably just figure out what's keeping those threads alive and give them a chance to shut down naturally, adjusting timeouts if necessary. I think there was an effort https://gitlab.winehq.org/wine/wine/-/merge_requests/1088 to fix this in general, which has been put on hold for now. > That's all orthogonal to this change, though, or at least, I think it makes sense regardless of bug 52213, since it simplifies the code. I agree. I should have put the emphasis on the new implementation. But then again my main motivation to implement this was to fix the crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1503#note_17798

1 0

2025

2024

2023

2022

wine-gitlab