Chip Davis (@cdavis5e) commented about dlls/scrrun/filesystem.c:
> if((attrs == INVALID_FILE_ATTRIBUTES) || !(attrs & FILE_ATTRIBUTE_DIRECTORY))
> return CTL_E_PATHNOTFOUND;
>
> + _wsplitpath(source, src_drive, src_dir, file_name, file_ext);
> + len = lstrlenW(destination);
> +
> + if (destination[len-1] == '\\') {
What about `'/'`? I know that's a valid separator to the Win32 API. Is it one to this API?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/391#note_3508
--
v3: regedit: Directly use RegQueryValueExW() instead of a helper function.
regedit: Correctly calculate REG_MULTI_SZ size before reading from the buffer.
regedit: Remove unneeded valueDataLen override for DWORD values.
https://gitlab.winehq.org/wine/wine/-/merge_requests/392
I'll have a look at the time failures, I was seeing them locally but not on the testbot run so I assumed they were flukes caused by some decoder differences, looks like it may be something else after all.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/393#note_3477