- wine-gitlab - winehq.org

[PATCH 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 27 Dec '22

27 Dec '22

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - first crumb is always moved here - removes the split, if there are no items in the menu - hidden crumbs are moved here - left or right click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

4 8

[PATCH 0/2] MR1886: Fixing paste errors on edit control in Win10+.
by eric pouech (＠epo) 26 Dec '22

26 Dec '22

This series tries to fix WM_PASTE tests error on edit control (both user32 & comctl32). The test failures where systematic on a local Win10 for comctl32 (yet very rare on user32, perhaps one in 20 runs). Since the failures are not systematic, it ought to be a synchronisation / timing issue. Flushing the msg queue before starting the paste test cycle seems to fix the issue. - 0 occurence on comctl32 and user32 in 50 run (local VM) - 0 occurence on Testbot (comctl32) in 1 run. It's hard to be fully conclusive about bug resolution, but it's at least a step into the right direction. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1886

3 5

[PATCH 0/1] MR1885: conhost: Fix incorrect registry value name
by Hugh McMaster (＠hmc) 26 Dec '22

26 Dec '22

The correct value name is 'FontFamily'. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1885

3 2

[PATCH v2 0/3] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 26 Dec '22

26 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- v2: bthprops.cpl: Add BluetoothUnregisterAuthentication stub. bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub. include/bluetoothapis: Add BluetoothRegisterForAuthenticationEx prototype. https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

2 4

[PATCH 0/3] MR1889: bthprops.cpl: Add BluetoothRegisterForAuthenticationEx stub.
by Mohamad Al-Jaf (＠maljaf) 26 Dec '22

26 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54112 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1889

2 3

[PATCH v2 0/1] MR1881: comctl32/test: Adapt the edit tests for height to Win10+.
by eric pouech (＠epo) 26 Dec '22

26 Dec '22

Starting with Win10, height of multiline edit controls no longer seems to be hardwired to a multiple of the font height (when larger than font height). - Adapt the tests accordingly (detecting how to compute the expected height of a control). - Extend the ranges of the tested heights. Note: - there may be another way to detect the model for height computation. - the range of heights tested stem from internal testing and is larger than existing testing. It could be reduced as a range, or picking values from a fixed set of values (if needed). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52152 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- v2: comctl32/test: Adapt the edit tests for height to Win10+. https://gitlab.winehq.org/wine/wine/-/merge_requests/1881

3 4

[PATCH 0/1] MR1882: comctl32/tests: Fix failing test on Windows in Arabic UTF-8.
by eric pouech (＠epo) 24 Dec '22

24 Dec '22

Already fixed in user32/tests/edit.c by 614b7d7430e0ba60692a46e97f03b8b9600f0651 Apply same fix for equivalent test on comctl32/tests/edit.c Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52932 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1882

4 3

[PATCH v3 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis.
by Tim Clem (＠tclem) 24 Dec '22

24 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53627 -- v3: dinput: Add granularity to object_properties. dinput: Create object_properties for each mouse axis. https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

3 5

[PATCH 0/2] MR37: Add some DXIL support.
by Conor McCarthy (＠cmccarthy) 24 Dec '22

24 Dec '22

Tracing of very simple SM 6 shaders is possible with these patches; for example a pixel shader which returns a vector of constants. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/37

5 33

[PATCH v2 0/3] MR1887: dinput: Return WHEEL_DELTA for the granularity of the mouse z-axis.
by Tim Clem (＠tclem) 23 Dec '22

23 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53627 -- v2: dinput: Add granularity to object_properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/1887

2 3

2025

2024

2023

2022

wine-gitlab