- wine-gitlab - winehq.org

[PATCH 0/3] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 18 Oct '22

18 Oct '22

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

4 6

[PATCH 0/4] MR1089: win32u/font: Add font links for MS Gothic, MingLiU, Microsoft JhengHei.
by Ziqing Hui (＠zhui) 18 Oct '22

18 Oct '22

More font links are added to avoid issues related to missing font links. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1089

3 5

[PATCH v6 0/1] MR1011: user32: Correctly detect and assign an int resource
by Alistair Leslie-Hughes (＠alesliehughes) 18 Oct '22

18 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53646 Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v6: user.exe: Pass resource ID as a string in DIALOG_CreateControls16. https://gitlab.winehq.org/wine/wine/-/merge_requests/1011

3 3

[PATCH v4 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 18 Oct '22

18 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v4: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). d3dx9: Implement d3dx_effect_SetRawValue https://gitlab.winehq.org/wine/wine/-/merge_requests/979

4 26

[PATCH v2 0/5] MR1087: opengl32: Introduce the unixlib interface.
by Rémi Bernon (＠rbernon) 18 Oct '22

18 Oct '22

-- v2: opengl32: Use the unixlib interface for WGL functions. opengl32: Use the unixlib interface for EXT functions. opengl32: Move the null functions to unix_thunks.c. opengl32: Use the unixlib for glGet(String|Integerv). opengl32: Create a unixlib interface for GL functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1087

2 6

Re: [PATCH v5 0/1] MR1011: user32: Correctly detect and assign an int resource - approved
by Jacek Caban (＠jacek) 18 Oct '22

18 Oct '22

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1011

1 0

[PATCH 0/4] MR1084: comctl32/tests: Ignore WM_NCPAINT when testing WM_THEMECHANGED for updown control.
by Zhiyi Zhang (＠zhiyi) 18 Oct '22

18 Oct '22

Fix a possible test failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1084

4 6

[PATCH 0/1] MR1083: hhctrl.ocx: Fix toolbar icons order
by Stanislav Motylkov (＠binarymaster) 18 Oct '22

18 Oct '22

In `hhtoolbar.bmp` the "Expand" icon comes first, then "Collapse". ![](https://gitlab.winehq.org/wine/wine/-/raw/master/dlls/hhctrl.ocx/hhtoolbar.bmp) External issue link in ReactOS Jira: [CORE-12198](https://jira.reactos.org/browse/CORE-12198) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1083

4 3

[PATCH v10 0/7] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 18 Oct '22

18 Oct '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v10: win32u: Read mode from the registry if GetCurrentDisplaySettings fails. win32u: Write display settings to the registry in apply_display_settings. win32u: Lock display devices while applying display settings. win32u: Use an internal WINE_DM_PRIMARY_DEVICE flag on primary adapter modes. win32u: Remove the device name parameter from GetCurrentDisplaySettings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Add a BOOL force parameter to update_display_cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

4 15

[PATCH v6 0/5] MR1080: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 18 Oct '22

18 Oct '22

With this commit the following functions were implemented: - _mbsupr_s_l - converts multibyte string to uppercase, by using specified locale that's passed in. - _mbslwr_s_l - converts multibyte string to lowercase, by using specified locale that's passed in. - _mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. - _mbctoupper_l - converts multibyte lowercase character to uppercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strupr-s-… After applying the patch the crash of the ChessBase application was fixed. More information: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v6: fix: reintroduce _mbsupr_s_l and _mbctolower_l in msvcr100.spec Revert "fix: temporarly remove new tests" https://gitlab.winehq.org/wine/wine/-/merge_requests/1080

2 5

2025

2024

2023

2022

wine-gitlab