- wine-gitlab - winehq.org

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

On Tue Nov 15 20:30:58 2022 +0000, Zebediah Figura wrote: > Similarly to the earlier question about IWMSyncReader locking, do we > need to drop the CS here? Because this is a blocking call, which can call application callbacks, or otherwise also blocking until there's a sample ready. We want to be able to deliver samples from the callback thread, on other streams, without being blocked and without blocking the reader. There's no point in making all this asynchronous otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15902

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

On Tue Nov 15 20:30:59 2022 +0000, Zebediah Figura wrote: > Missed this the first time, but: I'd make this an ERR, personally. (An > application can trigger it, but it's one of those cases where it's a > sign that something went catastrophically wrong, and also we're pretty > much guessing how to handle it if not.) The most common case where this happens is on EOS, I don't think we want to print error. When streams are deselected this would happen as well if it interrupts the wait on buffer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15903

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

On Tue Nov 15 20:30:59 2022 +0000, Zebediah Figura wrote: > What's the point of this? We never check the return code of > async_reader_get_next_sample(), only whether it FAILED(). No, it's checked outside of the loop to see if all streams have received EOS (in which case `hr == NS_E_NO_MORE_SAMPLES`), or if there's still some streams with pending requests or pending samples to deliver (`hr == E_PENDING`). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15904

1 0

Re: [PATCH v2 0/1] MR1344: d3d11/tests: Introduce a clear_uav() helper. - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1344

1 0

Re: [PATCH v3 0/1] MR1370: d2d1: Silently ignore non-default state block implementations. - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1370

1 0

Re: [PATCH v2 0/1] MR1369: d3dx9: Add missing path conversion call in D3DXLoadVolumeFromFileA(). - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1369

1 0

Re: [PATCH v2 0/7] MR1372: Import OpenLDAP client libraries and use them in wldap32 - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1372

1 0

Re: [PATCH v2 0/1] MR1350: comctl32: Fix memory leak on error path in EDIT_MakeUndoFit. - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1350

1 0

Re: [PATCH v2 0/1] MR1366: winspool.drv: Ignore input in DocumentPropertiesA unless DM_IN_BUFFER is passed. - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1366

1 0

Re: [PATCH v2 0/1] MR1368: vbscript: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) 15 Nov '22

15 Nov '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1368

1 0

2025

2024

2023

2022

wine-gitlab