- wine-gitlab - winehq.org

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > + > + LeaveCriticalSection(&reader->callback_cs); > + hr = IWMSyncReader2_GetNextSample(reader->reader, stream->number, > + &sample->buffer, &sample->pts, &sample->duration, > + &sample->flags, &sample->output, &sample->stream); > + EnterCriticalSection(&reader->callback_cs); > + } > + > + if (SUCCEEDED(stream->read_result = hr)) > + { > + TRACE("Got stream %u buffer with pts %I64d.\n", stream->number, sample->pts); > + stream->next_sample = sample; > + } > + else > + { > + WARN("Failed to get stream %u sample, hr %#lx.\n", stream->number, stream->read_result); Missed this the first time, but: I'd make this an ERR, personally. (An application can trigger it, but it's one of those cases where it's a sign that something went catastrophically wrong, and also we're pretty much guessing how to handle it if not.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15865

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > } > > if (!first_sample) > - return NS_E_NO_MORE_SAMPLES; > + return pending ? E_PENDING : NS_E_NO_MORE_SAMPLES; What's the point of this? We never check the return code of async_reader_get_next_sample(), only whether it FAILED(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15866

1 0

Re: [PATCH v3 0/4] MR1311: wmvcore: Implement DedicatedDeliveryThread async reader output setting.
by Zebediah Figura (＠zfigura) 15 Nov '22

15 Nov '22

Zebediah Figura (@zfigura) commented about dlls/wmvcore/async_reader.c: > + continue; > + } > + > + while (stream->read_requested) > + { > + stream->read_requested = false; > + > + if (sample->buffer) > + INSSBuffer_Release(sample->buffer); > + sample->buffer = NULL; > + > + LeaveCriticalSection(&reader->callback_cs); > + hr = IWMSyncReader2_GetNextSample(reader->reader, stream->number, > + &sample->buffer, &sample->pts, &sample->duration, > + &sample->flags, &sample->output, &sample->stream); > + EnterCriticalSection(&reader->callback_cs); Similarly to the earlier question about IWMSyncReader locking, do we need to drop the CS here? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1311#note_15864

1 0

[PATCH v2 0/4] MR1355: opengl32: Implement wow64 thunk for several unix entry points.
by Rémi Bernon (＠rbernon) 15 Nov '22

15 Nov '22

-- v2: opengl32: Implement wow64 thunk for wglMakeCurrent (et al.). opengl32: Implement wow64 thunk for wglGetProcAddress. opengl32: Manually write glPathGlyphIndexRangeNV wow64 thunk. opengl32: Generate wow64 thunks. https://gitlab.winehq.org/wine/wine/-/merge_requests/1355

3 6

[PATCH 0/1] MR1369: d3dx9: Add missing path conversion call in D3DXLoadVolumeFromFileA().
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1369

3 3

[PATCH 0/1] MR1351: d3dx9_36/tests: Use standard C functions for memory allocation in mesh.c.
by Alex Henrie (＠alexhenrie) 15 Nov '22

15 Nov '22

The big win here is getting rid of the reimplementation of strdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1351

3 2

[PATCH v2 0/1] MR1370: d2d1: Silently ignore non-default state block implementations.
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53915 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d2d1: Silently ignore non-default state block implementations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1370

3 3

[PATCH 0/1] MR1370: d2d1: Silently ignore non-default state block implementations.
by Nikolay Sivov (＠nsivov) 15 Nov '22

15 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53915 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1370

4 3

[PATCH 0/1] MR1350: comctl32: Fix memory leak on error path in EDIT_MakeUndoFit.
by Alex Henrie (＠alexhenrie) 15 Nov '22

15 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1350

4 3

[PATCH v4 0/1] MR1334: xmllite/writer: Handle surrogate pairs
by David Kahurani (＠kahurani) 15 Nov '22

15 Nov '22

Surrogates have to be written in pairs. Also, handle related errors Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v4: xmllite/writer: Handle surrogate pairs https://gitlab.winehq.org/wine/wine/-/merge_requests/1334

4 5

2025

2024

2023

2022

wine-gitlab