1. Tests show that overloaded functions that accept COM objects should be sorted before functions
of the same name that accept primitives. For example, the first method of IDCompositionVisual should
be SetOffsetXAnimation() instead of SetOffsetX().
2. Method names for IDCompositionRotateTransform3D are wrong due to a copy paste error.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8370
--
v2: winewayland: Remove now unnecessary context sync.
winemac: Remove now unnecessary context sync.
wineandroid: Remove now unnecessary context sync.
win32u: Track and update opengl drawables in the contexts.
win32u: Keep a reference to the pbuffer drawables in the DCs.
win32u: Keep a reference to the GL drawables in the windows.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8369
Across the codebase there are several test cases where the arguments to ok()
is not safe to evaluate unless the test case fails.
For example:
ok(i == ARRAY_SIZE(array), "i is too small: %d\n", array[i]);
Only when the test fails (i.e. i < ARRAY_SIZE(array)), is array[i] safe to
evaluate.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58320
* * *
The other option is to fix all such cases in the test suite, and add some documentation to make it clear arguments to `ok()` are _always_ evaluated. I don't know which one is better.
--
v5: include: Don't evaluate format arguments to ok() unless we need them.
include: Shut the compiler up about PDNS_RECORD array bounds.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8360
On Thu Jun 19 02:07:03 2025 +0000, Yuxuan Shui wrote:
> And for some reason build-linux doesn't want to pick up my new commit...
> Let me try force pushing it again.
?? build-linux just ignores the tip of this branch, does it not like me bad mouthing the compiler?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8360#note_107160
Across the codebase there are several test cases where the arguments to ok()
is not safe to evaluate unless the test case fails.
For example:
ok(i == ARRAY_SIZE(array), "i is too small: %d\n", array[i]);
Only when the test fails (i.e. i < ARRAY_SIZE(array)), is array[i] safe to
evaluate.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58320
* * *
The other option is to fix all such cases in the test suite, and add some documentation to make it clear arguments to `ok()` are _always_ evaluated. I don't know which one is better.
--
v2: include: Shut the compiler up about PDNS_RECORD array bounds.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8360
Across the codebase there are several test cases where the arguments to ok()
is not safe to evaluate unless the test case fails.
For example:
ok(i == ARRAY_SIZE(array), "i is too small: %d\n", array[i]);
Only when the test fails (i.e. i < ARRAY_SIZE(array)), is array[i] safe to
evaluate.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58320
* * *
The other option is to fix all such cases in the test suite, and add some documentation to make it clear arguments to `ok()` are _always_ evaluated. I don't know which one is better.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8360