On Fri Jul 18 09:47:15 2025 +0000, Paul Gofman wrote:
> @giomasce
> Looks like this MR introduced various test failures in
> dsound/tests/capture.c and mmdevapi/tests/capture.c (see, e. g.,
> https://gitlab.winehq.org/wine/wine/-/jobs/174369). I am reproducing
> those locally. Commit 00211db0d08d60ee9a0e40206bf7cf9b5b88987b
> (functional change) triggered failures in dsound test (reverting that
> fixes the failures). The failures in mmdevapi are in newly added test_formats().
Thanks. The failures in `mmdevapi/tests/capture.c` are just a missing `todo`, so they're easy to deal with. But I also introduced crashes in `mmdevapi/tests/spatialaudio.c`, which is what I am investigating now. Apparently everybody used the flexibility that the audio renderer offered before. Sorry for not noticing that before.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8559#note_110286
if errorlevel is a >= comparison; if errorlevel 0 always succeeds and is meaningless.
Also fix the find command; the copy tests were actually failing, but failures were masked by the errorlevel thing. This commit is the same as in !8588, it's needed by both.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8589
@alexhenrie @zhiyi
Description:
When flags does not include DT_CALCRECT, since len is calculated in the middle,
it will be reduced to zero. Resulting in the length of the processed string that
is finally returned to zero and the non-processing string length is unchanged.
But some application taking the non-processing string length to zero as the loop
end condition.
The test case's merge request number is 8177.
Signed-off-by: chenjiangyi <chenjiangyi(a)uniontech.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8178
comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
LButtonDown should return when the treeview handle is invalid (e.g. destroyed) after NM_CLICK to prevent further message processing.
Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58211
--
v10: comctl32/treeview: Return from TREEVIEW_LButtonDown when the treeview handle is invalid.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8258