On Mon Aug 1 21:34:19 2022 +0000, Tobias G��rgens wrote:
> I'll slowly add/improve commits after the test results are available, I
> don't want to delete every commit again lol
> Is there any way to manually trigger the test bot?
the pipeline fails due to an unrelated issue in another dll.
They have a function with the same name, DllGetVersion.
Could it be that the dev defined it in shlwapi.h?
The issue is that I can't declare my function correctly with this definition (probably the reason why the first implementation used it, wrongly).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5462
On Mon Aug 1 19:43:52 2022 +0000, Bernhard K��lbl wrote:
> Tests cannot fail in their own commit. You need to denote stuff, that's
> going to be implemented with todo_wine, which expects a failure. Then
> the commit message for tests needs to be cabinet/tests:
I'll slowly add/improve commits after the test results are available, I don't want to delete every commit again lol
Is there any way to manually trigger the test bot?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5461
Before https://gitlab.winehq.org/wine/wine/-/merge_requests/140, and to avoid a situation in the future where we might decide to implement this, and where the callback would be called asynchronously as they are supposed to, without the ASF reader filter supporting it.
--
v2: winegstreamer: Make IWMReader state transitions asynchronous.
winegstreamer: Move IWMReaderCallbackAdvanced *callback_advanced to a local variable.
wmvcore/tests: Add more IWMReader_(Open|Start|Stop|Close) async checks.
https://gitlab.winehq.org/wine/wine/-/merge_requests/393
Fix stub DllGetVersion implementation to read Dll version
and put it in correct structure.
Implement GetDllVersion by using DllGetVersion function
and return version
--
v6: cabinet: Implement GetDllVersion
https://gitlab.winehq.org/wine/wine/-/merge_requests/564
This doesn't implement the listeners (needs wine-gecko notification). Also "media" seems to return somewhat different strings on gecko in some cases, so some of the tests are todo_wine because of that, but I'm not sure if it's worth replicating in practice.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/568
In preparation for moving display placement to win32u, for https://gitlab.winehq.org/wine/wine/-/merge_requests/551.
The idea for win32u to enumerate and work with full modes, with driver extra data, to do the display placement logic and validation, and pass the modes array for all adapters at once to the driver to apply them.
--
v3: winex11.drv: Constify set_current_mode DEVMODEW parameter.
winex11.drv: Iterate display settings using dmDriverExtra.
winex11.drv: Use DEVMODEW instead of x11drv_display_setting.
winex11.drv: Update devmode dmPosition instead of new_rect.
winex11.drv: Use DM_POSITION field bit to mark placed displays.
winex11.drv: Use a local desired_rect variable when placing displays.
https://gitlab.winehq.org/wine/wine/-/merge_requests/561