- wine-gitlab - winehq.org

[PATCH v2 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- v2: winex11: Serialize fullscreen/maximized and config changes. winex11: Trace more window change request serials. https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH 0/2] MR8079: winex11: Serialize fullscreen/maximized and config changes.
by Rémi Bernon (＠rbernon) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8079

2 2

[PATCH v6 0/1] MR8017: wined3d: Swap wined3d_resource.heap_pointer on swapchain present.
by Panayiotis Talianos (＠panintended) 19 May '25

19 May '25

wined3d_resource_free_sysmem() uses wined3d_resource.heap_pointer to deallocate wined3d_resource.heap_memory. Preserve pairing of heap_pointer/heap_memory to prevent deallocation of incorrect heap_memory. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57387 -- v6: wined3d: Swap wined3d_resource.heap_pointer on swapchain present. https://gitlab.winehq.org/wine/wine/-/merge_requests/8017

3 3

[PATCH 0/5] MR7973: wined3d: Move FFP extra states away from STATE_RENDER, part 4/4.
by Elizabeth Figura (＠zfigura) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/7973

3 6

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:50:06 2025 +0000, Zhiyi Zhang wrote: > I will fix this. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8078 should fix it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103801

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 08:23:31 2025 +0000, Nikolay Sivov wrote: > I don't think this works, see [1]. You're freeing the same thing using > two separate counters. My guess is that weak reference has to be a > separate object, main object would keep a regular reference to it, once > main thing is released it would clear itself from weak ref object. That > will be an indication to fail Resolve(). I doesn't seem necessary to > have multiple weak reference objects, that simplifies things. > [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… I will fix this. Thanks for spotting this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103799

1 0

Re: [PATCH v2 0/2] MR8053: windows.ui: Implement IWeakReferenceSource for IUISettings.
by Nikolay Sivov (＠nsivov) 19 May '25

19 May '25

Nikolay Sivov (@nsivov) commented about dlls/windows.ui/uisettings.c: > IUISettings3 IUISettings3_iface; > IUISettings4 IUISettings4_iface; > IUISettings5 IUISettings5_iface; > - LONG ref; > + IWeakReferenceSource IWeakReferenceSource_iface; > + IWeakReference IWeakReference_iface; > + LONG ref_strong; > + LONG ref_weak; > }; I don't think this works, see [1]. You're freeing the same thing using two separate counters. My guess is that weak reference has to be a separate object, main object would keep a regular reference to it, once main thing is released it would clear itself from weak ref object. That will be an indication to fail Resolve(). I doesn't seem necessary to have multiple weak reference objects, that simplifies things. [1] https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-05-06_wine-10.… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8053#note_103796

1 0

Re: [PATCH v45 0/2] MR7843: cmd: Implement tab completion for command line entry.
by Joe Souza (＠JoeS209) 19 May '25

19 May '25

Latest changes pushed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7843#note_103790

1 0

Re: [PATCH v2 0/1] MR8060: include: Add ID3D11FunctionLinkingGraph.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

On Mon May 19 00:58:42 2025 +0000, Zhiyi Zhang wrote: > I will send a fix. Thanks for spotting this. https://gitlab.winehq.org/wine/wine/-/merge_requests/8074 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8060#note_103774

1 0

[PATCH 0/1] MR8074: include: Avoid a C++ keyword.
by Zhiyi Zhang (＠zhiyi) 19 May '25

19 May '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8074

2 1

2025

2024

2023

2022

wine-gitlab