- wine-gitlab - winehq.org

[PATCH 0/1] MR9459: winevulkan: Update to VK spec version 1.4.333.
by Georg Lehmann (＠DadSchoorse) 14 Nov '25

14 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9459

3 2

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Alexandre Julliard (＠julliard) 14 Nov '25

14 Nov '25

> Wine and forks only use them through getenv imported from <stdlib.h>, so it shouldn't matter whether they are in the Windows environment if I'm correct. Yes, the issue would be Windows apps that use a PE build of SDL. I don't know if there are variables that would translate meaningfully across Unix and Windows environments. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_122011

1 0

[PATCH 0/5] MR9457: comctl32/toolbar: Add a helper to draw the separator.
by Zhiyi Zhang (＠zhiyi) 14 Nov '25

14 Nov '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9457

3 6

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Martino Fontana (＠tinozzo123) 14 Nov '25

14 Nov '25

> Sure, how about something like MR !9461? Yes. (Only nitpick is that there should be more comments explaining the why.) > Any other variables we should add there? Nothing comes to mind. More can always be added later. > Should we ignore all the SDL_ variables? Wine and forks only use them through `getenv` imported from `<stdlib.h>`, so it shouldn't matter whether they are in the Windows environment if I'm correct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_122009

1 0

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Alexandre Julliard (＠julliard) 14 Nov '25

14 Nov '25

Sure, how about something like MR !9461? Any other variables we should add there? Should we ignore all the SDL_ variables? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_122004

1 0

[PATCH v6 0/4] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 14 Nov '25

14 Nov '25

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v6: shlwapi: fixup leading and trailing typos in UrlFixupW shlwapi: check for colon in UrlFixupW kernelbase: Restructure UrlFixupW() shlwapi/tests: Add tests for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

3 11

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Martino Fontana (＠tinozzo123) 14 Nov '25

14 Nov '25

So, a deny list? Sounds fine to me. (`QT_PLUGIN_PATH` as well.) Though, what about the reversion of d4920360bffddaa5923a8da0b15f3ad9a2a97e78? (Regardless of the deny list.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_122002

1 0

[PATCH v3 0/1] MR7479: wow64win: fix the access exception when the lparam is an address larger than 2G.
by Jiajin Cui (＠jin-king1) 14 Nov '25

14 Nov '25

Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- v3: wow64win: change parameter types from LONG to ULONG in wow64_NtUserMessageCall https://gitlab.winehq.org/wine/wine/-/merge_requests/7479

3 6

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Alexandre Julliard (＠julliard) 14 Nov '25

14 Nov '25

> Importing something is better than nothing, and this achieves the goal of keeping popular configuration envars like DXVK_FRAME_RATE. IMO, it is absolutely worth the code bloat. Code bloat is not an issue, I'm more concerned about the unpredictability of which variables will be removed. Maybe now that we have b1e94119f07919991edb1e629090b04e7e8b34a9 we could be more aggressive in removing unneeded vars. For instance it's very unlikely that NIXPKGS variables would be needed by a Windows app. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_121997

1 0

Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
by Martino Fontana (＠tinozzo123) 14 Nov '25

14 Nov '25

As the release approaches, I remain concerned about the breaking changes. I use configuration envars much more frequently than the EA App, meaning this change would require me to apply workarounds everywhere (including the EA App itself) rather than just for one application. This increases the manual intervention burden significantly for users like me. Plus, that EA itself is disincentivizing the use EA App their push of anti-Linux anticheats, so the percentage of users with a big envar block that don't use the EA App is likely substantial. The previous discussion established that [Wine doesn't do breaking changes or workarounds](https://gitlab.winehq.org/wine/wine/-/merge_requests/6140#note…. While other solutions could be explored longer-term, for now it would be best if the next Wine release ships without this breaking change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9423#note_121996

1 0

2025

2024

2023

2022

wine-gitlab