This MR does:
- improve startup time when loading a large PDB file
(a chromium based PDB file (larger than 4G) now loads in 3,5s)
(at the begining of this rewrite, loading the very same PDB file
ended with a reboot triggered by the Linux OOM after 30 minutes
of heavy swap)
- finally untie the new PDB backend for the old one (they are now
considered as two independant debug formats, so that we can
eventually drop the old one at some point)
--
v2: dbghelp: Let new PDB reader …
[View More]exist independantly of the old one.
dbghelp: Rename declarations for old PBD backend.
dbghelp: Simplify signature of PDB unwinders.
dbghelp: Get fpo stream information directly in new PDB reader.
dbghelp: Speed up global symbols at startup.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8225
[View Less]
getItemAndInstanceFromTable only checks if the table is NULL, but didn't check
if it actually contains any entries. It just assumes it does and will return
index 1 in some cases, resulting in out-of-bound access of the table down the
line.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8230
If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working.
--
v4: comdlg32: Don't use a shadow devmode structure in PrintDlgA.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA.
comdlg32: Don't use a shadow devmode structure in …
[View More]PrintDlgW.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8220
[View Less]
please amend the tests in the `---------- Testing copy part` (after line 3387 in test_builtins.cmd), the tests you've amended are meant to test the return codes, not really the final behavior)
and likely all these tests up to the ascii/binary part should be amended to check whether the names are printed or not
if needed, you can work around builtin find.exe missing the /c switch by using
```
:count_lines
@set "lines=0"
@for /F %%a in (%1) do set /A lines+=1
@exit /b %lines%
```
using `call :…
[View More]count_lines <file>` and you'll get the number of lines in %errorlevel% variable (but IMO in most of the cases testing for a file name printed should serve the same purpose)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8200#note_105647
[View Less]
If the "Properties" button is clicked in the printdlg it opens the print properties dlg. The problem is the values set in the properties dlg don't get passed through correctly to the final printing stage. This prevents properties like duplex and page size from working.
--
v3: comdlg32: Don't use a shadow devmode structure in PrintDlgA.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgA.
comdlg32: Don't use a shadow devmode structure in …
[View More]PrintDlgW.
comdlg32/tests: Add tests for changing devmode properties in the hook procedure for PrintDlgW.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8220
[View Less]
--
v2: widl: Add rows for the requires keyword.
widl: Add rows for the exclusiveto attribute.
widl: Add rows for the uuid attribute.
widl: Add rows for the interface type.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8222