- wine-gitlab - winehq.org

[PATCH v7 0/5] MR9293: Reparse points, part 1.
by Elizabeth Figura (＠zfigura) 10 Nov '25

10 Nov '25

As prescribed some time ago, this attempts to implement correct reparse behaviour simply without attempting at all to make reparse points resolvable Unix symlinks. A reparse point consists two files. For a file whose NT name is "foobar", the contents of the file or directory (and note that a reparse point *can* have arbitrary contents) is stored in a file or directory "foobar?". The contents of the reparse point are stored in a file "foobar*". Both * and ? are valid in POSIX filenames but not NT, so no collision should be possible. The actual file "foobar" does not exist in this case. This is to allow the case where there are no reparse points (which is most common) to work as it currently does, without any extra overhead to check for a reparse point. [Simply guarding this behind FILE_OPEN_REPARSE_POINT does not seem good enough to me; that flag is used for example by many builtin functions like MoveFile().] When failing to locate a path segment "foobar", we check for "foobar*" and attempt to parse and resolve that reparse point. Issues: (1) Since we are manipulating two files, are there any race conditions? I believe there are no meaningful races. Read/write races: - When setting a reparse point, we move the contents file out of the way last, so attempts to open the file before that will see a normal file. Attempts to read the reparse point might see a partial file, but we treat that as failure. - When removing a reparse point from a file, we move the contents file back first, so attempts to open or read will see a normal file. - When deleting a reparse point entirely, we delete the contents first, so attempts to open the file will see neither a normal file nor the contents of the symlink, and fail. Attempts to query attributes don't need to open the contents, only the data, which will either be present or not. Write/write races: - Races involving file deletion don't matter, because deletion doesn't take effect until all handles to an inode are closed. - If we try to simultaneously set the reparse point from two different threads, one will fail with no effect since we create the reparse data file with O_EXCL. - If we try to remove the reparse point while setting it, the contents won't be in the right place and we'll fail. - If we try to remove the reparse point from two different threads, one will fail to move the contents back or delete them. (2) How does this interact with hard links? Creating a hard link to an existing reparse point is not too hard to do; we can just hard link both the data file and the contents file. However, turning an existing hardlinked file into a reparse point cannot work. This is also a limitation of other approaches that have been proposed. For this reason I've elected to forbid hard link interaction for now. One alternative approach that would allow turning hardlinked files into reparse points would be to store the reparse data in xattr. This would be less portable though. -- v7: ntdll: Resolve IO_REPARSE_TAG_MOUNT_POINT during path lookup. ntdll: Pass attr and nt_name down to lookup_unix_name(). server: Implement FSCTL_GET_REPARSE_POINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/9293

2 6

Re: [PATCH v5 0/5] MR9355: windows.perception.stub: Implement IHolographicSpace_get_PrimaryAdapterId(). - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9355

1 0

Re: [PATCH v4 0/6] MR9403: vccorlib140: Implement stringification functions. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9403

1 0

Re: [PATCH v2 0/4] MR9416: msado15: Fields initialization improvements. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9416

1 0

Re: [PATCH v2 0/5] MR9409: comctl32/progress: Add a helper to get the draw procedures. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9409

1 0

Re: [PATCH v2 0/6] MR9412: winex11: Flush requests in cursor and IME functions. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9412

1 0

Re: [PATCH v2 0/2] MR9411: win32u: Don't forcefully activate windows before restoring them. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9411

1 0

Re: [PATCH v2 0/2] MR9413: d2d1/effect: Add a separate factory functions for builtin effects. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9413

1 0

Re: [PATCH v2 0/1] MR9407: d2d1/tests: Add some tests for creating shared bitmaps from IWICBitmapLock. - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9407

1 0

Re: [PATCH v6 0/1] MR8988: win32u: change the stretch mode of dst hdc from BlackOnWhite to ColorOnColor... - approved
by Alexandre Julliard (＠julliard) 10 Nov '25

10 Nov '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8988

1 0

2025

2024

2023

2022

wine-gitlab