- wine-gitlab - winehq.org

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) 14 Jul '25

14 Jul '25

On Mon Jul 14 18:05:00 2025 +0000, Vibhav Pant wrote: > On Clang, it results in this error for x86_64: > ``` > ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type > 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat] > 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu > >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); > ``` > for i686: > ``` > ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type > 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat] > 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu > >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); > ``` That's capital I, not lowercase l. I cannot imagine what on earth possessed gitlab to use a sans-serif font by default. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109815

1 0

[PATCH 0/1] MR8565: d3dx10/tests: Add a test for effect compiler behavior.
by Nikolay Sivov (＠nsivov) 14 Jul '25

14 Jul '25

This most likely means d3dx10_N. should be using corresponding d3dcompiler_N.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8565

2 1

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) 14 Jul '25

14 Jul '25

On Mon Jul 14 17:58:45 2025 +0000, Elizabeth Figura wrote: > Personally I feel that writing a constant in an error message is > redundant. You already know what the expected value is by looking at the > test; it doesn't help to print it in the terminal. Fair, I just wanted to keep the same test style as the rest of the code in `test_device_property`, which seems to use this format as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109813

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Vibhav Pant (＠vibhavp) 14 Jul '25

14 Jul '25

On Mon Jul 14 17:59:28 2025 +0000, Elizabeth Figura wrote: > You can use %Iu for sizeof. On Clang, it results in this error for x86_64: ``` ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned long long' [-Werror,-Wformat] 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); ``` for i686: ``` ../dlls/setupapi/tests/devinst.c:1392:86: error: format specifies type 'unsigned long' but the argument has type 'unsigned int' [-Werror,-Wformat] 1392 | ok(keys_len >= ARRAY_SIZE(expected_keys), "Expected %lu >= %lu\n", keys_len, ARRAY_SIZE(expected_keys)); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109812

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) 14 Jul '25

14 Jul '25

On Mon Jul 14 17:59:28 2025 +0000, Connor McAdams wrote: > Ah, nevermind then. :) You can use %Iu for sizeof. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109811

1 0

Re: [PATCH v14 0/3] MR8515: setupapi: Support in-built properties for device instances in SetupDiGetDevicePropertyW.
by Elizabeth Figura (＠zfigura) 14 Jul '25

14 Jul '25

On Fri Jul 11 19:24:00 2025 +0000, Vibhav Pant wrote: > changed this line in [version 10 of the diff](/wine/wine/-/merge_requests/8515/diffs?diff_id=192559&start_sha=b78521e67e02e66a1c214df25354c14c1fd3ed65#5c8e393d12376e8f2a4f2aec734e275204aecb82_1291_1291) Personally I feel that writing a constant in an error message is redundant. You already know what the expected value is by looking at the test; it doesn't help to print it in the terminal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8515#note_109810

1 0

[PATCH v17 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 14 Jul '25

14 Jul '25

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v17: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. propsys: Add stubs for PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 8

[PATCH v16 0/8] MR6892: propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 14 Jul '25

14 Jul '25

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v16: propsys: Implement IPropertyDescription for several known system properties. propsys: Add IPropertyDescription stub for system defined properties. propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. propsys: Add stubs for PSGetNameFromPropertyKey. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

2 10

Re: [PATCH v2 0/1] MR8213: d2d1: Fix out-of-bound array access.
by Yuxuan Shui (＠yshui) 14 Jul '25

14 Jul '25

@nsivov can you have a look? thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8213#note_109801

1 0

[PATCH v2 0/1] MR8163: dmime: Fix use-after-free after performance_CloseDown.
by Yuxuan Shui (＠yshui) 14 Jul '25

14 Jul '25

IDirectMusicPerformance8 holds references to music ports in channel_blocks. These ports must outlive their parent IDirectMusic, because in synth_port_Release, they remove themselves from their parent. performance_CloseDown releases the IDirectMusic, but doesn't release its ports. So when these ports are later released in performance_Release, they uses the already freed IDirectMusic. Found by ASan. stacktrace ([post-processed](https://gitlab.winehq.org/yshui/wine-symbolizer)): ``` 016c:0170:err:asan:asan_report ASan: read of 4 bytes at 00007E1C0BFF8518, caller 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report stacktrace: 016c:0170:err:asan:asan_report 00006FFFFDE2B9C2 (__asan_report_load4, ../dlls/asan_dynamic_thunk/thunk.c:1020,1) 016c:0170:err:asan:asan_report 00006FFFFDE144BC (dmusic_remove_port, ../dlls/dmusic/dmusic.c:312,10) 016c:0170:err:asan:asan_report 00006FFFFDE21A99 (synth_port_Release, ../dlls/dmusic/port.c:129,9) 016c:0170:err:asan:asan_report 00006FFFFE20B88A (channel_block_free, ../dlls/dmime/performance.c:271,28 <- rb_postorder, ../include/wine/rbtree.h:170,46 <- rb_destroy, ../include/wine/rbtree.h:188,19 <- performance_Release, ../dlls/dmime/performance.c:450,5) 016c:0170:err:asan:asan_report 00007FFFFE002FFA (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:972,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report info: 016c:0170:err:asan:asan_report heap-use-after-free, addr 00007E1C0BFF8518 016c:0170:err:asan:asan_report allocated user region: [00007E1C0BFF84F0, 00007E1C0BFF8530) 64 016c:0170:err:asan:asan_report allocated by 19e3 016c:0170:err:asan:asan_report 00006FFFFDE14885 (music_create, ../dlls/dmusic/dmusic.c:587,20) 016c:0170:err:asan:asan_report 00006FFFFDE18853 (ClassFactory_CreateInstance, ../dlls/dmusic/dmusic_main.c:94,9) 016c:0170:err:asan:asan_report 00006FFFFC925ECF (IClassFactory_CreateInstance, include/unknwn.h:245,12 <- CoCreateInstanceEx, ../dlls/combase/combase.c:1890,10) 016c:0170:err:asan:asan_report 00006FFFFC924F61 (CoCreateInstance, ../dlls/combase/combase.c:1679,10) 016c:0170:err:asan:asan_report 00006FFFFE20BE48 (performance_init_dmusic, ../dlls/dmime/performance.c:480,9 <- performance_Init, ../dlls/dmime/performance.c:535,14) 016c:0170:err:asan:asan_report 00006FFFFE211CB9 (performance_InitAudio, ../dlls/dmime/performance.c:1537,9) 016c:0170:err:asan:asan_report 00007FFFFE001949 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:906,10 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:err:asan:asan_report freed by 3390 016c:0170:err:asan:asan_report 00006FFFFDE15DC4 (IDirectMusic8Impl_Release, ../dlls/dmusic/dmusic.c:203,5) 016c:0170:err:asan:asan_report 00006FFFFE21158C (performance_CloseDown, ../dlls/dmime/performance.c:1469,9) 016c:0170:err:asan:asan_report 00007FFFFE002FB7 (test_COM_audiopath, ../dlls/dmime/tests/dmime.c:971,5 <- func_dmime, ../dlls/dmime/tests/dmime.c:5201,5) 016c:0170:err:asan:asan_report 00007FFFFE082CDD (run_test, ../include/wine/test.h:765,5) 016c:0170:err:asan:asan_report 00007FFFFE082598 (main, ../include/wine/test.h:0,0) 016c:0170:err:asan:asan_report 00007FFFFE08C44F (mainCRTStartup, ../dlls/msvcrt/crt_main.c:60,11) 016c:0170:err:asan:asan_report 00006FFFFF9DD502 (BaseThreadInitThunk, ../dlls/kernel32/thread.c:61,24) 016c:0170:err:asan:asan_report 00006FFFFFC4DC3F (longjmp_regs) 016c:0170:trace:module:LdrShutdownProcess () ``` -- v2: dmime: Fix use-after-free after performance_CloseDown. https://gitlab.winehq.org/wine/wine/-/merge_requests/8163

2 2

2025

2024

2023

2022

wine-gitlab