Re: [PATCH v4 0/8] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.

[Gabriel Ivăncescu (＠insn)]

On Mon Nov 27 17:34:03 2023 +0000, Jacek Caban wrote:
> This should really use `!iface_cmp()` to make sure it's not one more
> instance of wrappers that native uses in similar places. However, trying
> to do that crashes on native, which is just one more reason to believe
> that detached documents are broken there and trying too hard to mimic it
> does not make sense. I think that you're misinterpreting some quirks
> that are not really interested in the first place. I suggest to drop
> those tests and just do the right thing: don't send any events on
> detached document, maybe even fail early on an attempt to use such storage.

Yeah. As I said below, I can easily just get rid of the tests and do the right thing with a comment. Silently dropping events sounds like a bad idea to me, it will make it hard to debug if something broken ever depends on it. And it's not like it's more code, either, so better make it correct.