Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ws2_32/tests/sock.c:
> -
>    ok(!memcmp((char[108]){0}, outAddr.sun_path, sizeof(addr.sun_path)),
> -
>        "getsockname returned incorrect path '%s' for provided path '%s'\n",
> -
>        outAddr.sun_path,
> -
>        addr.sun_path);
> -
> -
>    memset(&outAddr, 0, sizeof(outAddr));
> -
>    ret = getsockname(server, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)});
> -
>    ok(!ret, "Could not get info on Unix socket: %lu\n", GetLastError());
> -
>    ok(!memcmp(addr.sun_path, outAddr.sun_path, sizeof(addr.sun_path)),
> -
>        "getsockname returned incorrect path '%s' for provided path '%s'\n",
> -
>        outAddr.sun_path,
> -
>        addr.sun_path);
> -
> -
>    memset(&outAddr, 0, sizeof(outAddr));
> -
>    ret = getpeername(listener, (SOCKADDR *)&outAddr, &(int){sizeof(outAddr)});
> -
>    ok(ret == -1, "Got info on Unix socket: %lu\n", GetLastError());

If we're testing that something returns an error we should test the value of GetLastError() as well.