The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality.
As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWndCreate().
This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality.
From: Alexandros Frantzis alexandros.frantzis@collabora.com
The previous version of the code incorrectly assumed that the lpszClass member of CREATESTRUCT passed with WM_CREATE would point to the same memory used for the CreateWindowEx class name parameter, and used a pointer comparison to check for class name equality.
As a side effect of commit e41c255be6ba66d1eec7affe674b8cc7699226b8 "win32u: Use send_message_timeout for WM_CREATE and WM_NCCREATE" the CREATESTRUCT lpszClass member started pointing to different memory, breaking the current implementation of MCIWndCreate().
This commit fixes the problem by performing a proper, case-insensitive string comparison to determine class name equality.
Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=53578 --- dlls/msvfw32/mciwnd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/msvfw32/mciwnd.c b/dlls/msvfw32/mciwnd.c index 8799293f7c9..3dc8d6f3542 100644 --- a/dlls/msvfw32/mciwnd.c +++ b/dlls/msvfw32/mciwnd.c @@ -314,8 +314,8 @@ static LRESULT MCIWND_Create(HWND hWnd, LPCREATESTRUCTW cs) else lParam = (LPARAM)cs->lpCreateParams;
- /* If it's our internal class pointer, file name is a unicode string */ - if (cs->lpszClass == mciWndClassW) + /* If it's our internal class name, file name is a unicode string */ + if (!lstrcmpiW(cs->lpszClass, mciWndClassW)) SendMessageW(hWnd, MCIWNDM_OPENW, 0, lParam); else {
-
Alexandros Frantzis -
Alexandros Frantzis (＠afrantzis)