On Mon Mar 17 22:03:12 2025 +0000, Alexandre Julliard wrote:
You should add a separate handler just for what the app needs, instead of forcing all handlers to support real-mode pointers. I added an example in 7e3bfd4e5e4f9ca689e1734da05a90b1b14351c9, it seems to work here but it could be extended if necessary.
I see what you mean now about having a separate handler. I still don't understand why it's better to have two implementations of the DOS "get volume serial number" ioctl, a more realistic implementation in [int21.c](https://gitlab.winehq.org/wine/wine/-/blob/6298b0cab2086ae61f46b284d22c420df...) and a less realistic implementation in [int31.c](https://gitlab.winehq.org/wine/wine/-/blob/6298b0cab2086ae61f46b284d22c420df...), or why it's hard to support real-mode pointers (the original [CTX_SEG_OFF_TO_LIN](https://gitlab.winehq.org/wine/wine/-/commit/526b245237b9571beebac8a4653e7dd...) macro seemed to work just fine). But the two-implementation solution works, so my unresolved questions are just curiosities at this point. Thank you very much for taking the time to fix Myst.
-
Alex Henrie (＠alexhenrie)