[PATCH 0/5] MR874: mfmediaengine: Add tests to exhibit inverted video rendering.

[Rémi Bernon (＠rbernon)]

This shows that media session samples are correctly oriented, but that mfmediaengine renders them upside down.

[PATCH 1/5] mf/tests: Factor test grabber callback implementations.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/mf/tests/mf.c | 159 ++++++++++++++++-----------------------------
 1 file changed, 56 insertions(+), 103 deletions(-)

diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c
index 14b75d52fc2..28e62b858d8 100644
--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -2543,8 +2543,18 @@ static void test_media_session_rate_control(void)
     ok(hr == S_OK, "Shutdown failure, hr %#lx.\n", hr);
 }

-static HRESULT WINAPI test_grabber_callback_QueryInterface(IMFSampleGrabberSinkCallback *iface, REFIID riid,
-        void **obj)
+struct test_grabber_callback
+{
+    IMFSampleGrabberSinkCallback IMFSampleGrabberSinkCallback_iface;
+    LONG refcount;
+};
+
+static struct test_grabber_callback *impl_from_IMFSampleGrabberSinkCallback(IMFSampleGrabberSinkCallback *iface)
+{
+    return CONTAINING_RECORD(iface, struct test_grabber_callback, IMFSampleGrabberSinkCallback_iface);
+}
+
+static HRESULT WINAPI test_grabber_callback_QueryInterface(IMFSampleGrabberSinkCallback *iface, REFIID riid, void **obj)
 {
     if (IsEqualIID(riid, &IID_IMFSampleGrabberSinkCallback) ||
             IsEqualIID(riid, &IID_IMFClockStateSink) ||
@@ -2561,36 +2571,42 @@ static HRESULT WINAPI test_grabber_callback_QueryInterface(IMFSampleGrabberSinkC

static ULONG WINAPI test_grabber_callback_AddRef(IMFSampleGrabberSinkCallback *iface)
 {
-    return 2;
+    struct test_grabber_callback *grabber = impl_from_IMFSampleGrabberSinkCallback(iface);
+    return InterlockedIncrement(&grabber->refcount);
 }

static ULONG WINAPI test_grabber_callback_Release(IMFSampleGrabberSinkCallback *iface)
 {
-    return 1;
+    struct test_grabber_callback *grabber = impl_from_IMFSampleGrabberSinkCallback(iface);
+    ULONG refcount = InterlockedDecrement(&grabber->refcount);
+
+    if (!refcount)
+        free(grabber);
+
+    return refcount;
 }

-static HRESULT WINAPI test_grabber_callback_OnClockStart(IMFSampleGrabberSinkCallback *iface, MFTIME systime,
-        LONGLONG offset)
+static HRESULT WINAPI test_grabber_callback_OnClockStart(IMFSampleGrabberSinkCallback *iface, MFTIME time, LONGLONG offset)
 {
     return E_NOTIMPL;
 }

-static HRESULT WINAPI test_grabber_callback_OnClockStop(IMFSampleGrabberSinkCallback *iface, MFTIME systime)
+static HRESULT WINAPI test_grabber_callback_OnClockStop(IMFSampleGrabberSinkCallback *iface, MFTIME time)
 {
     return E_NOTIMPL;
 }

-static HRESULT WINAPI test_grabber_callback_OnClockPause(IMFSampleGrabberSinkCallback *iface, MFTIME systime)
+static HRESULT WINAPI test_grabber_callback_OnClockPause(IMFSampleGrabberSinkCallback *iface, MFTIME time)
 {
     return E_NOTIMPL;
 }

-static HRESULT WINAPI test_grabber_callback_OnClockRestart(IMFSampleGrabberSinkCallback *iface, MFTIME systime)
+static HRESULT WINAPI test_grabber_callback_OnClockRestart(IMFSampleGrabberSinkCallback *iface, MFTIME time)
 {
     return E_NOTIMPL;
 }

-static HRESULT WINAPI test_grabber_callback_OnClockSetRate(IMFSampleGrabberSinkCallback *iface, MFTIME systime, float rate)
+static HRESULT WINAPI test_grabber_callback_OnClockSetRate(IMFSampleGrabberSinkCallback *iface, MFTIME time, float rate)
 {
     return E_NOTIMPL;
 }
@@ -2598,7 +2614,7 @@ static HRESULT WINAPI test_grabber_callback_OnClockSetRate(IMFSampleGrabberSinkC
 static HRESULT WINAPI test_grabber_callback_OnSetPresentationClock(IMFSampleGrabberSinkCallback *iface,
         IMFPresentationClock *clock)
 {
-    return E_NOTIMPL;
+    return S_OK;
 }

static HRESULT WINAPI test_grabber_callback_OnProcessSample(IMFSampleGrabberSinkCallback *iface, REFGUID major_type,
@@ -2609,7 +2625,7 @@ static HRESULT WINAPI test_grabber_callback_OnProcessSample(IMFSampleGrabberSink

static HRESULT WINAPI test_grabber_callback_OnShutdown(IMFSampleGrabberSinkCallback *iface)
 {
-    return E_NOTIMPL;
+    return S_OK;
 }

static const IMFSampleGrabberSinkCallbackVtbl test_grabber_callback_vtbl =
@@ -2627,6 +2643,19 @@ static const IMFSampleGrabberSinkCallbackVtbl test_grabber_callback_vtbl =
     test_grabber_callback_OnShutdown,
 };

+static IMFSampleGrabberSinkCallback *create_test_grabber_callback(void)
+{
+    struct test_grabber_callback *grabber;
+
+    if (!(grabber = calloc(1, sizeof(*grabber))))
+        return NULL;
+
+    grabber->IMFSampleGrabberSinkCallback_iface.lpVtbl = &test_grabber_callback_vtbl;
+    grabber->refcount = 1;
+
+    return &grabber->IMFSampleGrabberSinkCallback_iface;
+}
+
 enum loader_test_flags
 {
     LOADER_EXPECTED_DECODER = 0x1,
@@ -2927,8 +2956,8 @@ static void test_topology_loader(void)
         },
     };

-    IMFSampleGrabberSinkCallback test_grabber_callback = { &test_grabber_callback_vtbl };
     IMFTopologyNode *src_node, *sink_node, *src_node2, *sink_node2, *mft_node;
+    IMFSampleGrabberSinkCallback *grabber_callback = create_test_grabber_callback();
     struct test_stream_sink stream_sink = test_stream_sink;
     IMFMediaType *media_type, *input_type, *output_type;
     IMFTopology *topology, *topology2, *full_topology;
@@ -3013,7 +3042,7 @@ static void test_topology_loader(void)
     hr = IMFMediaType_SetGUID(media_type, &MF_MT_SUBTYPE, &MFAudioFormat_PCM);
     ok(hr == S_OK, "Failed to set attribute, hr %#lx.\n", hr);

-    hr = MFCreateSampleGrabberSinkActivate(media_type, &test_grabber_callback, &sink_activate);
+    hr = MFCreateSampleGrabberSinkActivate(media_type, grabber_callback, &sink_activate);
     ok(hr == S_OK, "Failed to create grabber sink, hr %#lx.\n", hr);

hr = IMFTopologyNode_SetObject(sink_node, (IUnknown *)sink_activate);
@@ -3347,6 +3376,8 @@ todo_wine {

hr = MFShutdown();
     ok(hr == S_OK, "Shutdown failure, hr %#lx.\n", hr);
+
+    IMFSampleGrabberSinkCallback_Release(grabber_callback);
 }

static void test_topology_loader_evr(void)
@@ -3932,92 +3963,9 @@ static void test_presentation_clock(void)
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
 }

-static HRESULT WINAPI grabber_callback_QueryInterface(IMFSampleGrabberSinkCallback *iface, REFIID riid, void **obj)
-{
-    if (IsEqualIID(riid, &IID_IMFSampleGrabberSinkCallback) ||
-            IsEqualIID(riid, &IID_IMFClockStateSink) ||
-            IsEqualIID(riid, &IID_IUnknown))
-    {
-        *obj = iface;
-        IMFSampleGrabberSinkCallback_AddRef(iface);
-        return S_OK;
-    }
-
-    *obj = NULL;
-    return E_NOINTERFACE;
-}
-
-static ULONG WINAPI grabber_callback_AddRef(IMFSampleGrabberSinkCallback *iface)
-{
-    return 2;
-}
-
-static ULONG WINAPI grabber_callback_Release(IMFSampleGrabberSinkCallback *iface)
-{
-    return 1;
-}
-
-static HRESULT WINAPI grabber_callback_OnClockStart(IMFSampleGrabberSinkCallback *iface, MFTIME time, LONGLONG offset)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnClockStop(IMFSampleGrabberSinkCallback *iface, MFTIME time)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnClockPause(IMFSampleGrabberSinkCallback *iface, MFTIME time)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnClockRestart(IMFSampleGrabberSinkCallback *iface, MFTIME time)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnClockSetRate(IMFSampleGrabberSinkCallback *iface, MFTIME time, float rate)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnSetPresentationClock(IMFSampleGrabberSinkCallback *iface,
-        IMFPresentationClock *clock)
-{
-    return S_OK;
-}
-
-static HRESULT WINAPI grabber_callback_OnProcessSample(IMFSampleGrabberSinkCallback *iface, REFGUID major_type,
-        DWORD sample_flags, LONGLONG sample_time, LONGLONG sample_duration, const BYTE *buffer, DWORD sample_size)
-{
-    return E_NOTIMPL;
-}
-
-static HRESULT WINAPI grabber_callback_OnShutdown(IMFSampleGrabberSinkCallback *iface)
-{
-    return S_OK;
-}
-
-static const IMFSampleGrabberSinkCallbackVtbl grabber_callback_vtbl =
-{
-    grabber_callback_QueryInterface,
-    grabber_callback_AddRef,
-    grabber_callback_Release,
-    grabber_callback_OnClockStart,
-    grabber_callback_OnClockStop,
-    grabber_callback_OnClockPause,
-    grabber_callback_OnClockRestart,
-    grabber_callback_OnClockSetRate,
-    grabber_callback_OnSetPresentationClock,
-    grabber_callback_OnProcessSample,
-    grabber_callback_OnShutdown,
-};
-
-static IMFSampleGrabberSinkCallback grabber_callback = { &grabber_callback_vtbl };
-
 static void test_sample_grabber(void)
 {
+    IMFSampleGrabberSinkCallback *grabber_callback = create_test_grabber_callback();
     IMFMediaType *media_type, *media_type2, *media_type3;
     IMFMediaTypeHandler *handler, *handler2;
     IMFPresentationTimeSource *time_source;
@@ -4044,7 +3992,7 @@ static void test_sample_grabber(void)
     hr = MFCreateSampleGrabberSinkActivate(NULL, NULL, &activate);
     ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr);

-    hr = MFCreateSampleGrabberSinkActivate(NULL, &grabber_callback, &activate);
+    hr = MFCreateSampleGrabberSinkActivate(NULL, grabber_callback, &activate);
     ok(hr == E_POINTER, "Unexpected hr %#lx.\n", hr);

hr = IMFMediaType_SetGUID(media_type, &MF_MT_MAJOR_TYPE, &MFMediaType_Audio);
@@ -4053,7 +4001,7 @@ static void test_sample_grabber(void)
     ok(hr == S_OK, "Failed to set attribute, hr %#lx.\n", hr);

EXPECT_REF(media_type, 1);
-    hr = MFCreateSampleGrabberSinkActivate(media_type, &grabber_callback, &activate);
+    hr = MFCreateSampleGrabberSinkActivate(media_type, grabber_callback, &activate);
     ok(hr == S_OK, "Failed to create grabber activate, hr %#lx.\n", hr);
     EXPECT_REF(media_type, 2);

@@ -4411,7 +4359,7 @@ static void test_sample_grabber(void)
     hr = IMFMediaType_SetGUID(media_type, &MF_MT_SUBTYPE, &MFAudioFormat_PCM);
     ok(hr == S_OK, "Failed to set attribute, hr %#lx.\n", hr);

-    hr = MFCreateSampleGrabberSinkActivate(media_type, &grabber_callback, &activate);
+    hr = MFCreateSampleGrabberSinkActivate(media_type, grabber_callback, &activate);
     ok(hr == S_OK, "Failed to create grabber activate, hr %#lx.\n", hr);

hr = IMFActivate_SetUINT32(activate, &MF_SAMPLEGRABBERSINK_IGNORE_CLOCK, 1);
@@ -4437,7 +4385,7 @@ static void test_sample_grabber(void)
     ok(ref == 0, "Release returned %ld\n", ref);

/* Detaching */
-    hr = MFCreateSampleGrabberSinkActivate(media_type, &grabber_callback, &activate);
+    hr = MFCreateSampleGrabberSinkActivate(media_type, grabber_callback, &activate);
     ok(hr == S_OK, "Failed to create grabber activate, hr %#lx.\n", hr);

hr = IMFActivate_ActivateObject(activate, &IID_IMFMediaSink, (void **)&sink);
@@ -4470,10 +4418,13 @@ static void test_sample_grabber(void)

hr = MFShutdown();
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
+
+    IMFSampleGrabberSinkCallback_Release(grabber_callback);
 }

static void test_sample_grabber_is_mediatype_supported(void)
 {
+    IMFSampleGrabberSinkCallback *grabber_callback = create_test_grabber_callback();
     IMFMediaType *media_type, *media_type2, *media_type3;
     IMFMediaTypeHandler *handler;
     IMFActivate *activate;
@@ -4494,7 +4445,7 @@ static void test_sample_grabber_is_mediatype_supported(void)
     hr = IMFMediaType_SetUINT32(media_type, &MF_MT_AUDIO_SAMPLES_PER_SECOND, 44100);
     ok(hr == S_OK, "Failed to set attribute, hr %#lx.\n", hr);

-    hr = MFCreateSampleGrabberSinkActivate(media_type, &grabber_callback, &activate);
+    hr = MFCreateSampleGrabberSinkActivate(media_type, grabber_callback, &activate);
     ok(hr == S_OK, "Failed to create grabber activate, hr %#lx.\n", hr);

hr = IMFActivate_ActivateObject(activate, &IID_IMFMediaSink, (void **)&sink);
@@ -4583,6 +4534,8 @@ static void test_sample_grabber_is_mediatype_supported(void)
     ok(ref == 0, "Release returned %ld\n", ref);
     ref = IMFMediaType_Release(media_type);
     ok(ref == 0, "Release returned %ld\n", ref);
+
+    IMFSampleGrabberSinkCallback_Release(grabber_callback);
 }

static void test_quality_manager(void)

[PATCH 2/5] mf/tests: Check sample grabber RGB / NV12 orientation.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/mf/tests/mf.c                   | 241 ++++++++++++++++++++++++++-
 dlls/mf/tests/nv12frame-grabber.bin  |   1 +
 dlls/mf/tests/resource.rc            |  16 ++
 dlls/mf/tests/rgb32frame-grabber.bin | Bin 0 -> 16384 bytes
 dlls/mf/tests/test.mp4               | Bin 0 -> 3983 bytes
 5 files changed, 257 insertions(+), 1 deletion(-)
 create mode 100644 dlls/mf/tests/nv12frame-grabber.bin
 create mode 100644 dlls/mf/tests/rgb32frame-grabber.bin
 create mode 100644 dlls/mf/tests/test.mp4

diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c
index 28e62b858d8..dd32eb2b7fd 100644
--- a/dlls/mf/tests/mf.c
+++ b/dlls/mf/tests/mf.c
@@ -133,6 +133,43 @@ static void check_handler_required_attributes_(int line, IMFMediaTypeHandler *ha
     ok_(__FILE__, line)(!ref, "Release returned %lu\n", ref);
 }

+#define check_sample_data(a, b, c, d) check_sample_data_(__LINE__, a, b, c, d)
+static void check_sample_data_(int line, const WCHAR *filename, const BYTE *data, DWORD length, BOOL is_rgb)
+{
+    WCHAR output_path[MAX_PATH];
+    DWORD i, diff = 0, max_diff;
+    const BYTE *expect_data;
+    ULONG expect_length;
+    HANDLE output_file;
+    HRSRC resource;
+
+    resource = FindResourceW(NULL, filename, (const WCHAR *)RT_RCDATA);
+    ok(resource != 0, "FindResourceW failed, error %lu\n", GetLastError());
+    expect_data = LockResource(LoadResource(GetModuleHandleW(NULL), resource));
+    expect_length = SizeofResource(GetModuleHandleW(NULL), resource);
+    ok(expect_length == length, "got length %lu\n", length);
+
+    /* and generate a new one as well in a temporary directory */
+    GetTempPathW(ARRAY_SIZE(output_path), output_path);
+    lstrcatW(output_path, filename);
+    output_file = CreateFileW(output_path, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0);
+    ok(output_file != INVALID_HANDLE_VALUE, "CreateFileW failed, error %lu\n", GetLastError());
+
+    for (i = 0; i < min(expect_length, length); i++)
+    {
+        if (is_rgb && i % 4 == 3) continue; /* ignore alpha diff */
+        diff += abs((int)expect_data[i] - (int)data[i]);
+    }
+    max_diff = expect_length * 256;
+    diff = (diff * 100) / max_diff;
+    ok_(__FILE__, line)(diff <= 5, "Unexpected %lu%% diff\n", diff);
+
+    WriteFile(output_file, data, length, &length, NULL);
+
+    trace("created %s\n", debugstr_w(output_path));
+    CloseHandle(output_file);
+}
+
 static void create_descriptors(UINT enum_types_count, IMFMediaType **enum_types, const media_type_desc *current_desc,
         IMFPresentationDescriptor **pd, IMFStreamDescriptor **sd)
 {
@@ -1879,6 +1916,51 @@ static HRESULT wait_media_event_(int line, IMFMediaSession *session, IMFAsyncCal
     return status;
 }

+static IMFMediaSource *create_media_source(const WCHAR *name, const WCHAR *mime)
+{
+    IMFSourceResolver *resolver;
+    IMFAttributes *attributes;
+    const BYTE *resource_data;
+    MF_OBJECT_TYPE obj_type;
+    IMFMediaSource *source;
+    IMFByteStream *stream;
+    ULONG resource_len;
+    HRSRC resource;
+    HRESULT hr;
+
+    resource = FindResourceW(NULL, name, (const WCHAR *)RT_RCDATA);
+    ok(resource != 0, "FindResourceW %s failed, error %lu\n", debugstr_w(name), GetLastError());
+    resource_data = LockResource(LoadResource(GetModuleHandleW(NULL), resource));
+    resource_len = SizeofResource(GetModuleHandleW(NULL), resource);
+
+    hr = MFCreateTempFile(MF_ACCESSMODE_READWRITE, MF_OPENMODE_DELETE_IF_EXIST, MF_FILEFLAGS_NONE, &stream);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFByteStream_Write(stream, resource_data, resource_len, &resource_len);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFByteStream_SetCurrentPosition(stream, 0);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = IMFByteStream_QueryInterface(stream, &IID_IMFAttributes, (void **)&attributes);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFAttributes_SetString(attributes, &MF_BYTESTREAM_CONTENT_TYPE, mime);
+    ok(hr == S_OK, "Failed to set string value, hr %#lx.\n", hr);
+    IMFAttributes_Release(attributes);
+
+    hr = MFCreateSourceResolver(&resolver);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFSourceResolver_CreateObjectFromByteStream(resolver, stream, NULL, MF_RESOLUTION_MEDIASOURCE, NULL,
+            &obj_type, (IUnknown **)&source);
+    ok(hr == S_OK || broken(hr == MF_E_UNSUPPORTED_BYTESTREAM_TYPE), "Unexpected hr %#lx.\n", hr);
+    IMFSourceResolver_Release(resolver);
+    IMFByteStream_Release(stream);
+
+    if (FAILED(hr))
+        return NULL;
+
+    ok(obj_type == MF_OBJECT_MEDIASOURCE, "got %d\n", obj_type);
+    return source;
+}
+
 static void test_media_session_events(void)
 {
     static const media_type_desc audio_float_44100 =
@@ -2547,6 +2629,11 @@ struct test_grabber_callback
 {
     IMFSampleGrabberSinkCallback IMFSampleGrabberSinkCallback_iface;
     LONG refcount;
+
+    const BYTE *sample_data;
+    DWORD sample_size;
+    HANDLE ready_event;
+    HANDLE done_event;
 };

static struct test_grabber_callback *impl_from_IMFSampleGrabberSinkCallback(IMFSampleGrabberSinkCallback *iface)
@@ -2581,7 +2668,13 @@ static ULONG WINAPI test_grabber_callback_Release(IMFSampleGrabberSinkCallback *
     ULONG refcount = InterlockedDecrement(&grabber->refcount);

if (!refcount)
+    {
+        if (grabber->ready_event)
+            CloseHandle(grabber->ready_event);
+        if (grabber->done_event)
+            CloseHandle(grabber->done_event);
         free(grabber);
+    }

return refcount;
 }
@@ -2620,7 +2713,20 @@ static HRESULT WINAPI test_grabber_callback_OnSetPresentationClock(IMFSampleGrab
 static HRESULT WINAPI test_grabber_callback_OnProcessSample(IMFSampleGrabberSinkCallback *iface, REFGUID major_type,
         DWORD sample_flags, LONGLONG sample_time, LONGLONG sample_duration, const BYTE *buffer, DWORD sample_size)
 {
-    return E_NOTIMPL;
+    struct test_grabber_callback *grabber = CONTAINING_RECORD(iface, struct test_grabber_callback, IMFSampleGrabberSinkCallback_iface);
+    DWORD res;
+
+    if (!grabber->ready_event)
+        return E_NOTIMPL;
+
+    grabber->sample_data = buffer;
+    grabber->sample_size = sample_size;
+    SetEvent(grabber->ready_event);
+
+    res = WaitForSingleObject(grabber->done_event, 1000);
+    ok(!res, "WaitForSingleObject returned %#lx", res);
+
+    return S_OK;
 }

static HRESULT WINAPI test_grabber_callback_OnShutdown(IMFSampleGrabberSinkCallback *iface)
@@ -4538,6 +4644,137 @@ static void test_sample_grabber_is_mediatype_supported(void)
     IMFSampleGrabberSinkCallback_Release(grabber_callback);
 }

+static void test_sample_grabber_orientation(GUID subtype)
+{
+    media_type_desc video_rgb32_desc =
+    {
+        ATTR_GUID(MF_MT_MAJOR_TYPE, MFMediaType_Video),
+        ATTR_GUID(MF_MT_SUBTYPE, subtype),
+    };
+
+    struct test_grabber_callback *grabber_callback;
+    IMFTopologyNode *src_node, *sink_node;
+    IMFPresentationDescriptor *pd;
+    IMFAsyncCallback *callback;
+    IMFActivate *sink_activate;
+    IMFMediaType *output_type;
+    IMFMediaSession *session;
+    IMFStreamDescriptor *sd;
+    IMFMediaSource *source;
+    IMFTopology *topology;
+    PROPVARIANT propvar;
+    BOOL selected;
+    HRESULT hr;
+    DWORD res;
+
+    if (!(source = create_media_source(L"test.mp4", L"video/mp4")))
+    {
+        win_skip("MP4 media source is not supported, skipping tests.\n");
+        return;
+    }
+
+    callback = create_test_callback();
+    grabber_callback = impl_from_IMFSampleGrabberSinkCallback(create_test_grabber_callback());
+
+    grabber_callback->ready_event = CreateEventW(NULL, FALSE, FALSE, NULL);
+    ok(!!grabber_callback->ready_event, "CreateEventW failed, error %lu\n", GetLastError());
+    grabber_callback->done_event = CreateEventW(NULL, FALSE, FALSE, NULL);
+    ok(!!grabber_callback->done_event, "CreateEventW failed, error %lu\n", GetLastError());
+
+    hr = MFStartup(MF_VERSION, MFSTARTUP_FULL);
+    ok(hr == S_OK, "Startup failure, hr %#lx.\n", hr);
+
+    hr = MFCreateMediaSession(NULL, &session);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = MFCreateTopologyNode(MF_TOPOLOGY_OUTPUT_NODE, &sink_node);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = MFCreateTopologyNode(MF_TOPOLOGY_SOURCESTREAM_NODE, &src_node);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = MFCreateTopology(&topology);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFTopology_AddNode(topology, sink_node);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFTopology_AddNode(topology, src_node);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFTopologyNode_ConnectOutput(src_node, 0, sink_node, 0);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = IMFMediaSource_CreatePresentationDescriptor(source, &pd);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFPresentationDescriptor_GetStreamDescriptorByIndex(pd, 0, &selected, &sd);
+    ok(selected, "got selected %u.\n", !!selected);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    init_source_node(source, -1, src_node, pd, sd);
+    IMFTopologyNode_Release(src_node);
+    IMFPresentationDescriptor_Release(pd);
+    IMFStreamDescriptor_Release(sd);
+
+    hr = MFCreateMediaType(&output_type);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    init_media_type(output_type, video_rgb32_desc, -1);
+    hr = MFCreateSampleGrabberSinkActivate(output_type, &grabber_callback->IMFSampleGrabberSinkCallback_iface, &sink_activate);
+    ok(hr == S_OK, "Failed to create grabber sink, hr %#lx.\n", hr);
+    IMFMediaType_Release(output_type);
+
+    hr = IMFTopologyNode_SetObject(sink_node, (IUnknown *)sink_activate);
+    ok(hr == S_OK, "Failed to set object, hr %#lx.\n", hr);
+    hr = IMFTopologyNode_SetUINT32(sink_node, &MF_TOPONODE_CONNECT_METHOD, MF_CONNECT_ALLOW_DECODER);
+    ok(hr == S_OK, "Failed to set connect method, hr %#lx.\n", hr);
+    IMFTopologyNode_Release(sink_node);
+
+    hr = IMFTopology_SetUINT32(topology, &MF_TOPOLOGY_ENUMERATE_SOURCE_TYPES, TRUE);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = IMFMediaSession_SetTopology(session, 0, topology);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    IMFTopology_Release(topology);
+
+    propvar.vt = VT_EMPTY;
+    hr = IMFMediaSession_Start(session, &GUID_NULL, &propvar);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    res = WaitForSingleObject(grabber_callback->ready_event, 5000);
+    ok(!res, "WaitForSingleObject returned %#lx\n", res);
+    CloseHandle(grabber_callback->ready_event);
+    grabber_callback->ready_event = NULL;
+
+    if (IsEqualGUID(&subtype, &MFVideoFormat_RGB32))
+        check_sample_data(L"rgb32frame-grabber.bin", grabber_callback->sample_data,
+                grabber_callback->sample_size, TRUE);
+    else if (IsEqualGUID(&subtype, &MFVideoFormat_NV12))
+        check_sample_data(L"nv12frame-grabber.bin", grabber_callback->sample_data,
+                grabber_callback->sample_size, FALSE);
+
+    SetEvent(grabber_callback->done_event);
+    ok(!res, "WaitForSingleObject returned %#lx\n", res);
+
+    hr = IMFMediaSession_ClearTopologies(session);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFMediaSession_Close(session);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = wait_media_event(session, callback, MESessionClosed, 1000, &propvar);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    ok(propvar.vt == VT_EMPTY, "got vt %u\n", propvar.vt);
+
+    hr = IMFMediaSession_Shutdown(session);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFMediaSource_Shutdown(source);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFActivate_ShutdownObject(sink_activate);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    IMFActivate_Release(sink_activate);
+    IMFMediaSession_Release(session);
+    IMFMediaSource_Release(source);
+
+    hr = MFShutdown();
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    IMFSampleGrabberSinkCallback_Release(&grabber_callback->IMFSampleGrabberSinkCallback_iface);
+}
+
 static void test_quality_manager(void)
 {
     IMFPresentationClock *clock;
@@ -6239,6 +6476,8 @@ START_TEST(mf)
     test_presentation_clock();
     test_sample_grabber();
     test_sample_grabber_is_mediatype_supported();
+    test_sample_grabber_orientation(MFVideoFormat_RGB32);
+    test_sample_grabber_orientation(MFVideoFormat_NV12);
     test_quality_manager();
     test_sar();
     test_evr();
diff --git a/dlls/mf/tests/nv12frame-grabber.bin b/dlls/mf/tests/nv12frame-grabber.bin
new file mode 100644
index 00000000000..9f0940e8c72
--- /dev/null
+++ b/dlls/mf/tests/nv12frame-grabber.bin
@@ -0,0 +1 @@
+���������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 ����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 �������������������
����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 ����������������������������������������������������������������������������������������������������������������������������������������Ҫ����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 �������������������
����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 ���������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
 �������������������
���������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������jjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjj
 jjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjjQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQQ))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))
 )))))))))))))))))))))))))))))))))))))))))))))))))))))
)))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))))�������������������������������������������������������������������������������������������������������������������������������������������������������������������
 ���������������������������������������������������������������������������������������������H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�H�����������������������������������������������������������������������������������������������������������������������������������������������������
 ��������������
�����������������������������������������������������������������������������������������������nnnnnnnnnnnnnnnnnnnnnnnnnnnnnnnn6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"6"���������������������������������������������������������������������������������������������������
 ������������������������������������������������������������������������������������������������������������������������������������������������������������ޒ��������������������������������Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�
 �Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�Z�
Z�Z�Z�Z�Z�Z�Z��n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n�n
\ No newline at end of file
diff --git a/dlls/mf/tests/resource.rc b/dlls/mf/tests/resource.rc
index 3cc0f875452..8a17386db7f 100644
--- a/dlls/mf/tests/resource.rc
+++ b/dlls/mf/tests/resource.rc
@@ -58,6 +58,10 @@ h264data.bin RCDATA h264data.bin
 /* @makedep: nv12frame.bin */
 nv12frame.bin RCDATA nv12frame.bin

+/* Generated from running the tests on Windows */
+/* @makedep: nv12frame-grabber.bin */
+nv12frame-grabber.bin RCDATA nv12frame-grabber.bin
+
 /* Generated from running the tests on Windows */
 /* @makedep: i420frame.bin */
 i420frame.bin RCDATA i420frame.bin
@@ -69,3 +73,15 @@ rgb32frame.bin RCDATA rgb32frame.bin
 /* Generated from running the tests on Windows */
 /* @makedep: rgb32frame-vp.bin */
 rgb32frame-vp.bin RCDATA rgb32frame-vp.bin
+
+/* Generated from running the tests on Windows */
+/* @makedep: rgb32frame-grabber.bin */
+rgb32frame-grabber.bin RCDATA rgb32frame-grabber.bin
+
+/* Generated with:
+ *  gst-launch-1.0 videotestsrc num-buffers=60 pattern=smpte100 ! \
+ *      video/x-raw,format=I420,width=64,height=64,framerate=30000/1001 ! \
+ *      videoflip method=clockwise ! videoconvert ! \
+ *      x264enc ! mp4mux ! filesink location=dlls/mf/tests/test.mp4
+ */
+test.mp4 RCDATA test.mp4
diff --git a/dlls/mf/tests/rgb32frame-grabber.bin b/dlls/mf/tests/rgb32frame-grabber.bin
new file mode 100644
index 0000000000000000000000000000000000000000..5c3e4e9e6e236de69562e20bf8c6289b4b32c65d
GIT binary patch
literal 16384
zcmeI&zfD3>6oB!M5KRa&07g6i6i%Vh)`k(BfS!g07(h3mvotz|Hc%3A00BdSynDEN
ze5d#gaPIkDa`SRaDU_6FkPT!5*?_KruL#T*b$+v#I=|WAZ-v>zc7qwwVAd;p%*?yb
z*&8lnsb+8BBSx6reUCA#*I&%$|9#BNyU*F-H(F};2Hv8B*)+PCJ*~m)tp5HmyV-#m
z_5Pdk46*@d1H;!LX4gMgn9WY-m`xrhm^Bnqo<TO?Y~b@aFk7_i`ya9AUSKw$zW))s
zXM-8__G5O!9y9aqbM}Udqota?f%o$fX19znD=jda(Z|fZ`<&hV?dSe;|Ji`Mfdh3|
B1=aun

literal 0
HcmV?d00001

diff --git a/dlls/mf/tests/test.mp4 b/dlls/mf/tests/test.mp4
new file mode 100644
index 0000000000000000000000000000000000000000..752d860008d472a1bfb26a1a97ef0c9b36ab2ba5
GIT binary patch
literal 3983
zcmeHKdu$X%7~d-eTkuh&2-XIsS|}v#b@y7Zt*-4+N^3;LCe{ch>+J4aZ|Uysc6Zy}
zK_d12Kn23XNRz8z6cs|%P|+X(6qWD@QG!s!2MIw94~gL=Bt5^`d-oa><3E}>&CGoB
zec$}%H{X0WJ7pLK`RtIP8I>Le3hkkCilu8%sV>K762dUKMVgFl7-!|?L0ix&Gx?ha
zW>4KY|LGAUn!6d-g>I&UZG0(zA6Q5FPoMd)6nrm@8X1ZFe!St=?WYEswyr5XiU#gD
z_gm02vl5jdNjC}NKr}1Z>KRDHgjBLD7@FMRP=5cshQ_i=<ZY=3Pnk$ysMn2<N_;l*
zuxv${hxK?s>9=j8ro6nXtIOS~$V69hz^$9D<#ZLd-_}&{(G6SC16B=^u!tp|LniU@
z6-Xwcs!MG=SHsq@2nVnlvIx%xD{9yv$5kMW@O~0RR)+}Eoyf34Fcn(ClzGn0!X#*r
zrUZ#BP(%)92qq4+5}uohB)_R^Sb(V<vQ46@iUm?tuu7I}5TtgEXMqBi7wG}Qd$>}L
zLq2TTf?>5O2K9&nv>Sr%^I62^%RI>Tn=r%TJxJB{HtdIi5Z7_YQWXif#1$+Gn9drK
zqG6lzPy#kFRSZs`7u60EhXhI23~a+#f)LpzRssM4jwYr)J`-!if?$b)5dv9}VQo>s
zGB)TgL_t)rMHf*_;_R!7D6M{51e<P<fY7QNV2vsbnA%1{fX#cVt7D>|DFGNFOCkXx
zb=Z6*OKF;zhSVgMAEuj<kk~G@n-VXHCelQRE8Ui;fIn=|!&X)yD%rY9PYAWs&GD>z
zCWr=I$mwyApIHqG%O(b2i8{qjLBqi$0#%3|K1*2y;2uvEg3J*7aOeRzDdbaBmC(2<
z1{^jd7OVuEa69A?%?hTQVO%4~3(qhGku#A8YCk#|EZAawz2x$do)3y{JJNFK;?->>
z7v#^*`*)rbSCoEoy#Il-3#v{WKD2b#mpzZ%GP-nHXKnotjjOKpx2|0J+B3_Z&)acf
z;7IcTTDf5Gg?Y2C^c8HrXJp&uf{(TP^6M8b&%HQ*$ro2I?VWVyK+XQ$ua%tIj|Vq&
z6_u%t*H*Olz0BXWed2~tNy$n3^5+N0xy4WXer4mvwbM@=HP8OM?#6XbxNl$i^Y+Q(
z#@1I)xpmv}H)__;{r>$QD?*p1m5wP}zxcc6eaG_j7oTr?Z)4L9+_QaC15@->kGl^Q
zE?sebR>^{=*1WoT_3mY(Cv6_=;ucMp_;s_-xAgtdH_H8eL&YxVwqT(h<6T><diw^C
zz5QmLqnrnAt~Wd@`1EAP_9j$0t}wQ}x{FKINDIBSSzkFCiZ#}|)_?CiUjOTJb7n*+
zVsiQzZ}_=}v859t%)uv95#F-B54sMgYBntN3a-Ven417oO<>j~oB?xh!}!vPkyM_!
zuJEt6cL{T_JK+ba(+iWT7}N7<sHseQZyW}-x6DCJlFxPZmS>>$RHmV(a_wy%4z)dl
zYp<1w8cah?<GLn>np_Hq^=ES3>YzsHM<dYlX&P!0V2ro-*l=9`$mDu06ZNMw)KsqF
zNyBgr^BJh&+6>gS#c8OiT*I@5;YxFLXbwQKf+{rvPPQg9D~;=O!=Xa9CLo;Oi7O20
znph~7S^wv2JYOp!gWtZ@lN#6Fe~_=+VmVL_sIScFX6S>5o&x0S0Gw9(-2%UYtMQ{5
zHAmC+PViK<PQMI2^W(kW+(au(?q`?@2IGS70yV@-+5nV8#&vPO;rlFjXRU_MUK^Mn
zv)i0CuS>2OM}u{TmLcoJJ>zb5RG<y53{y;G+k(E3s1|(y(gFw$?w;t}>@AwCV9+B?
z9)9l+?{?;u`DN8~BxvYsEiTi(g}&aJa6pEyD-5&g!@vhZey8SurqV8!qqagB9tm_Z
z6l%Y|!&FgJ&Yo=9q6+ds%eI^YiRzghxKpBE7+O*>qnbL{b`yxS(vs;B)hFADkq8Vt
zfLiZ@S8?RTU%if9iN`UM53iSKKoJEiUI5KFNmtE)qz0K$&L61q3~bReq(o?)XxYwr
zfar|xhMsOOAGS%)iI%u;A?T#2DxstPV0UGMZBfidJJ4slp&t)*9Mqd*^|qL9=$QJ@
z8n^!k$F5(bWGwH3z0kPriT17w>0=m0?KIXje*fFk;`OhK&vIY{cVzsxA?XgoC}$Sr
zM>}L2L;sLQoSvGC;`fv0S53In5_c6f(o(EMFTuihZJh$<!#~9ogeDF{|Ko&?j{(p4
JJHR;<_)p|_beRAE

literal 0
HcmV?d00001

[PATCH 2/5] mf/tests: Check sample grabber RGB / NV12 orientation.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=123546

Your paranoid android.

=== w7u_2qxl (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w7u_adm (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w7u_el (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064v1507 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064v1809 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064_tsign (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064v1507 (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064v1809 (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064 (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064_2qxl (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064_adm (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w1064_tsign (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64 (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64_en_AE_u8 (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64_ar (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64_ja (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== w10pro64_zh_CN (64 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4748: Test failed: Unexpected 67% diff

=== debian11 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit ar:MA report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit de report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit fr report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit he:IL report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit hi:IN report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit ja:JP report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit zh:CN report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit WoW report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (64 bit WoW report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

[PATCH 3/5] mf: Avoid clearing media session command list while it is running.

[Rémi Bernon]

From: Rémi Bernon

This fixes a random crash with mfmediaengine tests, which quickly starts
then shuts down a media session.
---
 dlls/mf/session.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c
index 8be3ffcd7f3..b410a5fe861 100644
--- a/dlls/mf/session.c
+++ b/dlls/mf/session.c
@@ -47,6 +47,7 @@ enum session_command
     SESSION_CMD_PAUSE,
     SESSION_CMD_STOP,
     SESSION_CMD_SET_RATE,
+    SESSION_CMD_SHUTDOWN,
 };

struct session_op
@@ -460,7 +461,10 @@ static HRESULT session_submit_command(struct media_session *session, struct sess
     {
         if (list_empty(&session->commands) && !(session->presentation.flags & SESSION_FLAG_PENDING_COMMAND))
             hr = MFPutWorkItem(MFASYNC_CALLBACK_QUEUE_STANDARD, &session->commands_callback, &op->IUnknown_iface);
-        list_add_tail(&session->commands, &op->entry);
+        if (op->command == SESSION_CMD_SHUTDOWN)
+            list_add_head(&session->commands, &op->entry);
+        else
+            list_add_tail(&session->commands, &op->entry);
         IUnknown_AddRef(&op->IUnknown_iface);
     }
     LeaveCriticalSection(&session->cs);
@@ -2041,7 +2045,7 @@ static HRESULT WINAPI mfsession_Shutdown(IMFMediaSession *iface)
         IMFPresentationClock_Release(session->clock);
         session->clock = NULL;
         session_clear_presentation(session);
-        session_clear_command_list(session);
+        session_submit_simple_command(session, SESSION_CMD_SHUTDOWN);
     }
     LeaveCriticalSection(&session->cs);

@@ -2383,6 +2387,10 @@ static HRESULT WINAPI session_commands_callback_Invoke(IMFAsyncCallback *iface,
         case SESSION_CMD_SET_RATE:
             session_set_rate(session, op->set_rate.thin, op->set_rate.rate);
             break;
+        case SESSION_CMD_SHUTDOWN:
+            session_clear_command_list(session);
+            session_command_complete(session);
+            break;
         default:
             ;
     }

[PATCH 3/5] mf: Avoid clearing media session command list while it is running.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=123547

Your paranoid android.

=== debian11 (32 bit report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit zh:CN report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (32 bit WoW report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

=== debian11 (64 bit WoW report) ===

mf:
mf.c:150: Test failed: got length 6144
mf.c:4747: Test failed: Unexpected 67% diff

[PATCH 4/5] mfmediaengine/tests: Pass a device and output format to create_media_engine.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/mfmediaengine/tests/mfmediaengine.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/dlls/mfmediaengine/tests/mfmediaengine.c b/dlls/mfmediaengine/tests/mfmediaengine.c
index 008ee58849c..3ff81b1f9b1 100644
--- a/dlls/mfmediaengine/tests/mfmediaengine.c
+++ b/dlls/mfmediaengine/tests/mfmediaengine.c
@@ -138,7 +138,7 @@ static struct media_engine_notify *create_callback(void)
     return object;
 }

-static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback)
+static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback, IUnknown *device, UINT32 output_format)
 {
     IMFDXGIDeviceManager *manager;
     IMFMediaEngine *media_engine;
@@ -154,7 +154,7 @@ static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback)

hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_CALLBACK, (IUnknown *)callback);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
-    hr = IMFAttributes_SetUINT32(attributes, &MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT, DXGI_FORMAT_UNKNOWN);
+    hr = IMFAttributes_SetUINT32(attributes, &MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT, output_format);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

hr = IMFMediaEngineClassFactory_CreateInstance(factory, 0, attributes, &media_engine);
@@ -166,9 +166,9 @@ static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback)
     return media_engine;
 }

-static IMFMediaEngineEx *create_media_engine_ex(IMFMediaEngineNotify *callback)
+static IMFMediaEngineEx *create_media_engine_ex(IMFMediaEngineNotify *callback, IUnknown *device, UINT32 output_format)
 {
-    IMFMediaEngine *engine = create_media_engine(callback);
+    IMFMediaEngine *engine = create_media_engine(callback, device, output_format);
     IMFMediaEngineEx *engine_ex = NULL;

if (engine)
@@ -331,7 +331,7 @@ static void test_Shutdown(void)

notify = create_callback();

-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

hr = IMFMediaEngine_Shutdown(media_engine);
     ok(hr == S_OK, "Failed to shut down, hr %#lx.\n", hr);
@@ -518,7 +518,7 @@ static void test_Play(void)

notify = create_callback();

-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

hr = IMFMediaEngine_GetBuffered(media_engine, &range);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
@@ -567,7 +567,7 @@ static void test_Play(void)
     IMFMediaEngine_Release(media_engine);

/* Play -> Pause */
-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

hr = IMFMediaEngine_Play(media_engine);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
@@ -594,7 +594,7 @@ static void test_playback_rate(void)

notify = create_callback();

-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

rate = IMFMediaEngine_GetDefaultPlaybackRate(media_engine);
     ok(rate == 1.0, "Unexpected default rate.\n");
@@ -624,7 +624,7 @@ static void test_mute(void)

notify = create_callback();

-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

ret = IMFMediaEngine_GetMuted(media_engine);
     ok(!ret, "Unexpected state.\n");
@@ -655,7 +655,7 @@ static void test_error(void)

notify = create_callback();

-    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);

eo = (void *)0xdeadbeef;
     hr = IMFMediaEngine_GetError(media_engine, &eo);
@@ -917,7 +917,7 @@ static void test_SetSourceFromByteStream(void)

notify = create_callback();

-    media_engine = create_media_engine_ex(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine_ex(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);
     if (!media_engine)
     {
         win_skip("IMFMediaEngineEx is not supported.\n");
@@ -953,7 +953,7 @@ static void test_audio_configuration(void)

notify = create_callback();

-    media_engine = create_media_engine_ex(&notify->IMFMediaEngineNotify_iface);
+    media_engine = create_media_engine_ex(&notify->IMFMediaEngineNotify_iface, NULL, DXGI_FORMAT_UNKNOWN);
     if (!media_engine)
     {
         IMFMediaEngineNotify_Release(&notify->IMFMediaEngineNotify_iface);

[PATCH 5/5] mfmediaengine/tests: Check IMFMediaEngine_TransferVideoFrames output orientation.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/mfmediaengine/tests/Makefile.in     |   2 +
 dlls/mfmediaengine/tests/mfmediaengine.c | 297 ++++++++++++++++++++++-
 dlls/mfmediaengine/tests/resource.rc     |  31 +++
 dlls/mfmediaengine/tests/rgb32frame.bin  | Bin 0 -> 16384 bytes
 dlls/mfmediaengine/tests/test.mp4        | Bin 0 -> 3983 bytes
 5 files changed, 328 insertions(+), 2 deletions(-)
 create mode 100644 dlls/mfmediaengine/tests/resource.rc
 create mode 100644 dlls/mfmediaengine/tests/rgb32frame.bin
 create mode 100644 dlls/mfmediaengine/tests/test.mp4

diff --git a/dlls/mfmediaengine/tests/Makefile.in b/dlls/mfmediaengine/tests/Makefile.in
index 421b75587a0..b23d530d46f 100644
--- a/dlls/mfmediaengine/tests/Makefile.in
+++ b/dlls/mfmediaengine/tests/Makefile.in
@@ -3,3 +3,5 @@ IMPORTS   = ole32 mfplat oleaut32 mfuuid uuid

C_SRCS = \
    mfmediaengine.c
+
+RC_SRCS = resource.rc
diff --git a/dlls/mfmediaengine/tests/mfmediaengine.c b/dlls/mfmediaengine/tests/mfmediaengine.c
index 3ff81b1f9b1..7af6a521e22 100644
--- a/dlls/mfmediaengine/tests/mfmediaengine.c
+++ b/dlls/mfmediaengine/tests/mfmediaengine.c
@@ -28,6 +28,7 @@
 #include "mfmediaengine.h"
 #include "mferror.h"
 #include "dxgi.h"
+#include "d3d11.h"
 #include "initguid.h"
 #include "mmdeviceapi.h"
 #include "audiosessiontypes.h"
@@ -35,6 +36,9 @@
 #include "wine/test.h"

static HRESULT (WINAPI *pMFCreateDXGIDeviceManager)(UINT *token, IMFDXGIDeviceManager **manager);
+static HRESULT (WINAPI *pD3D11CreateDevice)(IDXGIAdapter *adapter, D3D_DRIVER_TYPE driver_type, HMODULE swrast, UINT flags,
+        const D3D_FEATURE_LEVEL *feature_levels, UINT levels, UINT sdk_version, ID3D11Device **device_out,
+        D3D_FEATURE_LEVEL *obtained_feature_level, ID3D11DeviceContext **immediate_context);

static IMFMediaEngineClassFactory *factory;

@@ -62,12 +66,58 @@ static void check_interface_(unsigned int line, void *iface_ptr, REFIID iid, BOO
         IUnknown_Release(unk);
 }

+#define check_sample_data(a, b, c, d, e) check_sample_data_(__LINE__, a, b, c, d, e)
+static void check_sample_data_(int line, const WCHAR *filename, const BYTE *data, DWORD length, BOOL is_rgb, BOOL todo)
+{
+    WCHAR output_path[MAX_PATH];
+    DWORD i, diff = 0, max_diff;
+    const BYTE *expect_data;
+    ULONG expect_length;
+    HANDLE output_file;
+    HRSRC resource;
+
+    resource = FindResourceW(NULL, filename, (const WCHAR *)RT_RCDATA);
+    ok(resource != 0, "FindResourceW failed, error %lu\n", GetLastError());
+    expect_data = LockResource(LoadResource(GetModuleHandleW(NULL), resource));
+    expect_length = SizeofResource(GetModuleHandleW(NULL), resource);
+    ok(expect_length == length, "got length %lu\n", length);
+
+    /* and generate a new one as well in a temporary directory */
+    GetTempPathW(ARRAY_SIZE(output_path), output_path);
+    lstrcatW(output_path, filename);
+    output_file = CreateFileW(output_path, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0);
+    ok(output_file != INVALID_HANDLE_VALUE, "CreateFileW failed, error %lu\n", GetLastError());
+
+    for (i = 0; i < min(expect_length, length); i++)
+    {
+        if (is_rgb && i % 4 == 3) continue; /* ignore alpha diff */
+        diff += abs((int)expect_data[i] - (int)data[i]);
+    }
+    max_diff = expect_length * 256;
+    diff = (diff * 100) / max_diff;
+    todo_wine_if(todo)
+    ok_(__FILE__, line)(diff <= 5, "Unexpected %lu%% diff\n", diff);
+
+    WriteFile(output_file, data, length, &length, NULL);
+
+    trace("created %s\n", debugstr_w(output_path));
+    CloseHandle(output_file);
+}
+
 static void init_functions(void)
 {
-    HMODULE mod = GetModuleHandleA("mfplat.dll");
+    HMODULE mod;

#define X(f) p##f = (void*)GetProcAddress(mod, #f)
-    X(MFCreateDXGIDeviceManager);
+    if ((mod = GetModuleHandleA("mfplat.dll")))
+    {
+        X(MFCreateDXGIDeviceManager);
+    }
+
+    if ((mod = LoadLibraryA("d3d11.dll")))
+    {
+        X(D3D11CreateDevice);
+    }
 #undef X
 }

@@ -138,6 +188,34 @@ static struct media_engine_notify *create_callback(void)
     return object;
 }

+static ID3D11Device *create_d3d11_device(void)
+{
+    static const D3D_FEATURE_LEVEL default_feature_level[] =
+    {
+        D3D_FEATURE_LEVEL_11_0,
+        D3D_FEATURE_LEVEL_10_1,
+        D3D_FEATURE_LEVEL_10_0,
+    };
+    const D3D_FEATURE_LEVEL *feature_level;
+    unsigned int feature_level_count;
+    ID3D11Device *device;
+
+    feature_level = default_feature_level;
+    feature_level_count = ARRAY_SIZE(default_feature_level);
+
+    if (SUCCEEDED(pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0,
+            feature_level, feature_level_count, D3D11_SDK_VERSION, &device, NULL, NULL)))
+        return device;
+    if (SUCCEEDED(pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_WARP, NULL, 0,
+            feature_level, feature_level_count, D3D11_SDK_VERSION, &device, NULL, NULL)))
+        return device;
+    if (SUCCEEDED(pD3D11CreateDevice(NULL, D3D_DRIVER_TYPE_REFERENCE, NULL, 0,
+            feature_level, feature_level_count, D3D11_SDK_VERSION, &device, NULL, NULL)))
+        return device;
+
+    return NULL;
+}
+
 static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback, IUnknown *device, UINT32 output_format)
 {
     IMFDXGIDeviceManager *manager;
@@ -148,10 +226,17 @@ static IMFMediaEngine *create_media_engine(IMFMediaEngineNotify *callback, IUnkn

hr = pMFCreateDXGIDeviceManager(&token, &manager);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    if (device)
+    {
+        hr = IMFDXGIDeviceManager_ResetDevice(manager, device, token);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    }

hr = MFCreateAttributes(&attributes, 3);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

+    hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_DXGI_MANAGER, (IUnknown *)manager);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
     hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_CALLBACK, (IUnknown *)callback);
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
     hr = IMFAttributes_SetUINT32(attributes, &MF_MEDIA_ENGINE_VIDEO_OUTPUT_FORMAT, output_format);
@@ -972,6 +1057,213 @@ static void test_audio_configuration(void)
     IMFMediaEngineNotify_Release(&notify->IMFMediaEngineNotify_iface);
 }

+static IMFByteStream *load_resource(const WCHAR *name, const WCHAR *mime)
+{
+    IMFAttributes *attributes;
+    const BYTE *resource_data;
+    IMFByteStream *stream;
+    ULONG resource_len;
+    HRSRC resource;
+    HRESULT hr;
+
+    resource = FindResourceW(NULL, name, (const WCHAR *)RT_RCDATA);
+    ok(resource != 0, "FindResourceW %s failed, error %lu\n", debugstr_w(name), GetLastError());
+    resource_data = LockResource(LoadResource(GetModuleHandleW(NULL), resource));
+    resource_len = SizeofResource(GetModuleHandleW(NULL), resource);
+
+    hr = MFCreateTempFile(MF_ACCESSMODE_READWRITE, MF_OPENMODE_DELETE_IF_EXIST, MF_FILEFLAGS_NONE, &stream);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFByteStream_Write(stream, resource_data, resource_len, &resource_len);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFByteStream_SetCurrentPosition(stream, 0);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = IMFByteStream_QueryInterface(stream, &IID_IMFAttributes, (void **)&attributes);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFAttributes_SetString(attributes, &MF_BYTESTREAM_CONTENT_TYPE, mime);
+    ok(hr == S_OK, "Failed to set string value, hr %#lx.\n", hr);
+    IMFAttributes_Release(attributes);
+
+    return stream;
+}
+
+struct test_transfer_notify
+{
+    IMFMediaEngineNotify IMFMediaEngineNotify_iface;
+
+    IMFMediaEngineEx *media_engine;
+    HANDLE ready_event;
+    HRESULT error;
+};
+
+static HRESULT WINAPI test_transfer_notify_QueryInterface(IMFMediaEngineNotify *iface, REFIID riid, void **obj)
+{
+    if (IsEqualIID(riid, &IID_IUnknown)
+            || IsEqualIID(riid, &IID_IMFMediaEngineNotify))
+    {
+        *obj = iface;
+        IMFMediaEngineNotify_AddRef(iface);
+        return S_OK;
+    }
+
+    *obj = NULL;
+    return E_NOINTERFACE;
+}
+
+static ULONG WINAPI test_transfer_notify_AddRef(IMFMediaEngineNotify *iface)
+{
+    return 2;
+}
+
+static ULONG WINAPI test_transfer_notify_Release(IMFMediaEngineNotify *iface)
+{
+    return 1;
+}
+
+static HRESULT WINAPI test_transfer_notify_EventNotify(IMFMediaEngineNotify *iface, DWORD event, DWORD_PTR param1, DWORD param2)
+{
+    struct test_transfer_notify *notify = CONTAINING_RECORD(iface, struct test_transfer_notify, IMFMediaEngineNotify_iface);
+    IMFMediaEngineEx *media_engine = notify->media_engine;
+    DWORD width, height;
+    HRESULT hr;
+    BOOL ret;
+
+    switch (event)
+    {
+    case MF_MEDIA_ENGINE_EVENT_CANPLAY:
+        hr = IMFMediaEngineEx_Play(media_engine);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        break;
+
+    case MF_MEDIA_ENGINE_EVENT_FORMATCHANGE:
+        ret = IMFMediaEngineEx_HasVideo(media_engine);
+        ok(ret, "Unexpected HasVideo %u.\n", ret);
+        hr = IMFMediaEngineEx_GetNativeVideoSize(media_engine, &width, &height);
+        ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+        ok(width == 64, "Unexpected width %lu.\n", width);
+        ok(height == 64, "Unexpected height %lu.\n", height);
+        break;
+
+    case MF_MEDIA_ENGINE_EVENT_ERROR:
+        ok(broken(param2 == MF_E_UNSUPPORTED_BYTESTREAM_TYPE), "Unexpected error %#lx\n", param2);
+        notify->error = param2;
+        /* fallthrough */
+    case MF_MEDIA_ENGINE_EVENT_FIRSTFRAMEREADY:
+    case MF_MEDIA_ENGINE_EVENT_TIMEUPDATE:
+        SetEvent(notify->ready_event);
+        break;
+    }
+
+    return S_OK;
+}
+
+static IMFMediaEngineNotifyVtbl test_transfer_notify_vtbl =
+{
+    test_transfer_notify_QueryInterface,
+    test_transfer_notify_AddRef,
+    test_transfer_notify_Release,
+    test_transfer_notify_EventNotify,
+};
+
+static void test_TransferVideoFrames(void)
+{
+    struct test_transfer_notify notify = {{&test_transfer_notify_vtbl}};
+    ID3D11Texture2D *texture, *rb_texture;
+    D3D11_MAPPED_SUBRESOURCE map_desc;
+    IMFMediaEngineEx *media_engine;
+    ID3D11DeviceContext *context;
+    WCHAR url[] = {L"test.mp4"};
+    D3D11_TEXTURE2D_DESC desc;
+    IMFByteStream *stream;
+    ID3D11Device *device;
+    RECT dst_rect;
+    HRESULT hr;
+    DWORD res;
+
+    stream = load_resource(L"test.mp4", L"video/mp4");
+
+    notify.ready_event = CreateEventW(NULL, FALSE, FALSE, NULL);
+    ok(!!notify.ready_event, "CreateEventW failed, error %lu\n", GetLastError());
+
+    if (!(device = create_d3d11_device()))
+    {
+        skip("Failed to create a D3D11 device, skipping tests.\n");
+        return;
+    }
+
+    if (!(media_engine = create_media_engine_ex(&notify.IMFMediaEngineNotify_iface,
+            (IUnknown *)device, DXGI_FORMAT_B8G8R8X8_UNORM)))
+        return;
+    notify.media_engine = media_engine;
+
+    memset(&desc, 0, sizeof(desc));
+    desc.Width = 64;
+    desc.Height = 64;
+    desc.ArraySize = 1;
+    desc.Format = DXGI_FORMAT_B8G8R8X8_UNORM;
+    desc.BindFlags = D3D11_BIND_RENDER_TARGET;
+    desc.SampleDesc.Count = 1;
+    hr = ID3D11Device_CreateTexture2D(device, &desc, NULL, &texture);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    hr = IMFMediaEngineEx_SetSourceFromByteStream(media_engine, stream, url);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    IMFByteStream_Release(stream);
+
+    res = WaitForSingleObject(notify.ready_event, 5000);
+    ok(!res, "Unexpected res %#lx.\n", res);
+
+    if (FAILED(notify.error))
+    {
+        win_skip("Media engine reported error %#lx, skipping tests.\n", notify.error);
+        goto done;
+    }
+
+    /* FIXME: Wine first video frame is often full of garbage, wait for another update */
+    res = WaitForSingleObject(notify.ready_event, 100);
+    /* It's also missing the MF_MEDIA_ENGINE_EVENT_TIMEUPDATE notifications */
+    todo_wine
+    ok(!res, "Unexpected res %#lx.\n", res);
+
+    SetRect(&dst_rect, 0, 0, desc.Width, desc.Height);
+    hr = IMFMediaEngineEx_TransferVideoFrame(notify.media_engine, (IUnknown *)texture, NULL, &dst_rect, NULL);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    ID3D11Texture2D_GetDesc(texture, &desc);
+    desc.Usage = D3D11_USAGE_STAGING;
+    desc.BindFlags = 0;
+    desc.CPUAccessFlags = D3D11_CPU_ACCESS_READ;
+    desc.MiscFlags = 0;
+    hr = ID3D11Device_CreateTexture2D(device, &desc, NULL, &rb_texture);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    memset(&map_desc, 0, sizeof(map_desc));
+    ID3D11Device_GetImmediateContext(device, &context);
+    ID3D11DeviceContext_CopySubresourceRegion(context, (ID3D11Resource *)rb_texture,
+            0, 0, 0, 0, (ID3D11Resource *)texture, 0, NULL);
+    hr = ID3D11DeviceContext_Map(context, (ID3D11Resource *)rb_texture, 0, D3D11_MAP_READ, 0, &map_desc);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+
+    ok(!!map_desc.pData, "got pData %p\n", map_desc.pData);
+    ok(map_desc.DepthPitch == 16384, "got DepthPitch %u\n", map_desc.DepthPitch);
+    ok(map_desc.RowPitch == desc.Width * 4, "got RowPitch %u\n", map_desc.RowPitch);
+
+    check_sample_data(L"rgb32frame.bin", map_desc.pData, map_desc.RowPitch * desc.Height, TRUE, TRUE);
+
+    ID3D11DeviceContext_Unmap(context, (ID3D11Resource *)rb_texture, 0);
+    ID3D11DeviceContext_Release(context);
+    ID3D11Texture2D_Release(rb_texture);
+
+done:
+    IMFMediaEngineEx_Shutdown(media_engine);
+    IMFMediaEngineEx_Release(media_engine);
+
+    ID3D11Texture2D_Release(texture);
+    ID3D11Device_Release(device);
+
+    CloseHandle(notify.ready_event);
+}
+
 START_TEST(mfmediaengine)
 {
     HRESULT hr;
@@ -1002,6 +1294,7 @@ START_TEST(mfmediaengine)
     test_time_range();
     test_SetSourceFromByteStream();
     test_audio_configuration();
+    test_TransferVideoFrames();

IMFMediaEngineClassFactory_Release(factory);

diff --git a/dlls/mfmediaengine/tests/resource.rc b/dlls/mfmediaengine/tests/resource.rc
new file mode 100644
index 00000000000..bfb0340e35a
--- /dev/null
+++ b/dlls/mfmediaengine/tests/resource.rc
@@ -0,0 +1,31 @@
+/*
+ * Copyright 2022 Rémi Bernon for CodeWeavers
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
+ */
+
+#include "windef.h"
+
+/* Generated with:
+ *  gst-launch-1.0 videotestsrc num-buffers=60 pattern=smpte100 ! \
+ *      video/x-raw,format=I420,width=64,height=64,framerate=30000/1001 ! \
+ *      videoflip method=clockwise ! videoconvert ! \
+ *      x264enc ! mp4mux ! filesink location=dlls/mfmediaengine/tests/test.mp4
+ */
+test.mp4 RCDATA test.mp4
+
+/* Generated from running the tests on Windows */
+/* @makedep: rgb32frame.bin */
+rgb32frame.bin RCDATA rgb32frame.bin
diff --git a/dlls/mfmediaengine/tests/rgb32frame.bin b/dlls/mfmediaengine/tests/rgb32frame.bin
new file mode 100644
index 0000000000000000000000000000000000000000..a280ca61987fa2c898522b69638afd1e225caa3c
GIT binary patch
literal 16384
zcmeI$(G9{d3<OZK0IUk^0jwGpsBwi5%)q@$r+)kLnndmPXg~uR(0~Rskk-I`22Rdp
ztxitO`il-2V1NMz7|1e^H7(uNn*jzGV1R+$z@tymxjw6ta~K1n0|ppifB^=w3~X}^
z79B9a00Rs#kY(U@>`u<PRwt)w>&(pG&$;_%&c3g?`K>?yzJL3Frh)hV|8o$04g~M-
T;iwB;Fu(u<3^2gJ-x+uTq7Dt#

literal 0
HcmV?d00001

diff --git a/dlls/mfmediaengine/tests/test.mp4 b/dlls/mfmediaengine/tests/test.mp4
new file mode 100644
index 0000000000000000000000000000000000000000..752d860008d472a1bfb26a1a97ef0c9b36ab2ba5
GIT binary patch
literal 3983
zcmeHKdu$X%7~d-eTkuh&2-XIsS|}v#b@y7Zt*-4+N^3;LCe{ch>+J4aZ|Uysc6Zy}
zK_d12Kn23XNRz8z6cs|%P|+X(6qWD@QG!s!2MIw94~gL=Bt5^`d-oa><3E}>&CGoB
zec$}%H{X0WJ7pLK`RtIP8I>Le3hkkCilu8%sV>K762dUKMVgFl7-!|?L0ix&Gx?ha
zW>4KY|LGAUn!6d-g>I&UZG0(zA6Q5FPoMd)6nrm@8X1ZFe!St=?WYEswyr5XiU#gD
z_gm02vl5jdNjC}NKr}1Z>KRDHgjBLD7@FMRP=5cshQ_i=<ZY=3Pnk$ysMn2<N_;l*
zuxv${hxK?s>9=j8ro6nXtIOS~$V69hz^$9D<#ZLd-_}&{(G6SC16B=^u!tp|LniU@
z6-Xwcs!MG=SHsq@2nVnlvIx%xD{9yv$5kMW@O~0RR)+}Eoyf34Fcn(ClzGn0!X#*r
zrUZ#BP(%)92qq4+5}uohB)_R^Sb(V<vQ46@iUm?tuu7I}5TtgEXMqBi7wG}Qd$>}L
zLq2TTf?>5O2K9&nv>Sr%^I62^%RI>Tn=r%TJxJB{HtdIi5Z7_YQWXif#1$+Gn9drK
zqG6lzPy#kFRSZs`7u60EhXhI23~a+#f)LpzRssM4jwYr)J`-!if?$b)5dv9}VQo>s
zGB)TgL_t)rMHf*_;_R!7D6M{51e<P<fY7QNV2vsbnA%1{fX#cVt7D>|DFGNFOCkXx
zb=Z6*OKF;zhSVgMAEuj<kk~G@n-VXHCelQRE8Ui;fIn=|!&X)yD%rY9PYAWs&GD>z
zCWr=I$mwyApIHqG%O(b2i8{qjLBqi$0#%3|K1*2y;2uvEg3J*7aOeRzDdbaBmC(2<
z1{^jd7OVuEa69A?%?hTQVO%4~3(qhGku#A8YCk#|EZAawz2x$do)3y{JJNFK;?->>
z7v#^*`*)rbSCoEoy#Il-3#v{WKD2b#mpzZ%GP-nHXKnotjjOKpx2|0J+B3_Z&)acf
z;7IcTTDf5Gg?Y2C^c8HrXJp&uf{(TP^6M8b&%HQ*$ro2I?VWVyK+XQ$ua%tIj|Vq&
z6_u%t*H*Olz0BXWed2~tNy$n3^5+N0xy4WXer4mvwbM@=HP8OM?#6XbxNl$i^Y+Q(
z#@1I)xpmv}H)__;{r>$QD?*p1m5wP}zxcc6eaG_j7oTr?Z)4L9+_QaC15@->kGl^Q
zE?sebR>^{=*1WoT_3mY(Cv6_=;ucMp_;s_-xAgtdH_H8eL&YxVwqT(h<6T><diw^C
zz5QmLqnrnAt~Wd@`1EAP_9j$0t}wQ}x{FKINDIBSSzkFCiZ#}|)_?CiUjOTJb7n*+
zVsiQzZ}_=}v859t%)uv95#F-B54sMgYBntN3a-Ven417oO<>j~oB?xh!}!vPkyM_!
zuJEt6cL{T_JK+ba(+iWT7}N7<sHseQZyW}-x6DCJlFxPZmS>>$RHmV(a_wy%4z)dl
zYp<1w8cah?<GLn>np_Hq^=ES3>YzsHM<dYlX&P!0V2ro-*l=9`$mDu06ZNMw)KsqF
zNyBgr^BJh&+6>gS#c8OiT*I@5;YxFLXbwQKf+{rvPPQg9D~;=O!=Xa9CLo;Oi7O20
znph~7S^wv2JYOp!gWtZ@lN#6Fe~_=+VmVL_sIScFX6S>5o&x0S0Gw9(-2%UYtMQ{5
zHAmC+PViK<PQMI2^W(kW+(au(?q`?@2IGS70yV@-+5nV8#&vPO;rlFjXRU_MUK^Mn
zv)i0CuS>2OM}u{TmLcoJJ>zb5RG<y53{y;G+k(E3s1|(y(gFw$?w;t}>@AwCV9+B?
z9)9l+?{?;u`DN8~BxvYsEiTi(g}&aJa6pEyD-5&g!@vhZey8SurqV8!qqagB9tm_Z
z6l%Y|!&FgJ&Yo=9q6+ds%eI^YiRzghxKpBE7+O*>qnbL{b`yxS(vs;B)hFADkq8Vt
zfLiZ@S8?RTU%if9iN`UM53iSKKoJEiUI5KFNmtE)qz0K$&L61q3~bReq(o?)XxYwr
zfar|xhMsOOAGS%)iI%u;A?T#2DxstPV0UGMZBfidJJ4slp&t)*9Mqd*^|qL9=$QJ@
z8n^!k$F5(bWGwH3z0kPriT17w>0=m0?KIXje*fFk;`OhK&vIY{cVzsxA?XgoC}$Sr
zM>}L2L;sLQoSvGC;`fv0S53In5_c6f(o(EMFTuihZJh$<!#~9ogeDF{|Ko&?j{(p4
JJHR;<_)p|_beRAE

literal 0
HcmV?d00001

[PATCH 5/5] mfmediaengine/tests: Check IMFMediaEngine_TransferVideoFrames output orientation.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=123549

Your paranoid android.

=== w1064_2qxl (64 bit report) ===

mfmediaengine:
mfmediaengine.c:1226: Test failed: Unexpected res 0x102.
mfmediaengine.c:1251: Test failed: Unexpected 42% diff

[Rémi Bernon (＠rbernon)]

On Fri Sep 16 11:46:15 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=123547
> Your paranoid android.
> === debian11 (32 bit report) ===
> mf:
> mf.c:150: Test failed: got length 6144
> mf.c:4747: Test failed: Unexpected 67% diff
> === debian11 (32 bit zh:CN report) ===
> mf:
> mf.c:150: Test failed: got length 6144
> mf.c:4747: Test failed: Unexpected 67% diff
> === debian11 (32 bit WoW report) ===
> mf:
> mf.c:150: Test failed: got length 6144
> mf.c:4747: Test failed: Unexpected 67% diff
> === debian11 (64 bit WoW report) ===
> mf:
> mf.c:150: Test failed: got length 6144
> mf.c:4747: Test failed: Unexpected 67% diff

Ah crap, I added the NV12 checks late and apparently forgot to make sure they worked. I'll fix these.

[Rémi Bernon (＠rbernon)]

I actually think it's alright (except for the one w1064_2qxl timeout failure, where I can probably increase the timeout or only wait again for Wine).

For some reason, the NV12 resource didn't pass fine to the tesbot. Maybe because Git doesn't consider it as binary?

Any opinion about how I can make that better? `.gitattributes`? compressing the video frames? wrapping them in a simple standard, or custom format? I must say I'm not very happy with these files, I tried to keep them small but anything below 64x64 is having issues on Windows. I think compression may be nice, but I'm not sure if there's an easy way to integrate that.

[Bernhard Kölbl (＠besentv)]

Bernhard Kölbl (@besentv) commented about dlls/mfmediaengine/tests/mfmediaengine.c:
>  hr = pMFCreateDXGIDeviceManager(&token, &manager);
>  ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
>
> if (device)
> -
>
> {
> -
>    hr = IMFDXGIDeviceManager_ResetDevice(manager, device, token);
> -
>    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
>
> }
>
> hr = MFCreateAttributes(&attributes, 3);
> ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
> -
>
> hr = IMFAttributes_SetUnknown(attributes, &MF_MEDIA_ENGINE_DXGI_MANAGER, (IUnknown *)manager);

You probably only want to set this when a D3D device is provided.

[Rémi Bernon (＠rbernon)]

On Sat Sep 17 10:07:34 2022 +0000, Bernhard Kölbl wrote:
> You probably only want to set this when a D3D device is provided.

Indeed, I even thought I did that but it apparently got lost.

[Rémi Bernon (＠rbernon)]

I think I'll use some of the helpers from https://gitlab.winehq.org/wine/wine/-/merge_requests/887 here, to dump the frames as BMP, so it's easier to view and so Git stop taking NV12 as text.