[PATCH v3 0/1] MR9062: ole32: Add support for writing VT_BOOL properties.

[Haoyang Chen (＠chenhaoyang)]

--
  v3: ole32: Add support for writing VT_BOOL properties.

https://gitlab.winehq.org/wine/wine/-/merge_requests/9062

[PATCH v3 1/1] ole32: Add support for writing VT_BOOL properties.

[chy]

From: chy

---
 dlls/ole32/stg_prop.c       |  7 +++++++
 dlls/ole32/tests/stg_prop.c | 30 ++++++++++++++++++++++++++++++
 2 files changed, 37 insertions(+)

diff --git a/dlls/ole32/stg_prop.c b/dlls/ole32/stg_prop.c
index 547d1f82335..9f94efeee3f 100644
--- a/dlls/ole32/stg_prop.c
+++ b/dlls/ole32/stg_prop.c
@@ -2334,6 +2334,13 @@ static HRESULT PropertyStorage_WritePropertyToStream(PropertyStorage_impl *This,
         bytesWritten = count + sizeof(DWORD);
         break;
     }
+    case VT_BOOL:
+    {
+        hr = IStream_Write(This->stm, &var->boolVal, sizeof(var->boolVal),
+         &count);
+        bytesWritten = count;
+        break;
+    }
     case VT_FILETIME:
     {
         FILETIME temp;
diff --git a/dlls/ole32/tests/stg_prop.c b/dlls/ole32/tests/stg_prop.c
index 1b08833adbe..ea9cf735064 100644
--- a/dlls/ole32/tests/stg_prop.c
+++ b/dlls/ole32/tests/stg_prop.c
@@ -361,6 +361,20 @@ static void testPropsHelper(IPropertySetStorage **propSetStorage)
     hr = IPropertyStorage_WriteMultiple(propertyStorage, 1, &spec, &var, 0);
     ok(hr == S_OK, "WriteMultiple failed: 0x%08lx\n", hr);

+    /* set a bool value */
+    spec.ulKind = PRSPEC_PROPID;
+    spec.propid = PID_FIRST_USABLE + 1;
+    var.vt = VT_BOOL;
+    var.boolVal = VARIANT_TRUE;
+    hr = IPropertyStorage_WriteMultiple(propertyStorage, 1, &spec, &var, 0);
+    ok(hr == S_OK, "WriteMultiple failed: 0x%08lx\n", hr);
+
+    spec.ulKind = PRSPEC_LPWSTR;
+    spec.lpwstr = (WCHAR*)L"TestBoolProp";
+    var.boolVal = VARIANT_FALSE;
+    hr = IPropertyStorage_WriteMultiple(propertyStorage, 1, &spec, &var, PID_FIRST_USABLE);
+    ok(hr == S_OK, "Write VT_BOOL (FALSE) by name failed: 0x%08lx\n", hr);
+
     hr = IPropertyStorage_Commit(propertyStorage, STGC_DEFAULT);
     ok(hr == S_OK, "Commit failed: 0x%08lx\n", hr);

@@ -403,6 +417,22 @@ static void testPropsHelper(IPropertySetStorage **propSetStorage)
      "Didn't get expected type or value for property (got type %d, value %ld)\n",
      var.vt, var.lVal);

+    PropVariantClear(&var);
+    spec.ulKind = PRSPEC_PROPID;
+    spec.propid = PID_FIRST_USABLE + 1;
+    hr = IPropertyStorage_ReadMultiple(propertyStorage, 1, &spec, &var);
+    ok(hr == S_OK, "ReadMultiple failed: 0x%08lx\n", hr);
+    ok(var.vt == VT_BOOL && var.boolVal == VARIANT_TRUE,
+     "Didn't get expected type or value for property (got type %d, value %d)\n",
+     var.vt, var.boolVal);
+
+    PropVariantClear(&var);
+    spec.ulKind = PRSPEC_LPWSTR;
+    spec.lpwstr = (WCHAR*)L"TestBoolProp";
+    hr = IPropertyStorage_ReadMultiple(propertyStorage, 1, &spec, &var);
+    ok(hr == S_OK && var.vt == VT_BOOL && var.boolVal == VARIANT_FALSE,
+     "Read VT_BOOL (FALSE) failed\n");
+
     IPropertyStorage_Release(propertyStorage);
     if(propSetStorage) IPropertySetStorage_Release(*propSetStorage);
     IStorage_Release(storage);

[Haoyang Chen (＠chenhaoyang)]

On Fri Oct 10 02:37:52 2025 +0000, Nikolay Sivov wrote:
> Could you please add a test for this?

Ok, I will add a test.