[PATCH 0/6] MR4623: quartz: Split the VMR into two separate filters.

List overview All Threads

newer

older

[PATCH v5 0/2] MR4611: ntdll:...

[PATCH 0/1] MR4622: d3dx9: Check...

Zebediah Figura (＠zfigura)

6 Dec 2023 6 Dec '23

7:54 p.m.

Part 1 of a series to flesh out the VMR7 and implement renderless mode.

This is a very large (and kind of risky) series to try to push upstream just before code freeze. That said, we're not in code freeze yet, and it is a fix for a regression...

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Show replies by date

Zebediah Figura

6 Dec 6 Dec

7:54 p.m.

New subject: [PATCH 1/6] quartz: Return the rect from get_default_rect() through a pointer.

From: Zebediah Figura zfigura@codeweavers.com

Notably, this avoids the incorrect use of a static variable. --- dlls/quartz/quartz_private.h | 2 +- dlls/quartz/videorenderer.c | 9 +++------ dlls/quartz/vmr9.c | 11 ++++------- dlls/quartz/window.c | 4 ++-- 4 files changed, 10 insertions(+), 16 deletions(-)

diff --git a/dlls/quartz/quartz_private.h b/dlls/quartz/quartz_private.h index 849795d9c1b..58d8bb775a9 100644 --- a/dlls/quartz/quartz_private.h +++ b/dlls/quartz/quartz_private.h @@ -108,7 +108,7 @@ struct video_window

struct video_window_ops { - RECT (*get_default_rect)(struct video_window *window); + void (*get_default_rect)(struct video_window *window, RECT *rect); HRESULT (*get_current_image)(struct video_window *window, LONG *size, LONG *image); };

diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index f725a9998ce..e6735367cb3 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -199,14 +199,11 @@ static HRESULT video_renderer_connect(struct strmbase_renderer *iface, const AM_ return S_OK; }

-static RECT video_renderer_get_default_rect(struct video_window *iface) +static void video_renderer_get_default_rect(struct video_window *iface, RECT *rect) { - struct video_renderer *This = impl_from_video_window(iface); - static RECT defRect; - - SetRect(&defRect, 0, 0, This->VideoWidth, This->VideoHeight); + struct video_renderer *filter = impl_from_video_window(iface);

- return defRect; + SetRect(rect, 0, 0, filter->VideoWidth, filter->VideoHeight); }

static const struct strmbase_renderer_ops renderer_ops = diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index e34e6cee2ba..bc4ad4898f7 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -642,15 +642,12 @@ static const struct strmbase_renderer_ops renderer_ops = .renderer_pin_query_interface = vmr_pin_query_interface, };

-static RECT vmr_get_default_rect(struct video_window *This) +static void vmr_get_default_rect(struct video_window *iface, RECT *rect) { - struct quartz_vmr *pVMR9 = impl_from_video_window(This); - const BITMAPINFOHEADER *bmiheader = get_filter_bitmap_header(pVMR9); - static RECT defRect; - - SetRect(&defRect, 0, 0, bmiheader->biWidth, bmiheader->biHeight); + struct quartz_vmr *filter = impl_from_video_window(iface); + const BITMAPINFOHEADER *bitmap_header = get_filter_bitmap_header(filter);

- return defRect; + SetRect(rect, 0, 0, bitmap_header->biWidth, bitmap_header->biHeight); }

static HRESULT vmr_get_current_image(struct video_window *iface, LONG *size, LONG *image) diff --git a/dlls/quartz/window.c b/dlls/quartz/window.c index 4a9c4aed8f7..02c6a826bb2 100644 --- a/dlls/quartz/window.c +++ b/dlls/quartz/window.c @@ -655,7 +655,7 @@ HRESULT WINAPI BaseControlWindowImpl_GetMinIdealImageSize(IVideoWindow *iface, L

TRACE("window %p, width %p, height %p.\n", window, width, height);

- rect = window->ops->get_default_rect(window); + window->ops->get_default_rect(window, &rect); *width = rect.right - rect.left; *height = rect.bottom - rect.top; return S_OK; @@ -668,7 +668,7 @@ HRESULT WINAPI BaseControlWindowImpl_GetMaxIdealImageSize(IVideoWindow *iface, L

TRACE("window %p, width %p, height %p.\n", window, width, height);

- rect = window->ops->get_default_rect(window); + window->ops->get_default_rect(window, &rect); *width = rect.right - rect.left; *height = rect.bottom - rect.top; return S_OK;

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Zebediah Figura

7:54 p.m.

New subject: [PATCH 2/6] quartz: Do not forward IVMRFilterConfig::SetRenderingMode() to IVMRFilterConfig9.

From: Zebediah Figura zfigura@codeweavers.com

--- dlls/quartz/vmr9.c | 41 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 39 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index bc4ad4898f7..e0bcd970783 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -926,10 +926,47 @@ static HRESULT WINAPI VMR7FilterConfig_GetRenderingPrefs(IVMRFilterConfig *iface static HRESULT WINAPI VMR7FilterConfig_SetRenderingMode(IVMRFilterConfig *iface, DWORD mode) { struct quartz_vmr *filter = impl_from_IVMRFilterConfig(iface); + struct default_presenter *default_presenter; + HRESULT hr = S_OK; + + TRACE("filter %p, mode %lu.\n", filter, mode); + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + if (filter->mode) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return VFW_E_WRONG_STATE; + } + + switch (mode) + { + case VMRMode_Windowed: + case VMRMode_Windowless: + if (FAILED(hr = default_presenter_create(filter, &default_presenter))) + { + ERR("Failed to create default presenter, hr %#lx.\n", hr); + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; + } + filter->allocator = &default_presenter->IVMRSurfaceAllocator9_iface; + filter->presenter = &default_presenter->IVMRImagePresenter9_iface; + IVMRImagePresenter9_AddRef(filter->presenter);

- TRACE("iface %p, mode %#lx.\n", iface, mode); + IVMRSurfaceAllocator9_AdviseNotify(filter->allocator, &filter->IVMRSurfaceAllocatorNotify9_iface); + break; + case VMRMode_Renderless: + break; + default: + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return E_INVALIDARG; + }

- return IVMRFilterConfig9_SetRenderingMode(&filter->IVMRFilterConfig9_iface, mode); + if (mode != VMRMode_Windowed) + video_window_cleanup(&filter->window); + + filter->mode = mode; + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; }

static HRESULT WINAPI VMR7FilterConfig_GetRenderingMode(IVMRFilterConfig *iface, DWORD *mode)

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Zebediah Figura

7:54 p.m.

New subject: [PATCH 3/6] quartz: Improve the IVMRFilterConfig::SetNumberOfStreams() stub.

From: Zebediah Figura zfigura@codeweavers.com

Bring it up to parity with IVMRFilterConfig9::SetNumberOfStreams(). --- dlls/quartz/tests/vmr7.c | 76 +++++++++++++++++++++++----------------- dlls/quartz/vmr9.c | 22 ++++++++++-- 2 files changed, 63 insertions(+), 35 deletions(-)

diff --git a/dlls/quartz/tests/vmr7.c b/dlls/quartz/tests/vmr7.c index c30fefbd3ab..50e3da462d2 100644 --- a/dlls/quartz/tests/vmr7.c +++ b/dlls/quartz/tests/vmr7.c @@ -54,7 +54,7 @@ static HRESULT set_mixing_mode(IBaseFilter *filter) ok(hr == S_OK, "Got hr %#lx.\n", hr);

hr = IVMRFilterConfig_SetNumberOfStreams(config, 2); - todo_wine ok(hr == VFW_E_DDRAW_CAPS_NOT_SUITABLE || hr == S_OK, "Got hr %#lx.\n", hr); + ok(hr == VFW_E_DDRAW_CAPS_NOT_SUITABLE || hr == S_OK, "Got hr %#lx.\n", hr);

IVMRFilterConfig_Release(config); return hr; @@ -171,7 +171,7 @@ static void test_filter_config(void) hr = IVMRFilterConfig_SetNumberOfStreams(config, 3); if (hr != VFW_E_DDRAW_CAPS_NOT_SUITABLE) { - todo_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); + ok(hr == S_OK, "Got hr %#lx.\n", hr);

hr = IVMRFilterConfig_GetNumberOfStreams(config, &count); todo_wine { @@ -502,7 +502,7 @@ static void test_enum_pins(void) if (SUCCEEDED(set_mixing_mode(filter))) { hr = IEnumPins_Next(enum1, 1, pins, NULL); - todo_wine ok(hr == S_FALSE, "Got hr %#lx.\n", hr); + ok(hr == S_FALSE, "Got hr %#lx.\n", hr);

hr = IEnumPins_Reset(enum1); ok(hr == S_OK, "Got hr %#lx.\n", hr); @@ -512,8 +512,9 @@ static void test_enum_pins(void) IPin_Release(pins[0]);

hr = IEnumPins_Next(enum1, 1, pins, NULL); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - IPin_Release(pins[0]); + todo_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); + if (hr == S_OK) + IPin_Release(pins[0]);

hr = IEnumPins_Next(enum1, 1, pins, NULL); ok(hr == S_FALSE, "Got hr %#lx.\n", hr); @@ -522,19 +523,21 @@ static void test_enum_pins(void) ok(hr == S_OK, "Got hr %#lx.\n", hr);

hr = IEnumPins_Next(enum1, 2, pins, &count); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - ok(count == 2, "Got count %lu.\n", count); + todo_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); + todo_wine ok(count == 2, "Got count %lu.\n", count); IPin_Release(pins[0]); - IPin_Release(pins[1]); + if (count == 2) + IPin_Release(pins[1]);

hr = IEnumPins_Reset(enum1); ok(hr == S_OK, "Got hr %#lx.\n", hr);

hr = IEnumPins_Next(enum1, 3, pins, &count); ok(hr == S_FALSE, "Got hr %#lx.\n", hr); - ok(count == 2, "Got count %lu.\n", count); + todo_wine ok(count == 2, "Got count %lu.\n", count); IPin_Release(pins[0]); - IPin_Release(pins[1]); + if (count == 2) + IPin_Release(pins[1]); } else skip("Mixing mode is not supported.\n"); @@ -584,12 +587,15 @@ static void test_find_pin(void) IPin_Release(pin2);

hr = IBaseFilter_FindPin(filter, L"VMR Input1", &pin); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - hr = IEnumPins_Next(enum_pins, 1, &pin2, NULL); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - ok(pin == pin2, "Pins did not match.\n"); - IPin_Release(pin); - IPin_Release(pin2); + todo_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); + if (hr == S_OK) + { + hr = IEnumPins_Next(enum_pins, 1, &pin2, NULL); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + ok(pin == pin2, "Pins did not match.\n"); + IPin_Release(pin); + IPin_Release(pin2); + }

hr = IBaseFilter_FindPin(filter, L"VMR Input2", &pin); ok(hr == VFW_E_NOT_FOUND, "Got hr %#lx.\n", hr); @@ -635,26 +641,30 @@ static void test_pin_info(void)

if (SUCCEEDED(set_mixing_mode(filter))) { - IBaseFilter_FindPin(filter, L"VMR Input1", &pin); - hr = IPin_QueryPinInfo(pin, &info); - ok(info.pFilter == filter, "Expected filter %p, got %p.\n", filter, info.pFilter); - ok(info.dir == PINDIR_INPUT, "Got direction %d.\n", info.dir); - ok(!wcscmp(info.achName, L"VMR Input1"), "Got name %s.\n", wine_dbgstr_w(info.achName)); - IBaseFilter_Release(info.pFilter); - - hr = IPin_QueryDirection(pin, &dir); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - ok(dir == PINDIR_INPUT, "Got direction %d.\n", dir); + hr = IBaseFilter_FindPin(filter, L"VMR Input1", &pin); + todo_wine ok(hr == S_OK, "Got hr %#lx.\n", hr); + if (hr == S_OK) + { + hr = IPin_QueryPinInfo(pin, &info); + ok(info.pFilter == filter, "Expected filter %p, got %p.\n", filter, info.pFilter); + ok(info.dir == PINDIR_INPUT, "Got direction %d.\n", info.dir); + ok(!wcscmp(info.achName, L"VMR Input1"), "Got name %s.\n", wine_dbgstr_w(info.achName)); + IBaseFilter_Release(info.pFilter);

- hr = IPin_QueryId(pin, &id); - ok(hr == S_OK, "Got hr %#lx.\n", hr); - ok(!wcscmp(id, L"VMR Input1"), "Got id %s.\n", wine_dbgstr_w(id)); - CoTaskMemFree(id); + hr = IPin_QueryDirection(pin, &dir); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + ok(dir == PINDIR_INPUT, "Got direction %d.\n", dir);

- hr = IPin_QueryInternalConnections(pin, NULL, &count); - ok(hr == E_NOTIMPL, "Got hr %#lx.\n", hr); + hr = IPin_QueryId(pin, &id); + ok(hr == S_OK, "Got hr %#lx.\n", hr); + ok(!wcscmp(id, L"VMR Input1"), "Got id %s.\n", wine_dbgstr_w(id)); + CoTaskMemFree(id);

- IPin_Release(pin); + hr = IPin_QueryInternalConnections(pin, NULL, &count); + ok(hr == E_NOTIMPL, "Got hr %#lx.\n", hr); + + IPin_Release(pin); + } } else skip("Mixing mode is not supported.\n"); diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index e0bcd970783..38ebfbfa3bb 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -893,9 +893,27 @@ static HRESULT WINAPI VMR7FilterConfig_SetNumberOfStreams(IVMRFilterConfig *ifac { struct quartz_vmr *filter = impl_from_IVMRFilterConfig(iface);

- FIXME("filter %p, count %lu, stub!\n", filter, count); + FIXME("iface %p, count %lu, stub!\n", iface, count);

- return E_NOTIMPL; + if (!count) + { + WARN("Application requested zero streams; returning E_INVALIDARG.\n"); + return E_INVALIDARG; + } + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + + if (filter->stream_count) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + WARN("Stream count is already set; returning VFW_E_WRONG_STATE.\n"); + return VFW_E_WRONG_STATE; + } + + filter->stream_count = count; + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return S_OK; }

static HRESULT WINAPI VMR7FilterConfig_GetNumberOfStreams(IVMRFilterConfig *iface, DWORD *max)

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Zebediah Figura

7:54 p.m.

New subject: [PATCH 4/6] quartz: Do not forward IVMRWindowlessControl::SetVideoClippingWindow() to IVMRWindowlessControl9.

From: Zebediah Figura zfigura@codeweavers.com

--- dlls/quartz/vmr9.c | 25 +++++++++++++++++++++++-- 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index 38ebfbfa3bb..38380e05b76 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -1578,10 +1578,31 @@ static HRESULT WINAPI VMR7WindowlessControl_SetAspectRatioMode(IVMRWindowlessCon static HRESULT WINAPI VMR7WindowlessControl_SetVideoClippingWindow(IVMRWindowlessControl *iface, HWND window) { struct quartz_vmr *filter = impl_from_IVMRWindowlessControl(iface); + HRESULT hr; + + TRACE("filter %p, window %p.\n", filter, window); + + if (!IsWindow(window)) + { + WARN("Invalid window %p, returning E_INVALIDARG.\n", window); + return E_INVALIDARG; + } + + EnterCriticalSection(&filter->renderer.filter.filter_cs);

- TRACE("iface %p, window %p.\n", iface, window); + if (filter->renderer.sink.pin.peer) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + WARN("Attempt to set the clipping window while connected; returning VFW_E_WRONG_STATE.\n"); + return VFW_E_WRONG_STATE; + }

- return IVMRWindowlessControl9_SetVideoClippingWindow(&filter->IVMRWindowlessControl9_iface, window); + filter->clipping_window = window; + + hr = IVMRFilterConfig_SetNumberOfStreams(&filter->IVMRFilterConfig_iface, 4); + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; }

static HRESULT WINAPI VMR7WindowlessControl_RepaintVideo(IVMRWindowlessControl *iface,

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Zebediah Figura

7:54 p.m.

New subject: [PATCH 5/6] quartz: Split the VMR into two separate filters.

From: Zebediah Figura zfigura@codeweavers.com

Rewrite requires renderless mode in the VMR7, which means that it needs to actually use ddraw instead of d3d9. At that point the two will share almost no common code. Split them into separate objects which live in separate files.

This commit essentially copies vmr9.c into vmr7.c, then removes the VMR7-specific interfaces from the VMR9 and vice versa. The default presenter is retained for now (but will be replaced eventually).

Since the VMR7 no longer exposes IVMRSurfaceAllocatorNotify9, the relevant calls to AdviseNotify(), SetD3DDevice(), and AllocateSurfaceHelper() are changed from COM methods to direct function calls. No other change should be made. --- dlls/quartz/Makefile.in | 1 + dlls/quartz/vmr7.c | 2121 +++++++++++++++++++++++++++++++++++++++ dlls/quartz/vmr9.c | 684 +------------ 3 files changed, 2132 insertions(+), 674 deletions(-) create mode 100644 dlls/quartz/vmr7.c

diff --git a/dlls/quartz/Makefile.in b/dlls/quartz/Makefile.in index ae45fa8c387..90955e73cb4 100644 --- a/dlls/quartz/Makefile.in +++ b/dlls/quartz/Makefile.in @@ -18,6 +18,7 @@ SOURCES = \ regsvr.c \ systemclock.c \ videorenderer.c \ + vmr7.c \ vmr9.c \ window.c

diff --git a/dlls/quartz/vmr7.c b/dlls/quartz/vmr7.c new file mode 100644 index 00000000000..8f8d6d4e89c --- /dev/null +++ b/dlls/quartz/vmr7.c @@ -0,0 +1,2121 @@ +/* + * Video Mixing Renderer for DirectDraw 7 + * + * Copyright 2004 Christian Costa + * Copyright 2008 Maarten Lankhorst + * Copyright 2012 Aric Stewart + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include "quartz_private.h" + +#include "uuids.h" +#include "vfwmsgs.h" +#include "amvideo.h" +#include "windef.h" +#include "winbase.h" +#include "dshow.h" +#include "evcode.h" +#include "strmif.h" +#include "ddraw.h" +#include "dvdmedia.h" +#include "d3d9.h" +#include "videoacc.h" +#include "vmr9.h" + +#include "wine/debug.h" + +WINE_DEFAULT_DEBUG_CHANNEL(quartz); + +static const BITMAPINFOHEADER *get_bitmap_header(const AM_MEDIA_TYPE *mt) +{ + if (IsEqualGUID(&mt->formattype, &FORMAT_VideoInfo)) + return &((VIDEOINFOHEADER *)mt->pbFormat)->bmiHeader; + else + return &((VIDEOINFOHEADER2 *)mt->pbFormat)->bmiHeader; +} + +struct vmr7 +{ + struct strmbase_renderer renderer; + struct video_window window; + + IAMCertifiedOutputProtection IAMCertifiedOutputProtection_iface; + IAMFilterMiscFlags IAMFilterMiscFlags_iface; + IVMRFilterConfig IVMRFilterConfig_iface; + IVMRMonitorConfig IVMRMonitorConfig_iface; + IVMRSurfaceAllocatorNotify IVMRSurfaceAllocatorNotify_iface; + IVMRWindowlessControl IVMRWindowlessControl_iface; + + IAMVideoAccelerator IAMVideoAccelerator_iface; + IOverlay IOverlay_iface; + + IVMRSurfaceAllocator9 *allocator; + IVMRImagePresenter9 *presenter; + + DWORD stream_count; + DWORD mixing_prefs; + + VMR9Mode mode; + + HMODULE d3d9_module; + + IDirect3DDevice9 *device; + IDirect3DSurface9 **surfaces; + DWORD surface_count; + DWORD surface_index; + DWORD_PTR cookie; + + HWND clipping_window; + + VMR9AspectRatioMode aspect_mode; +}; + +static const BITMAPINFOHEADER *get_filter_bitmap_header(const struct vmr7 *filter) +{ + return get_bitmap_header(&filter->renderer.sink.pin.mt); +} + +static struct vmr7 *impl_from_video_window(struct video_window *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, window); +} + +static struct vmr7 *impl_from_IAMCertifiedOutputProtection(IAMCertifiedOutputProtection *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IAMCertifiedOutputProtection_iface); +} + +static struct vmr7 *impl_from_IAMFilterMiscFlags(IAMFilterMiscFlags *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IAMFilterMiscFlags_iface); +} + +static struct vmr7 *impl_from_IVMRFilterConfig(IVMRFilterConfig *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IVMRFilterConfig_iface); +} + +static struct vmr7 *impl_from_IVMRMonitorConfig(IVMRMonitorConfig *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IVMRMonitorConfig_iface); +} + +static struct vmr7 *impl_from_IVMRSurfaceAllocatorNotify(IVMRSurfaceAllocatorNotify *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IVMRSurfaceAllocatorNotify_iface); +} + +static struct vmr7 *impl_from_IVMRWindowlessControl(IVMRWindowlessControl *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IVMRWindowlessControl_iface); +} + +struct default_presenter +{ + IVMRImagePresenter9 IVMRImagePresenter9_iface; + IVMRSurfaceAllocator9 IVMRSurfaceAllocator9_iface; + + LONG refcount; + + IDirect3DDevice9 *device; + IDirect3D9 *d3d9; + IDirect3DSurface9 **surfaces; + HMONITOR monitor; + DWORD surface_count; + + VMR9AllocationInfo info; + + struct vmr7 *vmr; +}; + +static struct default_presenter *impl_from_IVMRImagePresenter9(IVMRImagePresenter9 *iface) +{ + return CONTAINING_RECORD(iface, struct default_presenter, IVMRImagePresenter9_iface); +} + +static struct default_presenter *impl_from_IVMRSurfaceAllocator9(IVMRSurfaceAllocator9 *iface) +{ + return CONTAINING_RECORD(iface, struct default_presenter, IVMRSurfaceAllocator9_iface); +} + +static HRESULT default_presenter_create(struct vmr7 *parent, struct default_presenter **presenter); + +static struct vmr7 *impl_from_IBaseFilter(IBaseFilter *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, renderer.filter.IBaseFilter_iface); +} + +static HRESULT vmr_render(struct strmbase_renderer *iface, IMediaSample *sample) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + unsigned int data_size, width, depth, src_pitch; + const BITMAPINFOHEADER *bitmap_header; + REFERENCE_TIME start_time, end_time; + VMR9PresentationInfo info = {0}; + D3DLOCKED_RECT locked_rect; + BYTE *data = NULL; + HRESULT hr; + int height; + + TRACE("filter %p, sample %p.\n", filter, sample); + + if (!filter->allocator || !filter->presenter) + { + ERR("No presenter.\n"); + return S_FALSE; + } + + info.dwFlags = VMR9Sample_SrcDstRectsValid; + + if (SUCCEEDED(hr = IMediaSample_GetTime(sample, &start_time, &end_time))) + info.dwFlags |= VMR9Sample_TimeValid; + + if (IMediaSample_IsDiscontinuity(sample) == S_OK) + info.dwFlags |= VMR9Sample_Discontinuity; + + if (IMediaSample_IsPreroll(sample) == S_OK) + info.dwFlags |= VMR9Sample_Preroll; + + if (IMediaSample_IsSyncPoint(sample) == S_OK) + info.dwFlags |= VMR9Sample_SyncPoint; + + if (FAILED(hr = IMediaSample_GetPointer(sample, &data))) + { + ERR("Failed to get pointer to sample data, hr %#lx.\n", hr); + return hr; + } + data_size = IMediaSample_GetActualDataLength(sample); + + bitmap_header = get_filter_bitmap_header(filter); + width = bitmap_header->biWidth; + height = bitmap_header->biHeight; + depth = bitmap_header->biBitCount; + if (bitmap_header->biCompression == mmioFOURCC('N','V','1','2') + || bitmap_header->biCompression == mmioFOURCC('Y','V','1','2')) + src_pitch = width; + else /* packed YUV (UYVY or YUY2) or RGB */ + src_pitch = ((width * depth / 8) + 3) & ~3; + + info.rtStart = start_time; + info.rtEnd = end_time; + info.szAspectRatio.cx = width; + info.szAspectRatio.cy = height; + info.lpSurf = filter->surfaces[(++filter->surface_index) % filter->surface_count]; + + if (FAILED(hr = IDirect3DSurface9_LockRect(info.lpSurf, &locked_rect, NULL, D3DLOCK_DISCARD))) + { + ERR("Failed to lock surface, hr %#lx.\n", hr); + return hr; + } + + if (height > 0 && bitmap_header->biCompression == BI_RGB) + { + BYTE *dst = (BYTE *)locked_rect.pBits + (height * locked_rect.Pitch); + const BYTE *src = data; + + TRACE("Inverting image.\n"); + + while (height--) + { + dst -= locked_rect.Pitch; + memcpy(dst, src, width * depth / 8); + src += src_pitch; + } + } + else if (locked_rect.Pitch != src_pitch) + { + BYTE *dst = locked_rect.pBits; + const BYTE *src = data; + + height = abs(height); + + TRACE("Source pitch %u does not match dest pitch %u; copying manually.\n", + src_pitch, locked_rect.Pitch); + + while (height--) + { + memcpy(dst, src, width * depth / 8); + src += src_pitch; + dst += locked_rect.Pitch; + } + } + else + { + memcpy(locked_rect.pBits, data, data_size); + } + + IDirect3DSurface9_UnlockRect(info.lpSurf); + + return IVMRImagePresenter9_PresentImage(filter->presenter, filter->cookie, &info); +} + +static HRESULT vmr_query_accept(struct strmbase_renderer *iface, const AM_MEDIA_TYPE *mt) +{ + if (!IsEqualIID(&mt->majortype, &MEDIATYPE_Video) || !mt->pbFormat) + return S_FALSE; + + if (!IsEqualGUID(&mt->formattype, &FORMAT_VideoInfo) + && !IsEqualGUID(&mt->formattype, &FORMAT_VideoInfo2)) + return S_FALSE; + + return S_OK; +} + +static HRESULT initialize_device(struct vmr7 *filter, VMR9AllocationInfo *info, DWORD count) +{ + HRESULT hr; + + if (FAILED(hr = IVMRSurfaceAllocator9_InitializeDevice(filter->allocator, + filter->cookie, info, &count))) + { + WARN("Failed to initialize device (flags %#lx), hr %#lx.\n", info->dwFlags, hr); + return hr; + } + + for (DWORD i = 0; i < count; ++i) + { + if (FAILED(hr = IVMRSurfaceAllocator9_GetSurface(filter->allocator, + filter->cookie, i, 0, &filter->surfaces[i]))) + { + ERR("Failed to get surface %lu, hr %#lx.\n", i, hr); + while (i--) + IDirect3DSurface9_Release(filter->surfaces[i]); + IVMRSurfaceAllocator9_TerminateDevice(filter->allocator, filter->cookie); + return hr; + } + } + + return hr; +} + +static HRESULT allocate_surfaces(struct vmr7 *filter, const AM_MEDIA_TYPE *mt) +{ + const BITMAPINFOHEADER *bitmap_header = get_bitmap_header(mt); + VMR9AllocationInfo info = {0}; + HRESULT hr = E_FAIL; + DWORD count = 1; + + TRACE("Initializing in mode %u, our window %p, clipping window %p.\n", + filter->mode, filter->window.hwnd, filter->clipping_window); + + if (filter->mode == VMR9Mode_Windowless && !filter->clipping_window) + return S_OK; + + info.Pool = D3DPOOL_DEFAULT; + info.MinBuffers = count; + info.dwWidth = info.szAspectRatio.cx = info.szNativeSize.cx = bitmap_header->biWidth; + info.dwHeight = info.szAspectRatio.cy = info.szNativeSize.cy = bitmap_header->biHeight; + + if (!(filter->surfaces = calloc(count, sizeof(IDirect3DSurface9 *)))) + return E_OUTOFMEMORY; + filter->surface_count = count; + filter->surface_index = 0; + + switch (bitmap_header->biCompression) + { + case BI_RGB: + switch (bitmap_header->biBitCount) + { + case 24: info.Format = D3DFMT_R8G8B8; break; + case 32: info.Format = D3DFMT_X8R8G8B8; break; + default: + FIXME("Unhandled bit depth %u.\n", bitmap_header->biBitCount); + free(filter->surfaces); + return VFW_E_TYPE_NOT_ACCEPTED; + } + + info.dwFlags = VMR9AllocFlag_TextureSurface; + break; + + case mmioFOURCC('N','V','1','2'): + case mmioFOURCC('U','Y','V','Y'): + case mmioFOURCC('Y','U','Y','2'): + case mmioFOURCC('Y','V','1','2'): + info.Format = bitmap_header->biCompression; + info.dwFlags = VMR9AllocFlag_OffscreenSurface; + break; + + default: + WARN("Unhandled video compression %#lx.\n", bitmap_header->biCompression); + free(filter->surfaces); + return VFW_E_TYPE_NOT_ACCEPTED; + } + if (FAILED(hr = initialize_device(filter, &info, count))) + free(filter->surfaces); + return hr; +} + +static void vmr_init_stream(struct strmbase_renderer *iface) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + if (filter->window.hwnd && filter->window.AutoShow) + ShowWindow(filter->window.hwnd, SW_SHOW); +} + +static void vmr_start_stream(struct strmbase_renderer *iface) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + IVMRImagePresenter9_StartPresenting(filter->presenter, filter->cookie); +} + +static void vmr_stop_stream(struct strmbase_renderer *iface) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + if (filter->renderer.filter.state == State_Running) + IVMRImagePresenter9_StopPresenting(filter->presenter, filter->cookie); +} + +static HRESULT vmr_connect(struct strmbase_renderer *iface, const AM_MEDIA_TYPE *mt) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + const BITMAPINFOHEADER *bitmap_header = get_bitmap_header(mt); + HWND window = filter->window.hwnd; + HRESULT hr; + RECT rect; + + SetRect(&rect, 0, 0, bitmap_header->biWidth, bitmap_header->biHeight); + filter->window.src = rect; + + AdjustWindowRectEx(&rect, GetWindowLongW(window, GWL_STYLE), FALSE, + GetWindowLongW(window, GWL_EXSTYLE)); + SetWindowPos(window, NULL, 0, 0, rect.right - rect.left, rect.bottom - rect.top, + SWP_NOMOVE | SWP_NOZORDER | SWP_NOACTIVATE); + GetClientRect(window, &filter->window.dst); + + if (filter->mode + || SUCCEEDED(hr = IVMRFilterConfig_SetRenderingMode(&filter->IVMRFilterConfig_iface, VMRMode_Windowed))) + hr = allocate_surfaces(filter, mt); + + return hr; +} + +static void deallocate_surfaces(struct vmr7 *filter) +{ + if (filter->mode && filter->allocator && filter->presenter) + { + for (DWORD i = 0; i < filter->surface_count; ++i) + IDirect3DSurface9_Release(filter->surfaces[i]); + free(filter->surfaces); + + IVMRSurfaceAllocator9_TerminateDevice(filter->allocator, filter->cookie); + filter->surface_count = 0; + } +} + +static void vmr_disconnect(struct strmbase_renderer *iface) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + deallocate_surfaces(filter); +} + +static void vmr_destroy(struct strmbase_renderer *iface) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + video_window_cleanup(&filter->window); + + if (filter->allocator) + { + IVMRSurfaceAllocator9_TerminateDevice(filter->allocator, filter->cookie); + IVMRSurfaceAllocator9_Release(filter->allocator); + } + if (filter->presenter) + IVMRImagePresenter9_Release(filter->presenter); + + filter->surface_count = 0; + if (filter->device) + { + IDirect3DDevice9_Release(filter->device); + filter->device = NULL; + } + + FreeLibrary(filter->d3d9_module); + strmbase_renderer_cleanup(&filter->renderer); + free(filter); +} + +static HRESULT vmr_query_interface(struct strmbase_renderer *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + if (IsEqualGUID(iid, &IID_IVideoWindow)) + *out = &filter->window.IVideoWindow_iface; + else if (IsEqualGUID(iid, &IID_IBasicVideo)) + *out = &filter->window.IBasicVideo_iface; + else if (IsEqualGUID(iid, &IID_IAMCertifiedOutputProtection)) + *out = &filter->IAMCertifiedOutputProtection_iface; + else if (IsEqualGUID(iid, &IID_IAMFilterMiscFlags)) + *out = &filter->IAMFilterMiscFlags_iface; + else if (IsEqualGUID(iid, &IID_IVMRFilterConfig)) + *out = &filter->IVMRFilterConfig_iface; + else if (IsEqualGUID(iid, &IID_IVMRMonitorConfig)) + *out = &filter->IVMRMonitorConfig_iface; + else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify) && filter->mode == (VMR9Mode)VMRMode_Renderless) + *out = &filter->IVMRSurfaceAllocatorNotify_iface; + else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl) && filter->mode == (VMR9Mode)VMRMode_Windowless) + *out = &filter->IVMRWindowlessControl_iface; + else + return E_NOINTERFACE; + + IUnknown_AddRef((IUnknown *)*out); + return S_OK; +} + +static HRESULT vmr_pin_query_interface(struct strmbase_renderer *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IBaseFilter(&iface->filter.IBaseFilter_iface); + + if (IsEqualGUID(iid, &IID_IAMVideoAccelerator)) + *out = &filter->IAMVideoAccelerator_iface; + else if (IsEqualGUID(iid, &IID_IOverlay)) + *out = &filter->IOverlay_iface; + else + return E_NOINTERFACE; + + IUnknown_AddRef((IUnknown *)*out); + return S_OK; +} + +static const struct strmbase_renderer_ops renderer_ops = +{ + .renderer_query_accept = vmr_query_accept, + .renderer_render = vmr_render, + .renderer_init_stream = vmr_init_stream, + .renderer_start_stream = vmr_start_stream, + .renderer_stop_stream = vmr_stop_stream, + .renderer_connect = vmr_connect, + .renderer_disconnect = vmr_disconnect, + .renderer_destroy = vmr_destroy, + .renderer_query_interface = vmr_query_interface, + .renderer_pin_query_interface = vmr_pin_query_interface, +}; + +static void vmr_get_default_rect(struct video_window *iface, RECT *rect) +{ + struct vmr7 *filter = impl_from_video_window(iface); + const BITMAPINFOHEADER *bitmap_header = get_filter_bitmap_header(filter); + + SetRect(rect, 0, 0, bitmap_header->biWidth, bitmap_header->biHeight); +} + +static HRESULT vmr_get_current_image(struct video_window *iface, LONG *size, LONG *image) +{ + struct vmr7 *filter = impl_from_video_window(iface); + IDirect3DSurface9 *rt = NULL, *surface = NULL; + D3DLOCKED_RECT locked_rect; + IDirect3DDevice9 *device; + unsigned int row_size; + BITMAPINFOHEADER bih; + LONG size_left; + HRESULT hr; + char *dst; + + EnterCriticalSection(&filter->renderer.filter.stream_cs); + device = filter->device; + + bih = *get_filter_bitmap_header(filter); + bih.biSizeImage = bih.biWidth * bih.biHeight * bih.biBitCount / 8; + + if (!image) + { + *size = sizeof(BITMAPINFOHEADER) + bih.biSizeImage; + LeaveCriticalSection(&filter->renderer.filter.stream_cs); + return S_OK; + } + + if (FAILED(hr = IDirect3DDevice9_GetRenderTarget(device, 0, &rt))) + goto out; + + if (FAILED(hr = IDirect3DDevice9_CreateOffscreenPlainSurface(device, bih.biWidth, + bih.biHeight, D3DFMT_X8R8G8B8, D3DPOOL_SYSTEMMEM, &surface, NULL))) + goto out; + + if (FAILED(hr = IDirect3DDevice9_GetRenderTargetData(device, rt, surface))) + goto out; + + if (FAILED(hr = IDirect3DSurface9_LockRect(surface, &locked_rect, NULL, D3DLOCK_READONLY))) + goto out; + + size_left = *size; + memcpy(image, &bih, min(size_left, sizeof(BITMAPINFOHEADER))); + size_left -= sizeof(BITMAPINFOHEADER); + + dst = (char *)image + sizeof(BITMAPINFOHEADER); + row_size = bih.biWidth * bih.biBitCount / 8; + + for (LONG i = 0; i < bih.biHeight && size_left > 0; ++i) + { + memcpy(dst, (char *)locked_rect.pBits + (i * locked_rect.Pitch), min(row_size, size_left)); + dst += row_size; + size_left -= row_size; + } + + IDirect3DSurface9_UnlockRect(surface); + +out: + if (surface) + IDirect3DSurface9_Release(surface); + if (rt) + IDirect3DSurface9_Release(rt); + LeaveCriticalSection(&filter->renderer.filter.stream_cs); + return hr; +} + +static const struct video_window_ops window_ops = +{ + .get_default_rect = vmr_get_default_rect, + .get_current_image = vmr_get_current_image, +}; + +static const IVideoWindowVtbl IVideoWindow_VTable = +{ + BaseControlWindowImpl_QueryInterface, + BaseControlWindowImpl_AddRef, + BaseControlWindowImpl_Release, + BaseControlWindowImpl_GetTypeInfoCount, + BaseControlWindowImpl_GetTypeInfo, + BaseControlWindowImpl_GetIDsOfNames, + BaseControlWindowImpl_Invoke, + BaseControlWindowImpl_put_Caption, + BaseControlWindowImpl_get_Caption, + BaseControlWindowImpl_put_WindowStyle, + BaseControlWindowImpl_get_WindowStyle, + BaseControlWindowImpl_put_WindowStyleEx, + BaseControlWindowImpl_get_WindowStyleEx, + BaseControlWindowImpl_put_AutoShow, + BaseControlWindowImpl_get_AutoShow, + BaseControlWindowImpl_put_WindowState, + BaseControlWindowImpl_get_WindowState, + BaseControlWindowImpl_put_BackgroundPalette, + BaseControlWindowImpl_get_BackgroundPalette, + BaseControlWindowImpl_put_Visible, + BaseControlWindowImpl_get_Visible, + BaseControlWindowImpl_put_Left, + BaseControlWindowImpl_get_Left, + BaseControlWindowImpl_put_Width, + BaseControlWindowImpl_get_Width, + BaseControlWindowImpl_put_Top, + BaseControlWindowImpl_get_Top, + BaseControlWindowImpl_put_Height, + BaseControlWindowImpl_get_Height, + BaseControlWindowImpl_put_Owner, + BaseControlWindowImpl_get_Owner, + BaseControlWindowImpl_put_MessageDrain, + BaseControlWindowImpl_get_MessageDrain, + BaseControlWindowImpl_get_BorderColor, + BaseControlWindowImpl_put_BorderColor, + BaseControlWindowImpl_get_FullScreenMode, + BaseControlWindowImpl_put_FullScreenMode, + BaseControlWindowImpl_SetWindowForeground, + BaseControlWindowImpl_NotifyOwnerMessage, + BaseControlWindowImpl_SetWindowPosition, + BaseControlWindowImpl_GetWindowPosition, + BaseControlWindowImpl_GetMinIdealImageSize, + BaseControlWindowImpl_GetMaxIdealImageSize, + BaseControlWindowImpl_GetRestorePosition, + BaseControlWindowImpl_HideCursor, + BaseControlWindowImpl_IsCursorHidden, +}; + +static HRESULT WINAPI certified_output_protection_QueryInterface( + IAMCertifiedOutputProtection *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IAMCertifiedOutputProtection(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI certified_output_protection_AddRef(IAMCertifiedOutputProtection *iface) +{ + struct vmr7 *filter = impl_from_IAMCertifiedOutputProtection(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI certified_output_protection_Release(IAMCertifiedOutputProtection *iface) +{ + struct vmr7 *filter = impl_from_IAMCertifiedOutputProtection(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static HRESULT WINAPI certified_output_protection_KeyExchange( + IAMCertifiedOutputProtection *iface, GUID *random, BYTE **certificate, DWORD *size) +{ + FIXME("iface %p, random %p, certificate %p, size %p, stub!\n", iface, random, certificate, size); + return VFW_E_NO_COPP_HW; +} + +static HRESULT WINAPI certified_output_protection_SessionSequenceStart( + IAMCertifiedOutputProtection *iface, AMCOPPSignature *signature) +{ + FIXME("iface %p, signature %p, stub!\n", iface, signature); + return VFW_E_NO_COPP_HW; +} + +static HRESULT WINAPI certified_output_protection_ProtectionCommand( + IAMCertifiedOutputProtection *iface, const AMCOPPCommand *cmd) +{ + FIXME("iface %p, cmd %p, stub!\n", iface, cmd); + return VFW_E_NO_COPP_HW; +} + +static HRESULT WINAPI certified_output_protection_ProtectionStatus( + IAMCertifiedOutputProtection *iface, const AMCOPPStatusInput *input, AMCOPPStatusOutput *output) +{ + FIXME("iface %p, input %p, output %p, stub!\n", iface, input, output); + return VFW_E_NO_COPP_HW; +} + +static const IAMCertifiedOutputProtectionVtbl certified_output_protection_vtbl = +{ + certified_output_protection_QueryInterface, + certified_output_protection_AddRef, + certified_output_protection_Release, + certified_output_protection_KeyExchange, + certified_output_protection_SessionSequenceStart, + certified_output_protection_ProtectionCommand, + certified_output_protection_ProtectionStatus, +}; + +static HRESULT WINAPI misc_flags_QueryInterface(IAMFilterMiscFlags *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IAMFilterMiscFlags(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI misc_flags_AddRef(IAMFilterMiscFlags *iface) +{ + struct vmr7 *filter = impl_from_IAMFilterMiscFlags(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI misc_flags_Release(IAMFilterMiscFlags *iface) +{ + struct vmr7 *filter = impl_from_IAMFilterMiscFlags(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI misc_flags_GetMiscFlags(IAMFilterMiscFlags *iface) +{ + return AM_FILTER_MISC_FLAGS_IS_RENDERER; +} + +static const IAMFilterMiscFlagsVtbl misc_flags_vtbl = +{ + misc_flags_QueryInterface, + misc_flags_AddRef, + misc_flags_Release, + misc_flags_GetMiscFlags, +}; + +static HRESULT WINAPI filter_config_QueryInterface(IVMRFilterConfig *iface, REFIID iid, void** out) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI filter_config_AddRef(IVMRFilterConfig *iface) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI filter_config_Release(IVMRFilterConfig *iface) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static HRESULT WINAPI filter_config_SetImageCompositor( + IVMRFilterConfig *iface, IVMRImageCompositor *compositor) +{ + FIXME("iface %p, compositor %p, stub!\n", iface, compositor); + return E_NOTIMPL; +} + +static HRESULT WINAPI filter_config_SetNumberOfStreams(IVMRFilterConfig *iface, DWORD count) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + + FIXME("iface %p, count %lu, stub!\n", iface, count); + + if (!count) + { + WARN("Application requested zero streams; returning E_INVALIDARG.\n"); + return E_INVALIDARG; + } + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + + if (filter->stream_count) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + WARN("Stream count is already set; returning VFW_E_WRONG_STATE.\n"); + return VFW_E_WRONG_STATE; + } + + filter->stream_count = count; + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return S_OK; +} + +static HRESULT WINAPI filter_config_GetNumberOfStreams(IVMRFilterConfig *iface, DWORD *count) +{ + FIXME("iface %p, count %p, stub!\n", iface, count); + return E_NOTIMPL; +} + +static HRESULT WINAPI filter_config_SetRenderingPrefs(IVMRFilterConfig *iface, DWORD flags) +{ + FIXME("iface %p, flags %#lx, stub!\n", iface, flags); + return E_NOTIMPL; +} + +static HRESULT WINAPI filter_config_GetRenderingPrefs(IVMRFilterConfig *iface, DWORD *flags) +{ + FIXME("iface %p, flags %p, stub!\n", iface, flags); + return E_NOTIMPL; +} + +static HRESULT WINAPI filter_config_SetRenderingMode(IVMRFilterConfig *iface, DWORD mode) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + struct default_presenter *default_presenter; + HRESULT hr = S_OK; + + TRACE("filter %p, mode %lu.\n", filter, mode); + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + + if (filter->mode) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return VFW_E_WRONG_STATE; + } + + switch (mode) + { + case VMR9Mode_Windowed: + case VMR9Mode_Windowless: + if (FAILED(hr = default_presenter_create(filter, &default_presenter))) + { + ERR("Failed to create default presenter, hr %#lx.\n", hr); + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; + } + filter->allocator = &default_presenter->IVMRSurfaceAllocator9_iface; + filter->presenter = &default_presenter->IVMRImagePresenter9_iface; + IVMRImagePresenter9_AddRef(filter->presenter); + break; + + case VMR9Mode_Renderless: + break; + + default: + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return E_INVALIDARG; + } + + if (mode != VMR9Mode_Windowed) + video_window_cleanup(&filter->window); + + filter->mode = mode; + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; +} + +static HRESULT WINAPI filter_config_GetRenderingMode(IVMRFilterConfig *iface, DWORD *mode) +{ + struct vmr7 *filter = impl_from_IVMRFilterConfig(iface); + + TRACE("filter %p, mode %p.\n", filter, mode); + + if (!mode) + return E_POINTER; + + if (filter->mode) + *mode = filter->mode; + else + *mode = VMRMode_Windowed; + + return S_OK; +} + +static const IVMRFilterConfigVtbl filter_config_vtbl = +{ + filter_config_QueryInterface, + filter_config_AddRef, + filter_config_Release, + filter_config_SetImageCompositor, + filter_config_SetNumberOfStreams, + filter_config_GetNumberOfStreams, + filter_config_SetRenderingPrefs, + filter_config_GetRenderingPrefs, + filter_config_SetRenderingMode, + filter_config_GetRenderingMode, +}; + +struct get_available_monitors_args +{ + VMRMONITORINFO *info7; + VMR9MonitorInfo *info9; + DWORD capacity; + DWORD count; +}; + +static BOOL CALLBACK get_available_monitors_proc(HMONITOR monitor, HDC dc, RECT *rect, LPARAM ctx) +{ + struct get_available_monitors_args *args = (struct get_available_monitors_args *)ctx; + MONITORINFOEXW mi; + + if (args->info7 || args->info9) + { + + if (!args->capacity) + return FALSE; + + mi.cbSize = sizeof(mi); + if (!GetMonitorInfoW(monitor, (MONITORINFO*)&mi)) + return TRUE; + + /* fill VMRMONITORINFO struct */ + if (args->info7) + { + VMRMONITORINFO *info = args->info7++; + memset(info, 0, sizeof(*info)); + + if (args->count > 0) + { + info->guid.pGUID = &info->guid.GUID; + info->guid.GUID.Data4[7] = args->count; + } + else + info->guid.pGUID = NULL; + + info->rcMonitor = mi.rcMonitor; + info->hMon = monitor; + info->dwFlags = mi.dwFlags; + + lstrcpynW(info->szDevice, mi.szDevice, ARRAY_SIZE(info->szDevice)); + + /* FIXME: how to get these values? */ + info->szDescription[0] = 0; + } + + /* fill VMR9MonitorInfo struct */ + if (args->info9) + { + VMR9MonitorInfo *info = args->info9++; + memset(info, 0, sizeof(*info)); + + info->uDevID = 0; /* FIXME */ + info->rcMonitor = mi.rcMonitor; + info->hMon = monitor; + info->dwFlags = mi.dwFlags; + + lstrcpynW(info->szDevice, mi.szDevice, ARRAY_SIZE(info->szDevice)); + + /* FIXME: how to get these values? */ + info->szDescription[0] = 0; + info->dwVendorId = 0; + info->dwDeviceId = 0; + info->dwSubSysId = 0; + info->dwRevision = 0; + } + + args->capacity--; + } + + args->count++; + return TRUE; +} + +static HRESULT WINAPI monitor_config_QueryInterface(IVMRMonitorConfig *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IVMRMonitorConfig(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI monitor_config_AddRef(IVMRMonitorConfig *iface) +{ + struct vmr7 *filter = impl_from_IVMRMonitorConfig(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI monitor_config_Release(IVMRMonitorConfig *iface) +{ + struct vmr7 *filter = impl_from_IVMRMonitorConfig(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static HRESULT WINAPI monitor_config_SetMonitor(IVMRMonitorConfig *iface, const VMRGUID *guid) +{ + FIXME("iface %p, guid %p, stub!\n", iface, guid); + + if (!guid) + return E_POINTER; + + return S_OK; +} + +static HRESULT WINAPI monitor_config_GetMonitor(IVMRMonitorConfig *iface, VMRGUID *guid) +{ + FIXME("iface %p, guid %p, stub!\n", iface, guid); + + if (!guid) + return E_POINTER; + + guid->pGUID = NULL; /* default DirectDraw device */ + return S_OK; +} + +static HRESULT WINAPI monitor_config_SetDefaultMonitor(IVMRMonitorConfig *iface, const VMRGUID *guid) +{ + FIXME("iface %p, guid %p, stub!\n", iface, guid); + + if (!guid) + return E_POINTER; + + return S_OK; +} + +static HRESULT WINAPI monitor_config_GetDefaultMonitor(IVMRMonitorConfig *iface, VMRGUID *guid) +{ + FIXME("iface %p, guid %p, stub!\n", iface, guid); + + if (!guid) + return E_POINTER; + + guid->pGUID = NULL; /* default DirectDraw device */ + return S_OK; +} + +static HRESULT WINAPI monitor_config_GetAvailableMonitors(IVMRMonitorConfig *iface, + VMRMONITORINFO *info, DWORD capacity, DWORD *count) +{ + struct vmr7 *filter = impl_from_IVMRMonitorConfig(iface); + struct get_available_monitors_args args; + + TRACE("filter %p, info %p, capacity %lu, count %p.\n", filter, info, capacity, count); + + if (!count) + return E_POINTER; + + if (info && !capacity) + return E_INVALIDARG; + + args.info7 = info; + args.info9 = NULL; + args.capacity = capacity; + args.count = 0; + EnumDisplayMonitors(NULL, NULL, get_available_monitors_proc, (LPARAM)&args); + + *count = args.count; + return S_OK; +} + +static const IVMRMonitorConfigVtbl monitor_config_vtbl = +{ + monitor_config_QueryInterface, + monitor_config_AddRef, + monitor_config_Release, + monitor_config_SetMonitor, + monitor_config_GetMonitor, + monitor_config_SetDefaultMonitor, + monitor_config_GetDefaultMonitor, + monitor_config_GetAvailableMonitors, +}; + +static HRESULT WINAPI windowless_control_QueryInterface(IVMRWindowlessControl *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI windowless_control_AddRef(IVMRWindowlessControl *iface) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI windowless_control_Release(IVMRWindowlessControl *iface) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static HRESULT WINAPI windowless_control_GetNativeVideoSize(IVMRWindowlessControl *iface, + LONG *width, LONG *height, LONG *aspect_width, LONG *aspect_height) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + const BITMAPINFOHEADER *bitmap_header = get_filter_bitmap_header(filter); + + TRACE("filter %p, width %p, height %p, aspect_width %p, aspect_height %p.\n", + filter, width, height, aspect_width, aspect_height); + + if (!width || !height) + return E_POINTER; + + *width = bitmap_header->biWidth; + *height = bitmap_header->biHeight; + if (aspect_width) + *aspect_width = bitmap_header->biWidth; + if (aspect_height) + *aspect_height = bitmap_header->biHeight; + + return S_OK; +} + +static HRESULT WINAPI windowless_control_GetMinIdealVideoSize( + IVMRWindowlessControl *iface, LONG *width, LONG *height) +{ + FIXME("iface %p, width %p, height %p, stub!\n", iface, width, height); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_GetMaxIdealVideoSize( + IVMRWindowlessControl *iface, LONG *width, LONG *height) +{ + FIXME("iface %p, width %p, height %p, stub!\n", iface, width, height); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_SetVideoPosition( + IVMRWindowlessControl *iface, const RECT *source, const RECT *dest) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + + TRACE("filter %p, source %s, dest %s.\n", filter, wine_dbgstr_rect(source), wine_dbgstr_rect(dest)); + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + + if (source) + filter->window.src = *source; + if (dest) + filter->window.dst = *dest; + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + + return S_OK; +} + +static HRESULT WINAPI windowless_control_GetVideoPosition( + IVMRWindowlessControl *iface, RECT *source, RECT *dest) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + + TRACE("filter %p, source %p, dest %p.\n", filter, source, dest); + + if (source) + *source = filter->window.src; + + if (dest) + *dest = filter->window.dst; + + return S_OK; +} + +static HRESULT WINAPI windowless_control_GetAspectRatioMode(IVMRWindowlessControl *iface, DWORD *mode) +{ + FIXME("iface %p, mode %p, stub!\n", iface, mode); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_SetAspectRatioMode(IVMRWindowlessControl *iface, DWORD mode) +{ + FIXME("iface %p, mode %#lx, stub!\n", iface, mode); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_SetVideoClippingWindow(IVMRWindowlessControl *iface, HWND window) +{ + struct vmr7 *filter = impl_from_IVMRWindowlessControl(iface); + HRESULT hr; + + TRACE("filter %p, window %p.\n", filter, window); + + if (!IsWindow(window)) + { + WARN("Invalid window %p, returning E_INVALIDARG.\n", window); + return E_INVALIDARG; + } + + EnterCriticalSection(&filter->renderer.filter.filter_cs); + + if (filter->renderer.sink.pin.peer) + { + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + WARN("Attempt to set the clipping window while connected; returning VFW_E_WRONG_STATE.\n"); + return VFW_E_WRONG_STATE; + } + + filter->clipping_window = window; + + hr = IVMRFilterConfig_SetNumberOfStreams(&filter->IVMRFilterConfig_iface, 4); + + LeaveCriticalSection(&filter->renderer.filter.filter_cs); + return hr; +} + +static HRESULT WINAPI windowless_control_RepaintVideo( + IVMRWindowlessControl *iface, HWND window, HDC dc) +{ + FIXME("iface %p, window %p, dc %p, stub!\n", iface, window, dc); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_DisplayModeChanged(IVMRWindowlessControl *iface) +{ + FIXME("iface %p, stub!\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_GetCurrentImage(IVMRWindowlessControl *iface, BYTE **image) +{ + FIXME("iface %p, image %p, stub!\n", iface, image); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_SetBorderColor(IVMRWindowlessControl *iface, COLORREF color) +{ + FIXME("iface %p, color %#08lx, stub!\n", iface, color); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_GetBorderColor(IVMRWindowlessControl *iface, COLORREF *color) +{ + FIXME("iface %p, color %p, stub!\n", iface, color); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_SetColorKey(IVMRWindowlessControl *iface, COLORREF color) +{ + FIXME("iface %p, color %#08lx, stub!\n", iface, color); + return E_NOTIMPL; +} + +static HRESULT WINAPI windowless_control_GetColorKey(IVMRWindowlessControl *iface, COLORREF *color) +{ + FIXME("iface %p, color %p, stub!\n", iface, color); + return E_NOTIMPL; +} + +static const IVMRWindowlessControlVtbl windowless_control_vtbl = +{ + windowless_control_QueryInterface, + windowless_control_AddRef, + windowless_control_Release, + windowless_control_GetNativeVideoSize, + windowless_control_GetMinIdealVideoSize, + windowless_control_GetMaxIdealVideoSize, + windowless_control_SetVideoPosition, + windowless_control_GetVideoPosition, + windowless_control_GetAspectRatioMode, + windowless_control_SetAspectRatioMode, + windowless_control_SetVideoClippingWindow, + windowless_control_RepaintVideo, + windowless_control_DisplayModeChanged, + windowless_control_GetCurrentImage, + windowless_control_SetBorderColor, + windowless_control_GetBorderColor, + windowless_control_SetColorKey, + windowless_control_GetColorKey, +}; + +static HRESULT WINAPI surface_allocator_notify_QueryInterface( + IVMRSurfaceAllocatorNotify *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IVMRSurfaceAllocatorNotify(iface); + + return IUnknown_QueryInterface(filter->renderer.filter.outer_unk, iid, out); +} + +static ULONG WINAPI surface_allocator_notify_AddRef(IVMRSurfaceAllocatorNotify *iface) +{ + struct vmr7 *filter = impl_from_IVMRSurfaceAllocatorNotify(iface); + + return IUnknown_AddRef(filter->renderer.filter.outer_unk); +} + +static ULONG WINAPI surface_allocator_notify_Release(IVMRSurfaceAllocatorNotify *iface) +{ + struct vmr7 *filter = impl_from_IVMRSurfaceAllocatorNotify(iface); + + return IUnknown_Release(filter->renderer.filter.outer_unk); +} + +static HRESULT WINAPI surface_allocator_notify_AdviseSurfaceAllocator( + IVMRSurfaceAllocatorNotify *iface, DWORD_PTR cookie, IVMRSurfaceAllocator *allocator) +{ + FIXME("iface %p, cookie %#Ix, allocator %p, stub!\n", iface, cookie, allocator); + return E_NOTIMPL; +} + +static HRESULT WINAPI surface_allocator_notify_SetDDrawDevice( + IVMRSurfaceAllocatorNotify *iface, IDirectDraw7 *device, HMONITOR monitor) +{ + FIXME("iface %p, device %p, monitor %p, stub!\n", iface, device, monitor); + return E_NOTIMPL; +} + +static HRESULT WINAPI surface_allocator_notify_ChangeDDrawDevice( + IVMRSurfaceAllocatorNotify *iface, IDirectDraw7 *device, HMONITOR monitor) +{ + FIXME("iface %p, device %p, monitor %p, stub!\n", iface, device, monitor); + return E_NOTIMPL; +} + +static HRESULT WINAPI surface_allocator_notify_RestoreDDrawSurfaces(IVMRSurfaceAllocatorNotify *iface) +{ + FIXME("iface %p, stub!\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI surface_allocator_notify_NotifyEvent( + IVMRSurfaceAllocatorNotify *iface, LONG code, LONG_PTR param1, LONG_PTR param2) +{ + FIXME("iface %p, code %#lx, param1 %#Ix, param2 %#Ix, stub!\n", iface, code, param1, param2); + return E_NOTIMPL; +} + +static HRESULT WINAPI surface_allocator_notify_SetBorderColor( + IVMRSurfaceAllocatorNotify *iface, COLORREF color) +{ + FIXME("iface %p, color %#08lx, stub!\n", iface, color); + return E_NOTIMPL; +} + +static const IVMRSurfaceAllocatorNotifyVtbl surface_allocator_notify_vtbl = +{ + surface_allocator_notify_QueryInterface, + surface_allocator_notify_AddRef, + surface_allocator_notify_Release, + surface_allocator_notify_AdviseSurfaceAllocator, + surface_allocator_notify_SetDDrawDevice, + surface_allocator_notify_ChangeDDrawDevice, + surface_allocator_notify_RestoreDDrawSurfaces, + surface_allocator_notify_NotifyEvent, + surface_allocator_notify_SetBorderColor, +}; + +static void vmr_set_d3d_device(struct vmr7 *filter, IDirect3DDevice9 *device, HMONITOR monitor) +{ + if (filter->device) + IDirect3DDevice9_Release(filter->device); + filter->device = device; + IDirect3DDevice9_AddRef(device); +} + +static HRESULT vmr_allocate_d3d9_surfaces(struct vmr7 *filter, + VMR9AllocationInfo *info, DWORD *count, IDirect3DSurface9 **surfaces) +{ + HRESULT hr = S_OK; + DWORD i; + + TRACE("filter %p, info %p, count %p, surfaces %p.\n", filter, count, info, surfaces); + + if (!info || !count || !surfaces) + return E_POINTER; + + TRACE("Flags %#lx, size %lux%lu, format %u (%#x), pool %u, minimum buffers %lu.\n", + info->dwFlags, info->dwWidth, info->dwHeight, + info->Format, info->Format, info->Pool, info->MinBuffers); + + if ((info->dwFlags & VMR9AllocFlag_TextureSurface) + && (info->dwFlags & VMR9AllocFlag_OffscreenSurface)) + { + WARN("Invalid flags specified; returning E_INVALIDARG.\n"); + return E_INVALIDARG; + } + + if (!info->Format) + { + IDirect3DSurface9 *backbuffer; + D3DSURFACE_DESC desc; + + IDirect3DDevice9_GetBackBuffer(filter->device, 0, 0, + D3DBACKBUFFER_TYPE_MONO, &backbuffer); + IDirect3DSurface9_GetDesc(backbuffer, &desc); + IDirect3DSurface9_Release(backbuffer); + info->Format = desc.Format; + } + + if (!*count || *count < info->MinBuffers) + { + WARN("%lu surfaces requested (minimum %lu); returning E_INVALIDARG.\n", + *count, info->MinBuffers); + return E_INVALIDARG; + } + + if (!filter->device) + { + WARN("No Direct3D device; returning VFW_E_WRONG_STATE.\n"); + return VFW_E_WRONG_STATE; + } + + if (info->dwFlags == VMR9AllocFlag_OffscreenSurface) + { + for (i = 0; i < *count; ++i) + { + if (FAILED(hr = IDirect3DDevice9_CreateOffscreenPlainSurface(filter->device, + info->dwWidth, info->dwHeight, info->Format, info->Pool, &surfaces[i], NULL))) + break; + } + } + else if (info->dwFlags == VMR9AllocFlag_TextureSurface) + { + for (i = 0; i < *count; ++i) + { + IDirect3DTexture9 *texture; + + if (FAILED(hr = IDirect3DDevice9_CreateTexture(filter->device, info->dwWidth, + info->dwHeight, 1, D3DUSAGE_DYNAMIC, info->Format, info->Pool, &texture, NULL))) + break; + IDirect3DTexture9_GetSurfaceLevel(texture, 0, &surfaces[i]); + IDirect3DTexture9_Release(texture); + } + } + else if (info->dwFlags == VMR9AllocFlag_3DRenderTarget) + { + for (i = 0; i < *count; ++i) + { + if (FAILED(hr = IDirect3DDevice9_CreateRenderTarget(filter->device, + info->dwWidth, info->dwHeight, info->Format, + D3DMULTISAMPLE_NONE, 0, FALSE, &surfaces[i], NULL))) + break; + } + } + else + { + FIXME("Unhandled flags %#lx.\n", info->dwFlags); + return E_NOTIMPL; + } + + if (FAILED(hr)) + WARN("%lu/%lu surfaces allocated, hr %#lx.\n", i, *count, hr); + + if (i >= info->MinBuffers) + { + hr = S_OK; + *count = i; + } + else + { + for (; i > 0; --i) + IDirect3DSurface9_Release(surfaces[i - 1]); + *count = 0; + } + return hr; +} + +static struct vmr7 *impl_from_IAMVideoAccelerator(IAMVideoAccelerator *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IAMVideoAccelerator_iface); +} + +static HRESULT WINAPI video_accelerator_QueryInterface(IAMVideoAccelerator *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IAMVideoAccelerator(iface); + + return IPin_QueryInterface(&filter->renderer.sink.pin.IPin_iface, iid, out); +} + +static ULONG WINAPI video_accelerator_AddRef(IAMVideoAccelerator *iface) +{ + struct vmr7 *filter = impl_from_IAMVideoAccelerator(iface); + + return IPin_AddRef(&filter->renderer.sink.pin.IPin_iface); +} + +static ULONG WINAPI video_accelerator_Release(IAMVideoAccelerator *iface) +{ + struct vmr7 *filter = impl_from_IAMVideoAccelerator(iface); + + return IPin_Release(&filter->renderer.sink.pin.IPin_iface); +} + +static HRESULT WINAPI video_accelerator_GetVideoAcceleratorGUIDs( + IAMVideoAccelerator *iface, DWORD *count, GUID *accelerators) +{ + FIXME("iface %p, count %p, accelerators %p, stub!\n", iface, count, accelerators); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_GetUncompFormatsSupported(IAMVideoAccelerator *iface, + const GUID *accelerator, DWORD *count, DDPIXELFORMAT *formats) +{ + FIXME("iface %p, accelerator %s, count %p, formats %p, stub!\n", + iface, debugstr_guid(accelerator), count, formats); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_GetInternalMemInfo(IAMVideoAccelerator *iface, + const GUID *accelerator, const AMVAUncompDataInfo *format_info, AMVAInternalMemInfo *mem_info) +{ + FIXME("iface %p, accelerator %s, format_info %p, mem_info %p, stub!\n", + iface, debugstr_guid(accelerator), format_info, mem_info); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_GetCompBufferInfo(IAMVideoAccelerator *iface, + const GUID *accelerator, const AMVAUncompDataInfo *uncompressed_info, + DWORD *compressed_info_count, AMVACompBufferInfo *compressed_infos) +{ + FIXME("iface %p, accelerator %s, uncompressed_info %p, compressed_info_count %p, compressed_infos %p, stub!\n", + iface, debugstr_guid(accelerator), uncompressed_info, compressed_info_count, compressed_infos); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_GetInternalCompBufferInfo( + IAMVideoAccelerator *iface, DWORD *count, AMVACompBufferInfo *infos) +{ + FIXME("iface %p, count %p, infos %p, stub!\n", iface, count, infos); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_BeginFrame(IAMVideoAccelerator *iface, const AMVABeginFrameInfo *info) +{ + FIXME("iface %p, info %p, stub!\n", iface, info); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_EndFrame(IAMVideoAccelerator *iface, const AMVAEndFrameInfo *info) +{ + FIXME("iface %p, info %p, stub!\n", iface, info); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_GetBuffer(IAMVideoAccelerator *iface, + DWORD type_index, DWORD buffer_index, BOOL read_only, void **buffer, LONG *stride) +{ + FIXME("iface %p, type_index %lu, buffer_index %lu, read_only %d, buffer %p, stride %p, stub!\n", + iface, type_index, buffer_index, read_only, buffer, stride); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_ReleaseBuffer( + IAMVideoAccelerator *iface, DWORD type_index, DWORD buffer_index) +{ + FIXME("iface %p, type_index %lu, buffer_index %lu, stub!\n", iface, type_index, buffer_index); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_Execute(IAMVideoAccelerator *iface, + DWORD function, void *in_data, DWORD in_size, void *out_data, + DWORD out_size, DWORD buffer_count, const AMVABUFFERINFO *buffers) +{ + FIXME("iface %p, function %#lx, in_data %p, in_size %lu," + " out_data %p, out_size %lu, buffer_count %lu, buffers %p, stub!\n", + iface, function, in_data, in_size, out_data, out_size, buffer_count, buffers); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_QueryRenderStatus(IAMVideoAccelerator *iface, + DWORD type_index, DWORD buffer_index, DWORD flags) +{ + FIXME("iface %p, type_index %lu, buffer_index %lu, flags %#lx, stub!\n", + iface, type_index, buffer_index, flags); + return E_NOTIMPL; +} + +static HRESULT WINAPI video_accelerator_DisplayFrame( + IAMVideoAccelerator *iface, DWORD index, IMediaSample *sample) +{ + FIXME("iface %p, index %lu, sample %p, stub!\n", iface, index, sample); + return E_NOTIMPL; +} + +static const IAMVideoAcceleratorVtbl video_accelerator_vtbl = +{ + video_accelerator_QueryInterface, + video_accelerator_AddRef, + video_accelerator_Release, + video_accelerator_GetVideoAcceleratorGUIDs, + video_accelerator_GetUncompFormatsSupported, + video_accelerator_GetInternalMemInfo, + video_accelerator_GetCompBufferInfo, + video_accelerator_GetInternalCompBufferInfo, + video_accelerator_BeginFrame, + video_accelerator_EndFrame, + video_accelerator_GetBuffer, + video_accelerator_ReleaseBuffer, + video_accelerator_Execute, + video_accelerator_QueryRenderStatus, + video_accelerator_DisplayFrame, +}; + +static struct vmr7 *impl_from_IOverlay(IOverlay *iface) +{ + return CONTAINING_RECORD(iface, struct vmr7, IOverlay_iface); +} + +static HRESULT WINAPI overlay_QueryInterface(IOverlay *iface, REFIID iid, void **out) +{ + struct vmr7 *filter = impl_from_IOverlay(iface); + + return IPin_QueryInterface(&filter->renderer.sink.pin.IPin_iface, iid, out); +} + +static ULONG WINAPI overlay_AddRef(IOverlay *iface) +{ + struct vmr7 *filter = impl_from_IOverlay(iface); + + return IPin_AddRef(&filter->renderer.sink.pin.IPin_iface); +} + +static ULONG WINAPI overlay_Release(IOverlay *iface) +{ + struct vmr7 *filter = impl_from_IOverlay(iface); + + return IPin_Release(&filter->renderer.sink.pin.IPin_iface); +} + +static HRESULT WINAPI overlay_GetPalette(IOverlay *iface, DWORD *count, PALETTEENTRY **palette) +{ + FIXME("iface %p, count %p, palette %p, stub!\n", iface, count, palette); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_SetPalette(IOverlay *iface, DWORD count, PALETTEENTRY *palette) +{ + FIXME("iface %p, count %lu, palette %p, stub!\n", iface, count, palette); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_GetDefaultColorKey(IOverlay *iface, COLORKEY *key) +{ + FIXME("iface %p, key %p, stub!\n", iface, key); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_GetColorKey(IOverlay *iface, COLORKEY *key) +{ + FIXME("iface %p, key %p, stub!\n", iface, key); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_SetColorKey(IOverlay *iface, COLORKEY *key) +{ + FIXME("iface %p, key %p, stub!\n", iface, key); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_GetWindowHandle(IOverlay *iface, HWND *window) +{ + struct vmr7 *filter = impl_from_IOverlay(iface); + + TRACE("filter %p, window %p.\n", filter, window); + + if (!filter->window.hwnd) + return VFW_E_WRONG_STATE; + + *window = filter->window.hwnd; + return S_OK; +} + +static HRESULT WINAPI overlay_GetClipList(IOverlay *iface, RECT *source, RECT *dest, RGNDATA **region) +{ + FIXME("iface %p, source %p, dest %p, region %p, stub!\n", iface, source, dest, region); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_GetVideoPosition(IOverlay *iface, RECT *source, RECT *dest) +{ + FIXME("iface %p, source %p, dest %p, stub!\n", iface, source, dest); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_Advise(IOverlay *iface, IOverlayNotify *sink, DWORD flags) +{ + FIXME("iface %p, sink %p, flags %#lx, stub!\n", iface, sink, flags); + return E_NOTIMPL; +} + +static HRESULT WINAPI overlay_Unadvise(IOverlay *iface) +{ + FIXME("iface %p, stub!\n", iface); + return E_NOTIMPL; +} + +static const IOverlayVtbl overlay_vtbl = +{ + overlay_QueryInterface, + overlay_AddRef, + overlay_Release, + overlay_GetPalette, + overlay_SetPalette, + overlay_GetDefaultColorKey, + overlay_GetColorKey, + overlay_SetColorKey, + overlay_GetWindowHandle, + overlay_GetClipList, + overlay_GetVideoPosition, + overlay_Advise, + overlay_Unadvise, +}; + +HRESULT vmr7_create(IUnknown *outer, IUnknown **out) +{ + struct vmr7 *object; + HRESULT hr; + + if (!(object = calloc(1, sizeof(*object)))) + return E_OUTOFMEMORY; + + object->d3d9_module = LoadLibraryA("d3d9.dll"); + if (!object->d3d9_module) + { + WARN("Could not load d3d9.dll\n"); + free(object); + return VFW_E_DDRAW_CAPS_NOT_SUITABLE; + } + + strmbase_renderer_init(&object->renderer, outer, &CLSID_VideoMixingRenderer, L"VMR Input0", &renderer_ops); + object->IAMCertifiedOutputProtection_iface.lpVtbl = &certified_output_protection_vtbl; + object->IAMFilterMiscFlags_iface.lpVtbl = &misc_flags_vtbl; + object->IVMRFilterConfig_iface.lpVtbl = &filter_config_vtbl; + object->IVMRMonitorConfig_iface.lpVtbl = &monitor_config_vtbl; + object->IVMRSurfaceAllocatorNotify_iface.lpVtbl = &surface_allocator_notify_vtbl; + object->IVMRWindowlessControl_iface.lpVtbl = &windowless_control_vtbl; + + object->IAMVideoAccelerator_iface.lpVtbl = &video_accelerator_vtbl; + object->IOverlay_iface.lpVtbl = &overlay_vtbl; + + video_window_init(&object->window, &IVideoWindow_VTable, + &object->renderer.filter, &object->renderer.sink.pin, &window_ops); + + if (FAILED(hr = video_window_create_window(&object->window))) + { + video_window_cleanup(&object->window); + strmbase_renderer_cleanup(&object->renderer); + FreeLibrary(object->d3d9_module); + free(object); + return hr; + } + + object->mixing_prefs = MixerPref9_NoDecimation | MixerPref9_ARAdjustXorY + | MixerPref9_BiLinearFiltering | MixerPref9_RenderTargetRGB; + + TRACE("Created VMR %p.\n", object); + *out = &object->renderer.filter.IUnknown_inner; + return S_OK; +} + +static HRESULT WINAPI VMR9_ImagePresenter_QueryInterface(IVMRImagePresenter9 *iface, REFIID iid, void **out) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + + TRACE("presenter %p, iid %s, out %p.\n", presenter, debugstr_guid(iid), out); + + if (IsEqualIID(iid, &IID_IUnknown) || IsEqualIID(iid, &IID_IVMRImagePresenter9)) + *out = &presenter->IVMRImagePresenter9_iface; + else if (IsEqualIID(iid, &IID_IVMRSurfaceAllocator9)) + *out = &presenter->IVMRSurfaceAllocator9_iface; + else + { + *out = NULL; + WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(iid)); + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown *)*out); + return S_OK; +} + +static ULONG WINAPI VMR9_ImagePresenter_AddRef(IVMRImagePresenter9 *iface) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + ULONG refcount = InterlockedIncrement(&presenter->refcount); + + TRACE("%p increasing refcount to %lu.\n", presenter, refcount); + + return refcount; +} + +static ULONG WINAPI VMR9_ImagePresenter_Release(IVMRImagePresenter9 *iface) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + ULONG refcount = InterlockedDecrement(&presenter->refcount); + + TRACE("%p decreasing refcount to %lu.\n", presenter, refcount); + + if (!refcount) + { + IDirect3D9_Release(presenter->d3d9); + + for (DWORD i = 0; i < presenter->surface_count; ++i) + { + IDirect3DSurface9 *surface = presenter->surfaces[i]; + + if (surface) + IDirect3DSurface9_Release(surface); + } + + if (presenter->device) + IDirect3DDevice9_Release(presenter->device); + free(presenter->surfaces); + presenter->surfaces = NULL; + presenter->surface_count = 0; + free(presenter); + return 0; + } + return refcount; +} + +static HRESULT WINAPI VMR9_ImagePresenter_StartPresenting(IVMRImagePresenter9 *iface, DWORD_PTR cookie) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + + TRACE("presenter %p, cookie %#Ix.\n", presenter, cookie); + + return S_OK; +} + +static HRESULT WINAPI VMR9_ImagePresenter_StopPresenting(IVMRImagePresenter9 *iface, DWORD_PTR cookie) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + + TRACE("presenter %p, cookie %#Ix.\n", presenter, cookie); + + return S_OK; +} + +static HRESULT WINAPI VMR9_ImagePresenter_PresentImage(IVMRImagePresenter9 *iface, + DWORD_PTR cookie, VMR9PresentationInfo *info) +{ + struct default_presenter *presenter = impl_from_IVMRImagePresenter9(iface); + IDirect3DDevice9 *device = presenter->device; + const struct vmr7 *filter = presenter->vmr; + const RECT src = filter->window.src; + IDirect3DSurface9 *backbuffer; + RECT dst = filter->window.dst; + HRESULT hr; + + TRACE("presenter %p, cookie %#Ix, info %p.\n", presenter, cookie, info); + + /* presenter might happen if we don't have active focus (eg on a different virtual desktop) */ + if (!device) + return S_OK; + + if (FAILED(hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, + D3DCOLOR_XRGB(0, 0, 0), 1.0f, 0))) + ERR("Failed to clear, hr %#lx.\n", hr); + + if (FAILED(hr = IDirect3DDevice9_BeginScene(device))) + ERR("Failed to begin scene, hr %#lx.\n", hr); + + if (FAILED(hr = IDirect3DDevice9_GetBackBuffer(device, 0, 0, D3DBACKBUFFER_TYPE_MONO, &backbuffer))) + { + ERR("Failed to get backbuffer, hr %#lx.\n", hr); + return hr; + } + + if (FAILED(hr = IDirect3DDevice9_StretchRect(device, info->lpSurf, NULL, backbuffer, NULL, D3DTEXF_POINT))) + ERR("Failed to blit image, hr %#lx.\n", hr); + IDirect3DSurface9_Release(backbuffer); + + if (FAILED(hr = IDirect3DDevice9_EndScene(device))) + ERR("Failed to end scene, hr %#lx.\n", hr); + + if (filter->aspect_mode == VMR9ARMode_LetterBox) + { + unsigned int src_width = src.right - src.left, src_height = src.bottom - src.top; + unsigned int dst_width = dst.right - dst.left, dst_height = dst.bottom - dst.top; + + if (src_width * dst_height > dst_width * src_height) + { + /* src is "wider" than dst. */ + unsigned int dst_center = (dst.top + dst.bottom) / 2; + unsigned int scaled_height = src_height * dst_width / src_width; + + dst.top = dst_center - scaled_height / 2; + dst.bottom = dst.top + scaled_height; + } + else if (src_width * dst_height < dst_width * src_height) + { + /* src is "taller" than dst. */ + unsigned int dst_center = (dst.left + dst.right) / 2; + unsigned int scaled_width = src_width * dst_height / src_height; + + dst.left = dst_center - scaled_width / 2; + dst.right = dst.left + scaled_width; + } + } + + if (FAILED(hr = IDirect3DDevice9_Present(device, &src, &dst, NULL, NULL))) + ERR("Failed to present, hr %#lx.\n", hr); + + return S_OK; +} + +static const IVMRImagePresenter9Vtbl VMR9_ImagePresenter = +{ + VMR9_ImagePresenter_QueryInterface, + VMR9_ImagePresenter_AddRef, + VMR9_ImagePresenter_Release, + VMR9_ImagePresenter_StartPresenting, + VMR9_ImagePresenter_StopPresenting, + VMR9_ImagePresenter_PresentImage +}; + +static HRESULT WINAPI VMR9_SurfaceAllocator_QueryInterface(IVMRSurfaceAllocator9 *iface, REFIID iid, void **out) +{ + struct default_presenter *presenter = impl_from_IVMRSurfaceAllocator9(iface); + + return IVMRImagePresenter9_QueryInterface(&presenter->IVMRImagePresenter9_iface, iid, out); +} + +static ULONG WINAPI VMR9_SurfaceAllocator_AddRef(IVMRSurfaceAllocator9 *iface) +{ + struct default_presenter *presenter = impl_from_IVMRSurfaceAllocator9(iface); + + return IVMRImagePresenter9_AddRef(&presenter->IVMRImagePresenter9_iface); +} + +static ULONG WINAPI VMR9_SurfaceAllocator_Release(IVMRSurfaceAllocator9 *iface) +{ + struct default_presenter *presenter = impl_from_IVMRSurfaceAllocator9(iface); + + return IVMRImagePresenter9_Release(&presenter->IVMRImagePresenter9_iface); +} + +static void adjust_surface_size(const D3DCAPS9 *caps, VMR9AllocationInfo *info) +{ + unsigned int width, height; + + /* There are no restrictions on the size of offscreen surfaces. */ + if (!(info->dwFlags & VMR9AllocFlag_TextureSurface)) + return; + + if (!(caps->TextureCaps & D3DPTEXTURECAPS_POW2) || (caps->TextureCaps & D3DPTEXTURECAPS_SQUAREONLY)) + { + width = info->dwWidth; + height = info->dwHeight; + } + else + { + width = height = 1; + while (width < info->dwWidth) + width *= 2; + + while (height < info->dwHeight) + height *= 2; + FIXME("Non-power-of-two textures are not supported.\n"); + } + + if (caps->TextureCaps & D3DPTEXTURECAPS_SQUAREONLY) + { + if (height > width) + width = height; + else + height = width; + FIXME("Rectangular textures are not supported.\n"); + } + + info->dwHeight = height; + info->dwWidth = width; +} + +static UINT adapter_index_from_hwnd(IDirect3D9 *d3d9, HWND hwnd, HMONITOR *ret_monitor) +{ + UINT adapter_index; + HMONITOR monitor; + + monitor = MonitorFromWindow(hwnd, MONITOR_DEFAULTTONULL); + if (!monitor) + adapter_index = 0; + else + { + for (adapter_index = 0; adapter_index < IDirect3D9_GetAdapterCount(d3d9); ++adapter_index) + { + if (monitor == IDirect3D9_GetAdapterMonitor(d3d9, adapter_index)) + break; + } + if (adapter_index >= IDirect3D9_GetAdapterCount(d3d9)) + adapter_index = 0; + } + if (ret_monitor) + *ret_monitor = monitor; + return adapter_index; +} + +static HRESULT WINAPI VMR9_SurfaceAllocator_InitializeDevice(IVMRSurfaceAllocator9 *iface, + DWORD_PTR cookie, VMR9AllocationInfo *info, DWORD *count) +{ + struct default_presenter *presenter = impl_from_IVMRSurfaceAllocator9(iface); + D3DPRESENT_PARAMETERS present_parameters = {0}; + IDirect3DDevice9 *device; + DWORD adapter_index; + D3DCAPS9 caps; + HWND window; + HRESULT hr; + + TRACE("presenter %p, cookie %#Ix, info %p, count %p.\n", presenter, cookie, info, count); + + presenter->info = *info; + + if (presenter->vmr->mode == VMR9Mode_Windowed) + window = presenter->vmr->window.hwnd; + else + window = presenter->vmr->clipping_window; + + adapter_index = adapter_index_from_hwnd(presenter->d3d9, window, &presenter->monitor); + + present_parameters.Windowed = TRUE; + present_parameters.hDeviceWindow = window; + present_parameters.SwapEffect = D3DSWAPEFFECT_COPY; + present_parameters.BackBufferWidth = info->dwWidth; + present_parameters.BackBufferHeight = info->dwHeight; + + hr = IDirect3D9_CreateDevice(presenter->d3d9, adapter_index, D3DDEVTYPE_HAL, + NULL, D3DCREATE_MIXED_VERTEXPROCESSING, &present_parameters, &device); + if (FAILED(hr)) + { + ERR("Failed to create device, hr %#lx.\n", hr); + return hr; + } + + IDirect3DDevice9_GetDeviceCaps(device, &caps); + if (!(caps.DevCaps2 & D3DDEVCAPS2_CAN_STRETCHRECT_FROM_TEXTURES)) + { + WARN("Device does not support blitting from textures.\n"); + IDirect3DDevice9_Release(device); + return VFW_E_DDRAW_CAPS_NOT_SUITABLE; + } + + presenter->device = device; + vmr_set_d3d_device(presenter->vmr, presenter->device, presenter->monitor); + + if (!(presenter->surfaces = calloc(*count, sizeof(IDirect3DSurface9 *)))) + return E_OUTOFMEMORY; + + adjust_surface_size(&caps, info); + + if (FAILED(hr = vmr_allocate_d3d9_surfaces(presenter->vmr, info, count, presenter->surfaces))) + { + ERR("Failed to allocate surfaces, hr %#lx.\n", hr); + IVMRSurfaceAllocator9_TerminateDevice(presenter->vmr->allocator, presenter->vmr->cookie); + return hr; + } + + presenter->surface_count = *count; + + return S_OK; +} + +static HRESULT WINAPI VMR9_SurfaceAllocator_TerminateDevice(IVMRSurfaceAllocator9 *iface, DWORD_PTR cookie) +{ + TRACE("iface %p, cookie %#Ix.\n", iface, cookie); + + return S_OK; +} + +static HRESULT WINAPI VMR9_SurfaceAllocator_GetSurface(IVMRSurfaceAllocator9 *iface, + DWORD_PTR cookie, DWORD index, DWORD flags, IDirect3DSurface9 **surface) +{ + struct default_presenter *presenter = impl_from_IVMRSurfaceAllocator9(iface); + + if (!presenter->device) + { + ERR("No device.\n"); + return E_FAIL; + } + + if (index >= presenter->surface_count) + { + ERR("Index %lu exceeds surface count %lu.\n", index, presenter->surface_count); + return E_FAIL; + } + *surface = presenter->surfaces[index]; + IDirect3DSurface9_AddRef(*surface); + + return S_OK; +} + +static HRESULT WINAPI VMR9_SurfaceAllocator_AdviseNotify(IVMRSurfaceAllocator9 *iface, + IVMRSurfaceAllocatorNotify9 *notify) +{ + ERR("Unexpected call.\n"); + return S_OK; +} + +static const IVMRSurfaceAllocator9Vtbl VMR9_SurfaceAllocator = +{ + VMR9_SurfaceAllocator_QueryInterface, + VMR9_SurfaceAllocator_AddRef, + VMR9_SurfaceAllocator_Release, + VMR9_SurfaceAllocator_InitializeDevice, + VMR9_SurfaceAllocator_TerminateDevice, + VMR9_SurfaceAllocator_GetSurface, + VMR9_SurfaceAllocator_AdviseNotify, +}; + +static IDirect3D9 *init_d3d9(HMODULE d3d9_handle) +{ + IDirect3D9 * (__stdcall *d3d9_create)(UINT version); + + d3d9_create = (void *)GetProcAddress(d3d9_handle, "Direct3DCreate9"); + if (!d3d9_create) + return NULL; + + return d3d9_create(D3D_SDK_VERSION); +} + +static HRESULT default_presenter_create(struct vmr7 *parent, struct default_presenter **presenter) +{ + struct default_presenter *object; + + if (!(object = calloc(1, sizeof(*object)))) + return E_OUTOFMEMORY; + + object->d3d9 = init_d3d9(parent->d3d9_module); + if (!object->d3d9) + { + WARN("Could not initialize d3d9.dll\n"); + free(object); + return VFW_E_DDRAW_CAPS_NOT_SUITABLE; + } + + object->IVMRImagePresenter9_iface.lpVtbl = &VMR9_ImagePresenter; + object->IVMRSurfaceAllocator9_iface.lpVtbl = &VMR9_SurfaceAllocator; + + object->refcount = 1; + object->vmr = parent; + + TRACE("Created default presenter %p.\n", object); + *presenter = object; + return S_OK; +} diff --git a/dlls/quartz/vmr9.c b/dlls/quartz/vmr9.c index 38380e05b76..9d95cda9def 100644 --- a/dlls/quartz/vmr9.c +++ b/dlls/quartz/vmr9.c @@ -1,5 +1,5 @@ /* - * Video Mixing Renderer for dx9 + * Video Mixing Renderer for Direct3D 9 * * Copyright 2004 Christian Costa * Copyright 2008 Maarten Lankhorst @@ -62,15 +62,11 @@ struct quartz_vmr IAMCertifiedOutputProtection IAMCertifiedOutputProtection_iface; IAMFilterMiscFlags IAMFilterMiscFlags_iface; IVMRAspectRatioControl9 IVMRAspectRatioControl9_iface; - IVMRFilterConfig IVMRFilterConfig_iface; IVMRFilterConfig9 IVMRFilterConfig9_iface; IVMRMixerBitmap9 IVMRMixerBitmap9_iface; IVMRMixerControl9 IVMRMixerControl9_iface; - IVMRMonitorConfig IVMRMonitorConfig_iface; IVMRMonitorConfig9 IVMRMonitorConfig9_iface; - IVMRSurfaceAllocatorNotify IVMRSurfaceAllocatorNotify_iface; IVMRSurfaceAllocatorNotify9 IVMRSurfaceAllocatorNotify9_iface; - IVMRWindowlessControl IVMRWindowlessControl_iface; IVMRWindowlessControl9 IVMRWindowlessControl9_iface;

/* Devil May Cry 3 releases the last IBaseFilter reference while still @@ -114,11 +110,6 @@ static const BITMAPINFOHEADER *get_filter_bitmap_header(const struct quartz_vmr return get_bitmap_header(&filter->renderer.sink.pin.mt); }

-static inline BOOL is_vmr9(const struct quartz_vmr *filter) -{ - return IsEqualGUID(&filter->renderer.filter.clsid, &CLSID_VideoMixingRenderer9); -} - static inline struct quartz_vmr *impl_from_video_window(struct video_window *iface) { return CONTAINING_RECORD(iface, struct quartz_vmr, window); @@ -134,41 +125,21 @@ static inline struct quartz_vmr *impl_from_IAMFilterMiscFlags(IAMFilterMiscFlags return CONTAINING_RECORD(iface, struct quartz_vmr, IAMFilterMiscFlags_iface); }

-static inline struct quartz_vmr *impl_from_IVMRFilterConfig(IVMRFilterConfig *iface) -{ - return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRFilterConfig_iface); -} - static inline struct quartz_vmr *impl_from_IVMRFilterConfig9(IVMRFilterConfig9 *iface) { return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRFilterConfig9_iface); }

-static inline struct quartz_vmr *impl_from_IVMRMonitorConfig(IVMRMonitorConfig *iface) -{ - return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRMonitorConfig_iface); -} - static inline struct quartz_vmr *impl_from_IVMRMonitorConfig9(IVMRMonitorConfig9 *iface) { return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRMonitorConfig9_iface); }

-static inline struct quartz_vmr *impl_from_IVMRSurfaceAllocatorNotify(IVMRSurfaceAllocatorNotify *iface) -{ - return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRSurfaceAllocatorNotify_iface); -} - static inline struct quartz_vmr *impl_from_IVMRSurfaceAllocatorNotify9(IVMRSurfaceAllocatorNotify9 *iface) { return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRSurfaceAllocatorNotify9_iface); }

-static inline struct quartz_vmr *impl_from_IVMRWindowlessControl(IVMRWindowlessControl *iface) -{ - return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRWindowlessControl_iface); -} - static inline struct quartz_vmr *impl_from_IVMRWindowlessControl9(IVMRWindowlessControl9 *iface) { return CONTAINING_RECORD(iface, struct quartz_vmr, IVMRWindowlessControl9_iface); @@ -403,42 +374,6 @@ static HRESULT allocate_surfaces(struct quartz_vmr *filter, const AM_MEDIA_TYPE filter->num_surfaces = count; filter->cur_surface = 0;

- if (!is_vmr9(filter)) - { - switch (bmiheader->biCompression) - { - case BI_RGB: - switch (bmiheader->biBitCount) - { - case 24: info.Format = D3DFMT_R8G8B8; break; - case 32: info.Format = D3DFMT_X8R8G8B8; break; - default: - FIXME("Unhandled bit depth %u.\n", bmiheader->biBitCount); - free(filter->surfaces); - return VFW_E_TYPE_NOT_ACCEPTED; - } - - info.dwFlags = VMR9AllocFlag_TextureSurface; - break; - - case mmioFOURCC('N','V','1','2'): - case mmioFOURCC('U','Y','V','Y'): - case mmioFOURCC('Y','U','Y','2'): - case mmioFOURCC('Y','V','1','2'): - info.Format = bmiheader->biCompression; - info.dwFlags = VMR9AllocFlag_OffscreenSurface; - break; - - default: - WARN("Unhandled video compression %#lx.\n", bmiheader->biCompression); - free(filter->surfaces); - return VFW_E_TYPE_NOT_ACCEPTED; - } - if (FAILED(hr = initialize_device(filter, &info, count))) - free(filter->surfaces); - return hr; - } - for (i = 0; i < ARRAY_SIZE(formats); ++i) { if (IsEqualGUID(&mt->subtype, formats[i].subtype)) @@ -579,32 +514,19 @@ static HRESULT vmr_query_interface(struct strmbase_renderer *iface, REFIID iid, *out = &filter->IAMCertifiedOutputProtection_iface; else if (IsEqualGUID(iid, &IID_IAMFilterMiscFlags)) *out = &filter->IAMFilterMiscFlags_iface; - else if (IsEqualGUID(iid, &IID_IVMRAspectRatioControl9) && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRAspectRatioControl9)) *out = &filter->IVMRAspectRatioControl9_iface; - else if (IsEqualGUID(iid, &IID_IVMRFilterConfig) && !is_vmr9(filter)) - *out = &filter->IVMRFilterConfig_iface; - else if (IsEqualGUID(iid, &IID_IVMRFilterConfig9) && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRFilterConfig9)) *out = &filter->IVMRFilterConfig9_iface; - else if (IsEqualGUID(iid, &IID_IVMRMixerBitmap9) && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRMixerBitmap9)) *out = &filter->IVMRMixerBitmap9_iface; - else if (IsEqualGUID(iid, &IID_IVMRMixerControl9) && is_vmr9(filter) && filter->stream_count) + else if (IsEqualGUID(iid, &IID_IVMRMixerControl9) && filter->stream_count) *out = &filter->IVMRMixerControl9_iface; - else if (IsEqualGUID(iid, &IID_IVMRMonitorConfig) && !is_vmr9(filter)) - *out = &filter->IVMRMonitorConfig_iface; - else if (IsEqualGUID(iid, &IID_IVMRMonitorConfig9) - && filter->mode != VMR9Mode_Renderless && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRMonitorConfig9) && filter->mode != VMR9Mode_Renderless) *out = &filter->IVMRMonitorConfig9_iface; - else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify) - && filter->mode == (VMR9Mode)VMRMode_Renderless && !is_vmr9(filter)) - *out = &filter->IVMRSurfaceAllocatorNotify_iface; - else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify9) - && filter->mode == VMR9Mode_Renderless && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify9) && filter->mode == VMR9Mode_Renderless) *out = &filter->IVMRSurfaceAllocatorNotify9_iface; - else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl) - && filter->mode == (VMR9Mode)VMRMode_Windowless && !is_vmr9(filter)) - *out = &filter->IVMRWindowlessControl_iface; - else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl9) - && filter->mode == VMR9Mode_Windowless && is_vmr9(filter)) + else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl9) && filter->mode == VMR9Mode_Windowless) *out = &filter->IVMRWindowlessControl9_iface; else return E_NOINTERFACE; @@ -861,161 +783,6 @@ static const IAMFilterMiscFlagsVtbl IAMFilterMiscFlags_Vtbl = { AMFilterMiscFlags_GetMiscFlags };

-static HRESULT WINAPI VMR7FilterConfig_QueryInterface(IVMRFilterConfig *iface, REFIID riid, - void** ppv) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - return IUnknown_QueryInterface(This->renderer.filter.outer_unk, riid, ppv); -} - -static ULONG WINAPI VMR7FilterConfig_AddRef(IVMRFilterConfig *iface) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - return IUnknown_AddRef(This->renderer.filter.outer_unk); -} - -static ULONG WINAPI VMR7FilterConfig_Release(IVMRFilterConfig *iface) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - return IUnknown_Release(This->renderer.filter.outer_unk); -} - -static HRESULT WINAPI VMR7FilterConfig_SetImageCompositor(IVMRFilterConfig *iface, - IVMRImageCompositor *compositor) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, compositor); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7FilterConfig_SetNumberOfStreams(IVMRFilterConfig *iface, DWORD count) -{ - struct quartz_vmr *filter = impl_from_IVMRFilterConfig(iface); - - FIXME("iface %p, count %lu, stub!\n", iface, count); - - if (!count) - { - WARN("Application requested zero streams; returning E_INVALIDARG.\n"); - return E_INVALIDARG; - } - - EnterCriticalSection(&filter->renderer.filter.filter_cs); - - if (filter->stream_count) - { - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - WARN("Stream count is already set; returning VFW_E_WRONG_STATE.\n"); - return VFW_E_WRONG_STATE; - } - - filter->stream_count = count; - - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return S_OK; -} - -static HRESULT WINAPI VMR7FilterConfig_GetNumberOfStreams(IVMRFilterConfig *iface, DWORD *max) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, max); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7FilterConfig_SetRenderingPrefs(IVMRFilterConfig *iface, DWORD flags) -{ - struct quartz_vmr *filter = impl_from_IVMRFilterConfig(iface); - - FIXME("filter %p, flags %#lx, stub!\n", filter, flags); - - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7FilterConfig_GetRenderingPrefs(IVMRFilterConfig *iface, DWORD *renderflags) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, renderflags); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7FilterConfig_SetRenderingMode(IVMRFilterConfig *iface, DWORD mode) -{ - struct quartz_vmr *filter = impl_from_IVMRFilterConfig(iface); - struct default_presenter *default_presenter; - HRESULT hr = S_OK; - - TRACE("filter %p, mode %lu.\n", filter, mode); - - EnterCriticalSection(&filter->renderer.filter.filter_cs); - if (filter->mode) - { - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return VFW_E_WRONG_STATE; - } - - switch (mode) - { - case VMRMode_Windowed: - case VMRMode_Windowless: - if (FAILED(hr = default_presenter_create(filter, &default_presenter))) - { - ERR("Failed to create default presenter, hr %#lx.\n", hr); - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return hr; - } - filter->allocator = &default_presenter->IVMRSurfaceAllocator9_iface; - filter->presenter = &default_presenter->IVMRImagePresenter9_iface; - IVMRImagePresenter9_AddRef(filter->presenter); - - IVMRSurfaceAllocator9_AdviseNotify(filter->allocator, &filter->IVMRSurfaceAllocatorNotify9_iface); - break; - case VMRMode_Renderless: - break; - default: - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return E_INVALIDARG; - } - - if (mode != VMRMode_Windowed) - video_window_cleanup(&filter->window); - - filter->mode = mode; - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return hr; -} - -static HRESULT WINAPI VMR7FilterConfig_GetRenderingMode(IVMRFilterConfig *iface, DWORD *mode) -{ - struct quartz_vmr *This = impl_from_IVMRFilterConfig(iface); - - TRACE("(%p/%p)->(%p)\n", iface, This, mode); - if (!mode) return E_POINTER; - - if (This->mode) - *mode = This->mode; - else - *mode = VMRMode_Windowed; - - return S_OK; -} - -static const IVMRFilterConfigVtbl VMR7_FilterConfig_Vtbl = -{ - VMR7FilterConfig_QueryInterface, - VMR7FilterConfig_AddRef, - VMR7FilterConfig_Release, - VMR7FilterConfig_SetImageCompositor, - VMR7FilterConfig_SetNumberOfStreams, - VMR7FilterConfig_GetNumberOfStreams, - VMR7FilterConfig_SetRenderingPrefs, - VMR7FilterConfig_GetRenderingPrefs, - VMR7FilterConfig_SetRenderingMode, - VMR7FilterConfig_GetRenderingMode -}; - struct get_available_monitors_args { VMRMONITORINFO *info7; @@ -1091,113 +858,6 @@ static BOOL CALLBACK get_available_monitors_proc(HMONITOR hmon, HDC hdc, LPRECT return TRUE; }

-static HRESULT WINAPI VMR7MonitorConfig_QueryInterface(IVMRMonitorConfig *iface, REFIID riid, - LPVOID * ppv) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - return IUnknown_QueryInterface(This->renderer.filter.outer_unk, riid, ppv); -} - -static ULONG WINAPI VMR7MonitorConfig_AddRef(IVMRMonitorConfig *iface) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - return IUnknown_AddRef(This->renderer.filter.outer_unk); -} - -static ULONG WINAPI VMR7MonitorConfig_Release(IVMRMonitorConfig *iface) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - return IUnknown_Release(This->renderer.filter.outer_unk); -} - -static HRESULT WINAPI VMR7MonitorConfig_SetMonitor(IVMRMonitorConfig *iface, const VMRGUID *pGUID) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, pGUID); - - if (!pGUID) - return E_POINTER; - - return S_OK; -} - -static HRESULT WINAPI VMR7MonitorConfig_GetMonitor(IVMRMonitorConfig *iface, VMRGUID *pGUID) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, pGUID); - - if (!pGUID) - return E_POINTER; - - pGUID->pGUID = NULL; /* default DirectDraw device */ - return S_OK; -} - -static HRESULT WINAPI VMR7MonitorConfig_SetDefaultMonitor(IVMRMonitorConfig *iface, - const VMRGUID *pGUID) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, pGUID); - - if (!pGUID) - return E_POINTER; - - return S_OK; -} - -static HRESULT WINAPI VMR7MonitorConfig_GetDefaultMonitor(IVMRMonitorConfig *iface, VMRGUID *pGUID) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - - FIXME("(%p/%p)->(%p) stub\n", iface, This, pGUID); - - if (!pGUID) - return E_POINTER; - - pGUID->pGUID = NULL; /* default DirectDraw device */ - return S_OK; -} - -static HRESULT WINAPI VMR7MonitorConfig_GetAvailableMonitors(IVMRMonitorConfig *iface, - VMRMONITORINFO *info, DWORD arraysize, - DWORD *numdev) -{ - struct quartz_vmr *This = impl_from_IVMRMonitorConfig(iface); - struct get_available_monitors_args args; - - TRACE("filter %p, info %p, arraysize %lu, numdev %p.\n", This, info, arraysize, numdev); - - if (!numdev) - return E_POINTER; - - if (info && arraysize == 0) - return E_INVALIDARG; - - args.info7 = info; - args.info9 = NULL; - args.arraysize = arraysize; - args.numdev = 0; - EnumDisplayMonitors(NULL, NULL, get_available_monitors_proc, (LPARAM)&args); - - *numdev = args.numdev; - return S_OK; -} - -static const IVMRMonitorConfigVtbl VMR7_MonitorConfig_Vtbl = -{ - VMR7MonitorConfig_QueryInterface, - VMR7MonitorConfig_AddRef, - VMR7MonitorConfig_Release, - VMR7MonitorConfig_SetMonitor, - VMR7MonitorConfig_GetMonitor, - VMR7MonitorConfig_SetDefaultMonitor, - VMR7MonitorConfig_GetDefaultMonitor, - VMR7MonitorConfig_GetAvailableMonitors -}; - static HRESULT WINAPI VMR9MonitorConfig_QueryInterface(IVMRMonitorConfig9 *iface, REFIID riid, LPVOID * ppv) { @@ -1464,229 +1124,6 @@ static const IVMRFilterConfig9Vtbl VMR9_FilterConfig_Vtbl = VMR9FilterConfig_GetRenderingMode };

-static HRESULT WINAPI VMR7WindowlessControl_QueryInterface(IVMRWindowlessControl *iface, REFIID riid, - LPVOID * ppv) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - return IUnknown_QueryInterface(This->renderer.filter.outer_unk, riid, ppv); -} - -static ULONG WINAPI VMR7WindowlessControl_AddRef(IVMRWindowlessControl *iface) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - return IUnknown_AddRef(This->renderer.filter.outer_unk); -} - -static ULONG WINAPI VMR7WindowlessControl_Release(IVMRWindowlessControl *iface) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - return IUnknown_Release(This->renderer.filter.outer_unk); -} - -static HRESULT WINAPI VMR7WindowlessControl_GetNativeVideoSize(IVMRWindowlessControl *iface, - LONG *width, LONG *height, LONG *aspect_width, LONG *aspect_height) -{ - struct quartz_vmr *filter = impl_from_IVMRWindowlessControl(iface); - const BITMAPINFOHEADER *bmiheader = get_filter_bitmap_header(filter); - - TRACE("filter %p, width %p, height %p, aspect_width %p, aspect_height %p.\n", - filter, width, height, aspect_width, aspect_height); - - if (!width || !height) - return E_POINTER; - - *width = bmiheader->biWidth; - *height = bmiheader->biHeight; - if (aspect_width) - *aspect_width = bmiheader->biWidth; - if (aspect_height) - *aspect_height = bmiheader->biHeight; - - return S_OK; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetMinIdealVideoSize(IVMRWindowlessControl *iface, - LONG *width, LONG *height) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetMaxIdealVideoSize(IVMRWindowlessControl *iface, - LONG *width, LONG *height) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_SetVideoPosition(IVMRWindowlessControl *iface, - const RECT *source, const RECT *dest) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - TRACE("(%p/%p)->(%p, %p)\n", iface, This, source, dest); - - EnterCriticalSection(&This->renderer.filter.filter_cs); - - if (source) - This->window.src = *source; - if (dest) - This->window.dst = *dest; - - LeaveCriticalSection(&This->renderer.filter.filter_cs); - - return S_OK; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetVideoPosition(IVMRWindowlessControl *iface, - RECT *source, RECT *dest) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - if (source) - *source = This->window.src; - - if (dest) - *dest = This->window.dst; - - FIXME("(%p/%p)->(%p/%p) stub\n", iface, This, source, dest); - return S_OK; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetAspectRatioMode(IVMRWindowlessControl *iface, - DWORD *mode) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_SetAspectRatioMode(IVMRWindowlessControl *iface, - DWORD mode) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_SetVideoClippingWindow(IVMRWindowlessControl *iface, HWND window) -{ - struct quartz_vmr *filter = impl_from_IVMRWindowlessControl(iface); - HRESULT hr; - - TRACE("filter %p, window %p.\n", filter, window); - - if (!IsWindow(window)) - { - WARN("Invalid window %p, returning E_INVALIDARG.\n", window); - return E_INVALIDARG; - } - - EnterCriticalSection(&filter->renderer.filter.filter_cs); - - if (filter->renderer.sink.pin.peer) - { - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - WARN("Attempt to set the clipping window while connected; returning VFW_E_WRONG_STATE.\n"); - return VFW_E_WRONG_STATE; - } - - filter->clipping_window = window; - - hr = IVMRFilterConfig_SetNumberOfStreams(&filter->IVMRFilterConfig_iface, 4); - - LeaveCriticalSection(&filter->renderer.filter.filter_cs); - return hr; -} - -static HRESULT WINAPI VMR7WindowlessControl_RepaintVideo(IVMRWindowlessControl *iface, - HWND hwnd, HDC hdc) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_DisplayModeChanged(IVMRWindowlessControl *iface) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetCurrentImage(IVMRWindowlessControl *iface, - BYTE **dib) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_SetBorderColor(IVMRWindowlessControl *iface, - COLORREF color) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetBorderColor(IVMRWindowlessControl *iface, - COLORREF *color) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_SetColorKey(IVMRWindowlessControl *iface, COLORREF color) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7WindowlessControl_GetColorKey(IVMRWindowlessControl *iface, COLORREF *color) -{ - struct quartz_vmr *This = impl_from_IVMRWindowlessControl(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static const IVMRWindowlessControlVtbl VMR7_WindowlessControl_Vtbl = -{ - VMR7WindowlessControl_QueryInterface, - VMR7WindowlessControl_AddRef, - VMR7WindowlessControl_Release, - VMR7WindowlessControl_GetNativeVideoSize, - VMR7WindowlessControl_GetMinIdealVideoSize, - VMR7WindowlessControl_GetMaxIdealVideoSize, - VMR7WindowlessControl_SetVideoPosition, - VMR7WindowlessControl_GetVideoPosition, - VMR7WindowlessControl_GetAspectRatioMode, - VMR7WindowlessControl_SetAspectRatioMode, - VMR7WindowlessControl_SetVideoClippingWindow, - VMR7WindowlessControl_RepaintVideo, - VMR7WindowlessControl_DisplayModeChanged, - VMR7WindowlessControl_GetCurrentImage, - VMR7WindowlessControl_SetBorderColor, - VMR7WindowlessControl_GetBorderColor, - VMR7WindowlessControl_SetColorKey, - VMR7WindowlessControl_GetColorKey -}; - static HRESULT WINAPI VMR9WindowlessControl_QueryInterface(IVMRWindowlessControl9 *iface, REFIID riid, LPVOID * ppv) { struct quartz_vmr *This = impl_from_IVMRWindowlessControl9(iface); @@ -1912,92 +1349,6 @@ static const IVMRWindowlessControl9Vtbl VMR9_WindowlessControl_Vtbl = VMR9WindowlessControl_GetBorderColor };

-static HRESULT WINAPI VMR7SurfaceAllocatorNotify_QueryInterface(IVMRSurfaceAllocatorNotify *iface, - REFIID riid, LPVOID * ppv) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - return IUnknown_QueryInterface(This->renderer.filter.outer_unk, riid, ppv); -} - -static ULONG WINAPI VMR7SurfaceAllocatorNotify_AddRef(IVMRSurfaceAllocatorNotify *iface) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - return IUnknown_AddRef(This->renderer.filter.outer_unk); -} - -static ULONG WINAPI VMR7SurfaceAllocatorNotify_Release(IVMRSurfaceAllocatorNotify *iface) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - return IUnknown_Release(This->renderer.filter.outer_unk); -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_AdviseSurfaceAllocator(IVMRSurfaceAllocatorNotify *iface, - DWORD_PTR id, - IVMRSurfaceAllocator *alloc) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_SetDDrawDevice(IVMRSurfaceAllocatorNotify *iface, - IDirectDraw7 *device, HMONITOR monitor) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_ChangeDDrawDevice(IVMRSurfaceAllocatorNotify *iface, - IDirectDraw7 *device, HMONITOR monitor) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_RestoreDDrawSurfaces(IVMRSurfaceAllocatorNotify *iface) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_NotifyEvent(IVMRSurfaceAllocatorNotify *iface, LONG code, - LONG_PTR param1, LONG_PTR param2) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static HRESULT WINAPI VMR7SurfaceAllocatorNotify_SetBorderColor(IVMRSurfaceAllocatorNotify *iface, - COLORREF clrBorder) -{ - struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify(iface); - - FIXME("(%p/%p)->(...) stub\n", iface, This); - return E_NOTIMPL; -} - -static const IVMRSurfaceAllocatorNotifyVtbl VMR7_SurfaceAllocatorNotify_Vtbl = -{ - VMR7SurfaceAllocatorNotify_QueryInterface, - VMR7SurfaceAllocatorNotify_AddRef, - VMR7SurfaceAllocatorNotify_Release, - VMR7SurfaceAllocatorNotify_AdviseSurfaceAllocator, - VMR7SurfaceAllocatorNotify_SetDDrawDevice, - VMR7SurfaceAllocatorNotify_ChangeDDrawDevice, - VMR7SurfaceAllocatorNotify_RestoreDDrawSurfaces, - VMR7SurfaceAllocatorNotify_NotifyEvent, - VMR7SurfaceAllocatorNotify_SetBorderColor -}; - static HRESULT WINAPI VMR9SurfaceAllocatorNotify_QueryInterface(IVMRSurfaceAllocatorNotify9 *iface, REFIID riid, LPVOID * ppv) { struct quartz_vmr *This = impl_from_IVMRSurfaceAllocatorNotify9(iface); @@ -2756,7 +2107,7 @@ static const IOverlayVtbl overlay_vtbl = overlay_Unadvise, };

-static HRESULT vmr_create(IUnknown *outer, IUnknown **out, const CLSID *clsid) +HRESULT vmr9_create(IUnknown *outer, IUnknown **out) { struct quartz_vmr *object; HRESULT hr; @@ -2772,19 +2123,15 @@ static HRESULT vmr_create(IUnknown *outer, IUnknown **out, const CLSID *clsid) return VFW_E_DDRAW_CAPS_NOT_SUITABLE; }

- strmbase_renderer_init(&object->renderer, outer, clsid, L"VMR Input0", &renderer_ops); + strmbase_renderer_init(&object->renderer, outer, &CLSID_VideoMixingRenderer9, L"VMR Input0", &renderer_ops); object->IAMCertifiedOutputProtection_iface.lpVtbl = &IAMCertifiedOutputProtection_Vtbl; object->IAMFilterMiscFlags_iface.lpVtbl = &IAMFilterMiscFlags_Vtbl; object->IVMRAspectRatioControl9_iface.lpVtbl = &aspect_ratio_control9_vtbl; - object->IVMRFilterConfig_iface.lpVtbl = &VMR7_FilterConfig_Vtbl; object->IVMRFilterConfig9_iface.lpVtbl = &VMR9_FilterConfig_Vtbl; object->IVMRMixerBitmap9_iface.lpVtbl = &mixer_bitmap9_vtbl; object->IVMRMixerControl9_iface.lpVtbl = &mixer_control9_vtbl; - object->IVMRMonitorConfig_iface.lpVtbl = &VMR7_MonitorConfig_Vtbl; object->IVMRMonitorConfig9_iface.lpVtbl = &VMR9_MonitorConfig_Vtbl; - object->IVMRSurfaceAllocatorNotify_iface.lpVtbl = &VMR7_SurfaceAllocatorNotify_Vtbl; object->IVMRSurfaceAllocatorNotify9_iface.lpVtbl = &VMR9_SurfaceAllocatorNotify_Vtbl; - object->IVMRWindowlessControl_iface.lpVtbl = &VMR7_WindowlessControl_Vtbl; object->IVMRWindowlessControl9_iface.lpVtbl = &VMR9_WindowlessControl_Vtbl;

object->IAMVideoAccelerator_iface.lpVtbl = &video_accelerator_vtbl; @@ -2810,17 +2157,6 @@ static HRESULT vmr_create(IUnknown *outer, IUnknown **out, const CLSID *clsid) return S_OK; }

-HRESULT vmr7_create(IUnknown *outer, IUnknown **out) -{ - return vmr_create(outer, out, &CLSID_VideoMixingRenderer); -} - -HRESULT vmr9_create(IUnknown *outer, IUnknown **out) -{ - return vmr_create(outer, out, &CLSID_VideoMixingRenderer9); -} - - static HRESULT WINAPI VMR9_ImagePresenter_QueryInterface(IVMRImagePresenter9 *iface, REFIID riid, void **ppv) { struct default_presenter *This = impl_from_IVMRImagePresenter9(iface);

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

Zebediah Figura

7:54 p.m.

New subject: [PATCH 6/6] quartz: Specify the mode as a VMRMode.

From: Zebediah Figura zfigura@codeweavers.com

--- dlls/quartz/vmr7.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/dlls/quartz/vmr7.c b/dlls/quartz/vmr7.c index 8f8d6d4e89c..4770543b614 100644 --- a/dlls/quartz/vmr7.c +++ b/dlls/quartz/vmr7.c @@ -69,7 +69,7 @@ struct vmr7 DWORD stream_count; DWORD mixing_prefs;

- VMR9Mode mode; + VMRMode mode;

HMODULE d3d9_module;

@@ -312,7 +312,7 @@ static HRESULT allocate_surfaces(struct vmr7 *filter, const AM_MEDIA_TYPE *mt) TRACE("Initializing in mode %u, our window %p, clipping window %p.\n", filter->mode, filter->window.hwnd, filter->clipping_window);

- if (filter->mode == VMR9Mode_Windowless && !filter->clipping_window) + if (filter->mode == VMRMode_Windowless && !filter->clipping_window) return S_OK;

info.Pool = D3DPOOL_DEFAULT; @@ -468,9 +468,9 @@ static HRESULT vmr_query_interface(struct strmbase_renderer *iface, REFIID iid, *out = &filter->IVMRFilterConfig_iface; else if (IsEqualGUID(iid, &IID_IVMRMonitorConfig)) *out = &filter->IVMRMonitorConfig_iface; - else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify) && filter->mode == (VMR9Mode)VMRMode_Renderless) + else if (IsEqualGUID(iid, &IID_IVMRSurfaceAllocatorNotify) && filter->mode == VMRMode_Renderless) *out = &filter->IVMRSurfaceAllocatorNotify_iface; - else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl) && filter->mode == (VMR9Mode)VMRMode_Windowless) + else if (IsEqualGUID(iid, &IID_IVMRWindowlessControl) && filter->mode == VMRMode_Windowless) *out = &filter->IVMRWindowlessControl_iface; else return E_NOINTERFACE; @@ -821,8 +821,8 @@ static HRESULT WINAPI filter_config_SetRenderingMode(IVMRFilterConfig *iface, DW

switch (mode) { - case VMR9Mode_Windowed: - case VMR9Mode_Windowless: + case VMRMode_Windowed: + case VMRMode_Windowless: if (FAILED(hr = default_presenter_create(filter, &default_presenter))) { ERR("Failed to create default presenter, hr %#lx.\n", hr); @@ -834,7 +834,7 @@ static HRESULT WINAPI filter_config_SetRenderingMode(IVMRFilterConfig *iface, DW IVMRImagePresenter9_AddRef(filter->presenter); break;

- case VMR9Mode_Renderless: + case VMRMode_Renderless: break;

default: @@ -842,7 +842,7 @@ static HRESULT WINAPI filter_config_SetRenderingMode(IVMRFilterConfig *iface, DW return E_INVALIDARG; }

- if (mode != VMR9Mode_Windowed) + if (mode != VMRMode_Windowed) video_window_cleanup(&filter->window);

filter->mode = mode; @@ -1987,7 +1987,7 @@ static HRESULT WINAPI VMR9_SurfaceAllocator_InitializeDevice(IVMRSurfaceAllocato

presenter->info = *info;

- if (presenter->vmr->mode == VMR9Mode_Windowed) + if (presenter->vmr->mode == VMRMode_Windowed) window = presenter->vmr->window.hwnd; else window = presenter->vmr->clipping_window;

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4623

428

Age (days ago)

428

Last active (days ago)

wine-gitlab@winehq.org

6 comments

2 participants

tags (0)

participants (2)

Zebediah Figura
Zebediah Figura (＠zfigura)