Re: [PATCH v4 0/1] MR9423: ntdll: Warn when environment block is too large, instead of removing it
there would be a clear message pointing out the issue
I don't want to accuse you of https://xkcd.com/2501/, but the average user doesn't launch Wine from the terminal, and may not know what environment variables are (if they blindly follow guides, they won't understand that the log is related to their issue).
as opposed to an obscure crash [it actually isn't a crash, it's an error message]
Which is what the logs of my MR are about (which I could make more specific so that they explicitly specify EA app).
So, back to the beginning: better to not change anything and add a logs that explain an old problem, or to add a workaround and add logs to explain new problems created by it? Due to all the reasoning I already gave, I'd prefer the former.
Now, I know you may accuse me of https://xkcd.com/1172/, but
To me it seems like an improvement.
let's consider the effect of the change to the population of users who have a large environment block: - They don't use EA App -> The change may only be negative - They do use EA App -> The change is positive... but still has the negative side effects (so it's a sidegrade, not an upgrade)
-
Martino Fontana (＠tinozzo123)