Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/quartz/tests/mpegvideo.c:
> - HRESULT hr = CoCreateInstance(&CLSID_CMpegVideoCodec, NULL, CLSCTX_INPROC_SERVER,
> -
>        &IID_IBaseFilter, (void **)&filter);
> - ok(hr == S_OK, "Got hr %#lx.\n", hr);
> - return filter;
>
> +}
> -
>
> +static inline BOOL compare_media_types(const AM_MEDIA_TYPE *a, const AM_MEDIA_TYPE *b)
> +{
> - return !memcmp(a, b, offsetof(AM_MEDIA_TYPE, pbFormat))
> -
>        && !memcmp(a->pbFormat, b->pbFormat, a->cbFormat);
>
> +}
> -
>
> +enum video_type_t {
> - vt_yv12, vt_y41p, vt_yuy2, vt_uyvy,
> - vt_rgb24, vt_rgb32, vt_rgb565, vt_rgb555, vt_rgb8,
>
> +};

Usually enum values are capitalized; also, _t is usually reserved for typedefs. That said, do we even want this enum? Is there any instance where we shouldn't just iterate over the whole array?

Two of these formats are todo, but I think something like "todo_wine_if (i == 1 || i == 8)" would be fine.