[PATCH v2 0/2] MR4510: comctl32,dsdmo: Some FIXME/ERR once stuff.

[Aida Jonikienė (＠DodoGTA)]

--
  v2: dsdmo: Only print effect_inplace_Process() FIXME once.
      comctl32: Only print TREEVIEW_HandleTimer() ERR once.

https://gitlab.winehq.org/wine/wine/-/merge_requests/4510

[PATCH v2 1/2] comctl32: Only print TREEVIEW_HandleTimer() ERR once.

[Aida Jonikienė]

From: Aida Jonikienė

Older versions of Roblox trigger this quite a bit and it's annoying
to me so let's only print it once.
---
 dlls/comctl32/treeview.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/comctl32/treeview.c b/dlls/comctl32/treeview.c
index c531ad75370..036afd15c69 100644
--- a/dlls/comctl32/treeview.c
+++ b/dlls/comctl32/treeview.c
@@ -4116,9 +4116,11 @@ TREEVIEW_EndEditLabelNow(TREEVIEW_INFO *infoPtr, BOOL bCancel)
 static LRESULT
 TREEVIEW_HandleTimer(TREEVIEW_INFO *infoPtr, WPARAM wParam)
 {
+    static unsigned int once;
+
     if (wParam != TV_EDIT_TIMER)
     {
-	ERR("got unknown timer\n");
+	if (!once++) ERR("got unknown timer %Id\n", wParam);
    return 1;
     }

[PATCH v2 2/2] dsdmo: Only print effect_inplace_Process() FIXME once.

[Aida Jonikienė]

From: Aida Jonikienė

GTA San Andreas really spams this message in certain situations
(which clears my terminal's scrollback) so only print it once.
---
 dlls/dsdmo/main.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/dlls/dsdmo/main.c b/dlls/dsdmo/main.c
index 0879c4e0516..769f040c790 100644
--- a/dlls/dsdmo/main.c
+++ b/dlls/dsdmo/main.c
@@ -399,8 +399,19 @@ static ULONG WINAPI effect_inplace_Release(IMediaObjectInPlace *iface)
 static HRESULT WINAPI effect_inplace_Process(IMediaObjectInPlace *iface, ULONG size,
         BYTE *data, REFERENCE_TIME start, DWORD flags)
 {
-    FIXME("iface %p, size %lu, data %p, start %s, flags %#lx, stub!\n",
-            iface, size, data, wine_dbgstr_longlong(start), flags);
+    static unsigned int once;
+
+    if (!once++)
+    {
+        FIXME("iface %p, size %lu, data %p, start %s, flags %#lx, stub!\n",
+                iface, size, data, wine_dbgstr_longlong(start), flags);
+    }
+    else
+    {
+        WARN("iface %p, size %lu, data %p, start %s, flags %#lx, stub!\n",
+               iface, size, data, wine_dbgstr_longlong(start), flags);
+    }
+
     return E_NOTIMPL;
 }

[Aida Jonikienė (＠DodoGTA)]

On Thu Nov 30 12:14:15 2023 +0000, Zhiyi Zhang wrote:
> Let's add an else branch and print a WARN in it. This is a stub so we
> don't want to silence it too much.

I just added the `else` branch (and rebased the MR)

[PATCH v2 0/2] MR4510: comctl32,dsdmo: Some FIXME/ERR once stuff. - approved

[Zhiyi Zhang (＠zhiyi)]

This merge request was approved by Zhiyi Zhang.