On Mon Jan 22 18:34:33 2024 +0000, Esme Povirk wrote:
I think all the cases except RedEyeCorrectionEffect can be combined into one case. I don't think the `default:` case should be reachable.
They can all be combined to one, if we don't use a union and use 'void *' as member of CGpEffect to store the parameter. I am a bit confused on how to merge the cases if we use a union.