Re: [PATCH v3 0/3] MR1825: kernelbase/path.c: UrlFixupW()

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/kernelbase/path.c:
> -HRESULT WINAPI UrlFixupW(const WCHAR *url, WCHAR *translatedUrl, DWORD maxChars)
> +/*
> -
> - from Documentation:
> -
> - https://docs.microsoft.com/en-us/windows/desktop/api/shlwapi/nf-shlwapi-urlf...
> -
> -
> -
> - UrlFixupW attempts to correct a URL whose protocol identifier is incorrect.
> -
> - For example, htttp will be changed to http.
> -
> -
> -
> - LWSTDAPI UrlFixupW(
> -
> - [in]  PCWSTR pcszUrl,
> -
> - [out] PWSTR  pszTranslatedUrl,
> -
> -
>   DWORD  cchMax
> -
> - );
>
> +*/
> +HRESULT WINAPI UrlFixupW(PCWSTR url, PWSTR translatedUrl, DWORD maxChars)

Without trying to get bogged down in style, this change is somewhat counterproductive; we tend to avoid P* typedefs in new code, and we also have been abandoning the use of "documentation" style headers, which rarely convey any useful information.

(This also doesn't really belong in a commit which should only affect tests.)